From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454503DB31D for ; Fri, 3 Jul 2026 14:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089090; cv=none; b=Evrl85wxEM4sVSDfVGth9QbzoEhidqaj87xG8eXNpwy2Eh0CMJmfBVSrEzQ1S19nFivYNZw5Yo1Iks5JdXiogY2liC8VXECkMdwRmG1toE3/aGvhklEUz/ozrrL7d0ztgwmDUaRO9k2yCMxeZdrOT40SdH9Y9DiTmCrwlqAOD3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783089090; c=relaxed/simple; bh=DxKl22WYMhwSk+H0tEAS+Ng9aN14mc5J8WkinkLUPmo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qUUIE0hInhbLAByf5Nm0Q96daficrdEAo91pdHJoOuZsRjyrzzqbx9zwvw1o0nzBjNb0FM3Upya1N/j+pvDwfeoR/YBufVYTdvUCjKiYkamXBqOCVkCIJq5RdL2Wick+sdAG0OUt89WfaNNi4gcT6RsWTsd+wgFg3B7x2SPBVao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EIr8zNFa; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EIr8zNFa" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b779003fso3019995e9.3 for ; Fri, 03 Jul 2026 07:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783089088; x=1783693888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9VsT/jI0COZ96KSJ5oT4I95zT2XH8sWJVztlvb5FlAM=; b=EIr8zNFa7d6hRQHEL0zU/l6JiztazJtCjPWVtRSxTH+UFHZCxAdoIyLTZh4gArNsCI gI2Mm8o12gfEzF62fTppdw+0pHwAwgyXZgzcp6O4Gr7ZS9eWvs565iZJrtLE7QoDn9RN 6lwVkHnqm7y66HDgaSaFvXcP1EIOhn6L+DNlLIDtAt6SiRRXiM27U8aBB2U4+GBvji7M mOlR+CjKVObb2+17C9IAFGvOGVrQ1sqzaojsewk2EIv6AHdBHbQ2NQ5/ZCxyOijp5ve7 Qq/sAoMt+5kFrMX5gT4Ssss2l5Z6r5gg3mtSWqDI41eh2QjeNBgaryPpzBxz7czyYR32 uDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783089088; x=1783693888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9VsT/jI0COZ96KSJ5oT4I95zT2XH8sWJVztlvb5FlAM=; b=pyk9F55PoAlOjiYljtPU+q9jLuThTpBrllKyxpi96MViphOofsEf8fEhbkwvczAlZC c1fSzWE4nOEGe7r/kjzxbNAhd42CbjAq/1T6oC8nBF76oXa+BASL/yvWa299MiKyyjHU 0oAaqgo/0lmOzWPzxyoxRYIcU4Z5Dtzaza/7OdpJDUZ9Q0q6L4e0lqWcxZXtFRZkYk2r agv8qDGfJG5UCRpNv+8AD9AjxlRUhNfoxcl9kc02tgM3/3jF/e3OOZW6GVQFM5/KcV9o cUePslG1T0Z9eQ3iYIgSE4zJcre8g5GQ6oO1I/lI2ybWNKz8qlNiLlXOX4/8A445wBzE 8rNw== X-Forwarded-Encrypted: i=1; AFNElJ9yLPFYMbzSe0QASOp5ygQ1oOYSg+SQdmPpt1I7HUq65Z3eOIB3U56tMb8N2gNrIdBBFu7/n42OHj/LmmE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRDx0ciV1NVZINDX4m4yDY5vJG7D4T1BY+sk1d4nzzdhc4gB5b FqIDX53a9RorYE4t4U/Z4s6XO9mjxIfdpAmVo0LyC0hY7znuc1eK4IYP X-Gm-Gg: AfdE7cne5k6Rl6ftVHvZ/UnwqIvgyyNXufuMOAKfZKz/4kn/2Jzx/9DvRtBTMlH3XN7 BGPzDpUKQY8xvyt7u9njpWp0WKf/lI6C1tH9MWJGLIuS4YnRKjFKMH72AAO3p+itbq+KxUVj2NG R7nKNGEKIeDBiAyEFeUzkKMiOWw8My1T531ZfOcdlpO8afVYfy8cWhDxT47R/u3RdQzWk3eTDJQ qlSEG/iaqxiXT5PdeqpI4My13/p6mUNFbnu7F1/54c1gwoUWCtsllIFWAbnWiWRMbyaE2ngDOfO DIZm2VKjhSpL+3dx9lfMs13GQfeb1PGZ1ptBw7K09XZpJCUtoTp0W6XBwIy9doTWPVoAb1u8PQF hw1ckAm2AHRGAk4yj7TIrZvXUouOW3fzwZQldz9oPhrqmjZZv5pHkSaKtdNODH/J8lMYGW5JCAj CQ3PGrpGLrMfTmmvIizgwplMmstj3O4dNUg9owJJ0acYYmBGvlWGRE4ISKBQ9A+iGQ6+3A6A== X-Received: by 2002:a05:600c:698d:b0:492:66fb:5dc5 with SMTP id 5b1f17b1804b1-493d0f34376mr1059005e9.24.1783089087448; Fri, 03 Jul 2026 07:31:27 -0700 (PDT) Received: from localhost.localdomain ([85.193.42.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbc75sm19462711f8f.5.2026.07.03.07.31.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 07:31:27 -0700 (PDT) From: skvarlamatus@gmail.com To: sgarzare@redhat.com Cc: asmadeus@codewreck.org, ericvh@kernel.org, linux-kernel@vger.kernel.org, linux_oss@crudebyte.com, lucho@ionkov.net, skvarlamatus@gmail.com, stefanha@redhat.com, v9fs@lists.linux.dev Subject: Re: [PATCH v2] net/9p: add vsock transport Date: Fri, 3 Jul 2026 16:31:25 +0200 Message-ID: <20260703143125.45423-1-skvarlamatus@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, Jul 03, 2026 at 09:12 +0000, sgarzare@redhat.com wrote: > >The privport mount option is not currently supported for vsock and > >returns -EOPNOTSUPP if specified. > > Why not? The existing p9_bind_privport() implementation is TCP-specific (uses inet_pton and struct sockaddr_in), so it cannot be reused for vsock directly. Per Stefan Hajnoczi's suggestion, I opted to reject the option cleanly for now rather than leave it silently ignored. Support can be added in a follow-up if needed. > >- fd used passed file descriptors for connection > >+ fd uses passed file descriptors for connection > > nit: unrelated change? I noticed it as I was adding the vsock line below, but you're right, it's not related, so I'll drop it in v3. > The rest LGTM, so for vsock point of view: > > Acked-by: Stefano Garzarella Thank you! -- Matus