From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92E73E16BD for ; Thu, 9 Jul 2026 10:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593620; cv=none; b=Ji57g7h/lfPpzhdymmGrZQau+mZn6Wgsz3toscg2bAoVLtB4rwphkmDufutsNgz6VYxTuDtnfMbIzaSSY7f+PWv4YkTHRSZ13qXDP8HapbsLRpPb8GGz+4oK6UxPUaXpZKTL3CTQbsLvbVUfrry/0eEpIpl26OwjGLo/UMmelsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593620; c=relaxed/simple; bh=P/9frszRQMakq6rP5ZGKnqg5po7DL2Q/XbvzX/5O6c8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=kO2CYMsKzRbv++OjoKaNynqDXhs1lqBDH7qT10K1orOIH3SOpJAYrZ9dJjFwiiPAdqmXAiHgWECC+1/VPdE5UYhbtvfTXqY9KkZUzIVo2DZss6cAoCmYQYOQgK+BNYHC38TpvjLDM7gQyFZgFZHgGDykj3nfVtoGXY3LoHpaLs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GKvdgU9p; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GKvdgU9p" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-49c86d1d21cso779703b6e.3 for ; Thu, 09 Jul 2026 03:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783593618; x=1784198418; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:content-type :mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/sRIoL7V8Ni/joRex0fbhmsiGIOha2+4T7QCV85MKdE=; b=GKvdgU9pzSz13KFBWkzx0BTLPfDoUgF7ATUROFgZI2li2ex4xZBOZwkiQF99SnuvB9 OV4j1k5C5a1WvqbvbZV7U5VshSF6QUt9AqWkatd988nuXhjsZVbywsjd6JGh+sEpAPNz AhA5ukeDZYjRhLINWKJLlzFgf0Y6FLL/AE5iF41Tp18SuDQdb0ijDQ5fv+ZMyT5wXRKY SL+5zzR35nidunS9uLPdApX3I94uyxjC+743wOYm0az4p/QH68AZHbscKn49dz9qLNrx Xzr3y0mn42dfiTf8MULfCNHVDUK5RgvvCPErFQ1UVvCdjNawJaJvgmvJZqlAJHXjLlar 4a7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783593618; x=1784198418; h=content-transfer-encoding:content-disposition:content-type :mime-version:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/sRIoL7V8Ni/joRex0fbhmsiGIOha2+4T7QCV85MKdE=; b=kpYhde5BIahoaa19sPQJvNa+by+rQazNhRqDMXgquQZHdBDKwiyGr8vZSbmezFuyiK aIinJ0vP2wI1kbDpXcRJHh5XuecMYkLDWS4FxliYUKaFdeIRgFcWJb6UJaVV0DfR5pFA 49mu+EVbPvdDL8izo0qqjMbYyLeTPU+w4AGDb0HUAx+0vYcLLo0NGAeAb9ahxKdzcNCd kdKjkUrxCP90zZyKyxQihlavvel1T7fsusV/g5XR2ZZjHRyZX8P98PqqcVo/6mHOQ/eh FQtUCRBBp+2WLmmJuaiKIyEx+4bNDqX6wvYnzKEBBoXaE+2LGxJLhlhHBt4ON7sX3jQe 7t8g== X-Forwarded-Encrypted: i=1; AFNElJ+O5bqaagLQMu6ONwrV2C5l6ZG9R+ydLBpZF3No8BPJhAuGMU1Nq3wSxqRNEXMCB0NdMPEwDwzKrmTGOH4=@vger.kernel.org X-Gm-Message-State: AOJu0YyDSCSDKGDVdN8dM7PL9Y7jrtzClTIrpqGO/fIPfuosGVaFjXbD WA3G377+WPPnTgbr/zjG7Gt30u4DekDxzdq9qMB3q8T7AFn6g3EBq8po X-Gm-Gg: AfdE7clm/0Cv8+5CNLcU+5lQR0HIM0V3ZFMDdYb4lSuD/U7J6SYhiOZFvoRXLE/6t3r RGjJfSRIXXEjykl8ZfQud1kmYcDCCuhTd7W+YQGCQbO41ITobS3YI8fe63wWnPzk8gV0Jq66TLf MV1uj9zgDjqu7k+1fW8atUchf4Os1bj83GZGadp+YU+n1VY7xGatqbBDnwwdqaUiawni/9jwbg0 ARNX3xMtBEf0nKH70HP1y7uwYOMm09LyLrVYHM2/N0PfMYlyLMXVA//Ln9Qi2MYGce6+0mOmEb1 iyKHPUtrw7Spt4HCFtIsW1UsNQcFEN3Kb6LP63px0T57cf9x0sYv6/n3EHuBrpRL4kZyA6VGYsW zrcehd4aoGaq3Caar2EcaiFNWpDcrHCUtkusZqf9krnUDYl6pscHNkZrC4gVtbJnm3J6alRKj1o NdRsCIi3KFTR9uRFs= X-Received: by 2002:a05:6808:1b24:b0:495:dea9:3b6 with SMTP id 5614622812f47-4a203dbf803mr4963728b6e.26.1783593616928; Thu, 09 Jul 2026 03:40:16 -0700 (PDT) Received: from localhost ([74.80.182.70]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1ad6b73c1sm3495895b6e.7.2026.07.09.03.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 03:40:15 -0700 (PDT) Date: Thu, 9 Jul 2026 13:40:09 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Xu Yang Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Frank Li Subject: drivers/usb/chipidea/ci_hdrc_imx.c:532 ci_hdrc_imx_probe() warn: missing error code 'ret' Message-ID: <202607031656.FR3Xrved-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 51512e22efe813d8223de27f6fd02a8a48ea2323 commit: 2e9762f45efb53e7e7fc61f4ebf7a3507f5daa45 usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name config: microblaze-randconfig-r072-20260703 (https://download.01.org/0day-ci/archive/20260703/202607031656.FR3Xrved-lkp@intel.com/config) compiler: microblaze-linux-gcc (GCC) 14.3.0 smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 2e9762f45efb ("usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202607031656.FR3Xrved-lkp@intel.com/ smatch warnings: drivers/usb/chipidea/ci_hdrc_imx.c:532 ci_hdrc_imx_probe() warn: missing error code 'ret' vim +/ret +532 drivers/usb/chipidea/ci_hdrc_imx.c ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 527 data->wakeup_irq = platform_get_irq_optional(pdev, 1); ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 528 if (data->wakeup_irq > 0) { 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 529 irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name); 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 530 if (!irq_name) { 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 531 dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n"); 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 @532 goto err_clk; ret = -ENOMEM; 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 533 } 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 534 ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 535 ret = devm_request_threaded_irq(dev, data->wakeup_irq, ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 536 NULL, ci_wakeup_irq_handler, ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 537 IRQF_ONESHOT | IRQF_NO_AUTOEN, 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 538 irq_name, data); ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 539 if (ret) ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 540 goto err_clk; ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 541 } ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 542 05986ba9b025ae drivers/usb/chipidea/ci_hdrc_imx.c Sascha Hauer 2013-08-14 543 ret = imx_usbmisc_init(data->usbmisc_data); d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 544 if (ret) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 545 dev_err(dev, "usbmisc init failed, ret=%d\n", ret); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 546 goto phy_shutdown; d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 547 } d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 548 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 549 data->ci_pdev = ci_hdrc_add_device(dev, 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 550 pdev->resource, pdev->num_resources, f6a3b3a37c4772 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-06-13 551 &pdata); 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 552 if (IS_ERR(data->ci_pdev)) { 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 553 ret = PTR_ERR(data->ci_pdev); 18171cfc3c236a drivers/usb/chipidea/ci_hdrc_imx.c Alexander Stein 2022-06-14 554 dev_err_probe(dev, ret, "ci_hdrc_add_device failed\n"); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 555 goto phy_shutdown; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 556 } 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 557 df17aa9fb31f6a drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-10-09 558 if (data->usbmisc_data) { 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 559 if (!IS_ERR(pdata.id_extcon.edev) || 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 560 of_property_read_bool(np, "usb-role-switch")) 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 561 data->usbmisc_data->ext_id = 1; 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 562 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 563 if (!IS_ERR(pdata.vbus_extcon.edev) || 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 564 of_property_read_bool(np, "usb-role-switch")) 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 565 data->usbmisc_data->ext_vbus = 1; d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 566 d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 567 /* usbmisc needs to know dr mode to choose wakeup setting */ d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 568 data->usbmisc_data->available_role = d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 569 ci_hdrc_query_available_role(data->ci_pdev); df17aa9fb31f6a drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-10-09 570 } 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 571 05986ba9b025ae drivers/usb/chipidea/ci_hdrc_imx.c Sascha Hauer 2013-08-14 572 ret = imx_usbmisc_init_post(data->usbmisc_data); a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 573 if (ret) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 574 dev_err(dev, "usbmisc post failed, ret=%d\n", ret); 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 575 goto disable_device; a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 576 } a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 577 e14db48dfcf3ab drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 578 if (data->supports_runtime_pm) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 579 pm_runtime_set_active(dev); 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 580 pm_runtime_enable(dev); e14db48dfcf3ab drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 581 } 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 582 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 583 device_set_wakeup_capable(dev, true); 6d6531104d2069 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 584 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 585 return 0; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 586 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 587 disable_device: 8e22978c57087a drivers/usb/chipidea/ci_hdrc_imx.c Alexander Shishkin 2013-06-24 588 ci_hdrc_remove_device(data->ci_pdev); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 589 phy_shutdown: 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 590 if (data->override_phy_control) 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 591 usb_phy_shutdown(data->phy); ea1418b5f1a394 drivers/usb/chipidea/ci13xxx_imx.c Sascha Hauer 2013-06-13 592 err_clk: 5dbe9ac28355fd drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2023-12-28 593 clk_disable_unprepare(data->clk_wakeup); 5dbe9ac28355fd drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2023-12-28 594 err_wakeup_clk: 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 595 imx_disable_unprepare_clks(dev); 8cab0e9a3f3e8d drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 596 qos_remove_request: d1609c312d42f3 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2019-04-28 597 if (pdata.flags & CI_HDRC_PMQOS) 77b352456941e8 drivers/usb/chipidea/ci_hdrc_imx.c Rafael J. Wysocki 2020-02-12 598 cpu_latency_qos_remove_request(&data->pm_qos_req); 141822aa3f79ef drivers/usb/chipidea/ci_hdrc_imx.c André Draszik 2019-08-10 599 data->ci_pdev = NULL; 74adad500346fb drivers/usb/chipidea/ci_hdrc_imx.c Joe Hattori 2024-12-16 600 err_put: 4e28f79e3dffa5 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 601 if (data->usbmisc_data) 74adad500346fb drivers/usb/chipidea/ci_hdrc_imx.c Joe Hattori 2024-12-16 602 put_device(data->usbmisc_data->dev); 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 603 return ret; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 604 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki