From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D6E30ACF0 for ; Fri, 3 Jul 2026 16:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783097938; cv=none; b=EKlXeFjjxdNHUjzaBClpsP7c4Ilorp/w+E6yATMe4fHTTXnPRwiD5Ut2WbrSjlPknQzra50kfTkDwWKEQsbA+qkgODs43hUk6xYoSxsDKHz2q357mkMv16l5tVcT5f2fPv50FB1qXlgvO+rAFVhRZzAml6o7BnhEmw/uYo5mmjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783097938; c=relaxed/simple; bh=8Sh0ZapBO5HhbmK4razIBjbrZy74H3yVffS4gyHeCZw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ltmxiyoCZQQgTyGhl+v7aNZittsByHr0uspsDGNx61xUZH2/Mj7hqv3VoI/p/8dVBXkOVmH0boGK3cWbFnEwFgaurLHyYBm4Nz6aqE62k7O5wbScGZQ2ajbh3RK+LX+8I+ix4aPVfB59q2JmAilCdpG5JvF2/xJbPL5wp1XEqmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iaNmMNlX; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iaNmMNlX" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783097932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q4FgBAGOtVqoAkgaBXGYo/0h+uTit4LUDfTjDWMATQQ=; b=iaNmMNlXIEED9kIXU6PpvwnZkav0b57801IIiImrQyKbHL0nVWWrXO9H/Nw2E7oeY6Qm1x gLMZEX634nh1ino0Btv5Z169gTAILFomD8qgMqCrf75Q5rznqLZiGsO4FORBroqWJgBWOD x5KwJwRG4hBHTWRbA1nCFiaCEFqI9ls= From: Thorsten Blum To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Justin Stitt , Kees Cook Cc: Thorsten Blum , stable@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/ps3: Fix repository.c build failure Date: Fri, 3 Jul 2026 18:58:35 +0200 Message-ID: <20260703165834.137242-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2088; i=thorsten.blum@linux.dev; h=from:subject; bh=8Sh0ZapBO5HhbmK4razIBjbrZy74H3yVffS4gyHeCZw=; b=kA0DAAoWXqtxINjMdS4ByyZiAGpH6jui18HJkbScRPepAnHtvHj3W/d5KSuRwpr7dc0afx8Aa 4h1BAAWCgAdFiEE4Jr4mE11fHmyNFi5XqtxINjMdS4FAmpH6jsACgkQXqtxINjMdS6ijgD+LFmq TZ5L2ZMYVnIAec2nci4G4Ot/KT5LRhXOBex8CRQA/j4GER9ut3jGx9ghyxZalV/D5Py2EHh346r rYGcHUFIM X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT GCC fails to build ps3_defconfig with the following errors: arch/powerpc/platforms/ps3/repository.c: In function ‘make_first_field.constprop’: arch/powerpc/platforms/ps3/repository.c:78:9: error: ‘strnlen’ specified bound 8 exceeds source size 3 [-Werror=stringop-overread] 78 | memcpy((char *)&n, text, strnlen(text, sizeof(n))); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/ps3/repository.c: In function ‘make_first_field.constprop’: arch/powerpc/platforms/ps3/repository.c:78:9: error: ‘strnlen’ specified bound 8 exceeds source size 4 [-Werror=stringop-overread] 78 | memcpy((char *)&n, text, strnlen(text, sizeof(n))); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The current use of strnlen(text, sizeof(n)) triggers -Wstringop-overread when text is a short string literal that is smaller than sizeof(n), such as "bi" or "bus". Use strlen(text) instead and clamp the copy length to sizeof(n) before memcpy(). Drop the redundant char * cast while at it. Fixes: f94a84a09148 ("powerpc/ps3: refactor strncpy usage") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum --- arch/powerpc/platforms/ps3/repository.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/ps3/repository.c b/arch/powerpc/platforms/ps3/repository.c index b8c030eab138..0cc755ac3e7f 100644 --- a/arch/powerpc/platforms/ps3/repository.c +++ b/arch/powerpc/platforms/ps3/repository.c @@ -6,6 +6,8 @@ * Copyright 2006 Sony Corp. */ +#include + #include #include "platform.h" @@ -74,8 +76,9 @@ static void _dump_node(unsigned int lpar_id, u64 n1, u64 n2, u64 n3, u64 n4, static u64 make_first_field(const char *text, u64 index) { u64 n = 0; + size_t len = min(strlen(text), sizeof(n)); - memcpy((char *)&n, text, strnlen(text, sizeof(n))); + memcpy(&n, text, len); return PS3_VENDOR_ID_NONE + (n >> 32) + index; }