From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D575730D41E for ; Fri, 3 Jul 2026 20:10:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783109433; cv=none; b=joIU6PwoAKlYHp8JYDlbaOA7eLoKh/PQZ57reP2aqDVTfr95IG9n+jLN9BpKFjiVmpUuCgOsRG5KhJPmTaSS/QT8F6vAYO5shuCQwlB3HG9HxjzxTziCitnHrlC/1HPZ17m4sXocafH/UwTyDa2kN15ki1gveOzQBQCC+iUBV4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783109433; c=relaxed/simple; bh=He9wd9IbrQP2KSQwF5K2+zJwvvEyQHC5+Yuz+010GQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hCqI2yb8ipS/Amf+27aWnCSZJbxlTz/9B1hJGNVBA2Gn9t/UjpBkbZS3Iw3vs7aQhFIjrsm5ORGv9fR0CLrW6DkdTlyRuewzFNJxCN6z+FG9b566dYa4vW4h7DY/AeebZ/ZmpY5Qni64J1izMgJn+CgJ6l9MahfdyUN3c861lkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YXiXe231; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YXiXe231" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-51c29b46382so4930451cf.3 for ; Fri, 03 Jul 2026 13:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783109431; x=1783714231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VqnVxuePfzGralo5ejKJTMgkZosmeyctDuCT0QENgCw=; b=YXiXe2318KrU/NSWoyLfZvFitIe/ZWYd7E1zkHni8xxK44fOYVg8KGhysyb04D6Dbd WsOYugRunDHb5YWgSbxkWqnrh5sapynSUB3p2UiyaY8Mvb+Lu02JcflYIk2BYumEpP9a uzUgW0acVwRKLi7pSJEiq08nH0D6T6tI1t+dYkkEcfGmIQGKemTxFBq5rk0qu5ec0nH+ 5aN5ScSVnNe5JrMlLqSDSOFpk78Wvl0t8j0zg+mVr12aNe3BroS0Z+CAywv6amoPqtvL TSWr9jzqQ1kJfKCsMAdi1qzFQb8dp/qjQ3zmpkMcv6ipbyLwcKIEsmSZ0uYlafng9MWP 5qdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783109431; x=1783714231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VqnVxuePfzGralo5ejKJTMgkZosmeyctDuCT0QENgCw=; b=NCIKW2jbieP2rdMiYDW4YUyS3FAYH2fs55x4QgXIwaKZ+yZWvIlHqsSIIbDgbwACOl iKSFINc1iAKP8wGtQYjWqTVA2l3I6OWj06hPKiiYSoFljIZsXbG1qtqlkLEumiWtlyuu 6BhAsodsvddp73neaOXcnbGO7jRB0w7cqyuKWq+JapnEALMegT30S9mc4XA4eZ2GWL25 7u3Svwx4O6UN8jCyPbo4Ab4KVPaiK+LJRujTaQg2JacZ7V6hE+tJC2WZRaHMDcK0X5XW fllk5gdwX1PJ7YX61EO+CC5B49GRaZL/UceJvlc2v3ataXMXKjpefOvfkit6FQ4NwHzj atjg== X-Forwarded-Encrypted: i=1; AFNElJ+ivNDafmW+cgB6/G8LRGu/zDYt33CUAvunP4v4sUgc0mO+ECq/EYUVLKLLewdirW2pdRE6klt3lFjPJxM=@vger.kernel.org X-Gm-Message-State: AOJu0YyDQaUcF8LJZS6Qa2zj0mlIlofi3bMtF3v5gO4+UlimA2kHdti0 qzKXBFZJDEsEROhUPt6eGnCa9bMJLN/bRcciWHcAeeNC1GXSUUEIDhzt X-Gm-Gg: AfdE7cmrImQYDpEflWM7dITR5ZCJNpwRxZsZYBBYiMmt18LlhMm4TlFbxV05DMUE/Xn olz2c4KfQHKX/kAdjPYLW+gQgfXjkcLUYkC5Smw6AcI46CgQyivDvsMKlKX2KieBrbt6MGZkvWj K16e5M5IUymoajkAwD1uYRQFTPDIwgSAuZR5oXuY64PPS0lDnbmT2KTUEVYpkE9pbpqKezbFYlA fyvNN51MXVq50WltFyLL16NSvRWJ/iaLRAI7ENCwuZSgj/Gkuqlp9zKwaWWi9cAgW730S8RBGhQ x/M+4eJSgEMag2dnpvbnICqqhgJWfN4iNRVhAwgN7oMJ59S8zlAtcMNuuoviGgpecYeMy/JDJ3n xaI+W/tgsNW0nFk9bJngN5kO5f5QK+udWLpg+pkt5k3p0IUQXdA8aQ1PJFiAlfQ4FkWxCT4wkgF LTXa+nBMz5SvFLtExHQ3SRjUqfKTHxE5tCspo3adDgpSuvPgSZimfbOdcC+LZR7A2pBdpzupgmN w== X-Received: by 2002:a05:622a:85:b0:51b:ecca:f2e0 with SMTP id d75a77b69052e-51c4c1e6500mr15034181cf.5.1783109430605; Fri, 03 Jul 2026 13:10:30 -0700 (PDT) Received: from oklopfer.hsd1.ma.comcast.net (c-73-167-46-184.hsd1.ma.comcast.net. [73.167.46.184]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41df52a6sm22259141cf.27.2026.07.03.13.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 13:10:29 -0700 (PDT) From: Oren Klopfer To: oklopfer37@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Peter Robinson , Thorsten Leemhuis , stable@vger.kernel.org Subject: [PATCH v2] Revert "arm64: dts: rockchip: Further describe the WiFi for the Pinephone Pro" Date: Fri, 3 Jul 2026 16:10:10 -0400 Message-ID: <20260703201010.67311-1-oklopfer37@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260615225014.219115-1-oklopfer37@gmail.com> References: <20260615225014.219115-1-oklopfer37@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This reverts commit 096bd8c679185f898cae9933c6a68650fa26ea4f. Just as with the Pinebook Pro, there are multiple chipset variants for the Pinephone Pro, and multiple firmware binaries for different distributions. The change causes issues with some of these combinations, and reverting it resolves the issues. See the Closes below for the full report. Similarly with the Pinebook Pro adjustment, the original commit only indicates "further description" and not indicative of fixing any existing issues, so reverting should not kick any back up. Fixes: 096bd8c67918 ("arm64: dts: rockchip: Further describe the WiFi for the Pinephone Pro") Cc: Heiko Stuebner Cc: Peter Robinson Cc: Thorsten Leemhuis Cc: stable@vger.kernel.org Closes: https://lore.kernel.org/r/20260607225901.64019-1-oklopfer37@gmail.com/ Signed-off-by: Oren Klopfer --- v2: - Repair malformed whitespace .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 8d26bd9b7500..d46cdfe3f784 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -734,12 +734,6 @@ light_int_l: light-int-l { }; }; - wifi { - wifi_host_wake_l: wifi-host-wake-l { - rockchip,pins = <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; - }; - }; - wireless-bluetooth { bt_wake_pin: bt-wake-pin { rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; @@ -766,19 +760,7 @@ &sdio0 { pinctrl-names = "default"; pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; sd-uhs-sdr104; - #address-cells = <1>; - #size-cells = <0>; status = "okay"; - - brcmf: wifi@1 { - compatible = "brcm,bcm4329-fmac"; - reg = <1>; - interrupt-parent = <&gpio4>; - interrupts = ; - interrupt-names = "host-wake"; - pinctrl-names = "default"; - pinctrl-0 = <&wifi_host_wake_l>; - }; }; &pwm0 { -- 2.53.0