From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F10F364926 for ; Fri, 3 Jul 2026 11:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076462; cv=none; b=VhfjamKFSQTl1iz8tM9mipAoHw4lKjP0+lq+mqpUWWSpdA7yb6VV0mEJ6D6veDS4vxoi9+3m1Ivi+uYBlrPeFAbPU4E/5TLdOkuAtn70aSE/AAGu5Vc/axNs4CYQ4NfQOcOrsW0+hlLVUJ685XUZIiXs2iGN3i6GP3H0D8D1v4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783076462; c=relaxed/simple; bh=VZEpa7Fr+rCSVjVg10ZUlwxuHq1QshSUAWP/S/kZvYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rSFyKa8Vmuvm6HUQK/PNJFVSlWa82xAh3sfCQzvFgAniWjR/tMcP1Qdayedv+WB0pO9clufVupPRsNXoV4R5k1Pa6MW2nJuDs0wczlFZDHvO2l4DO6orFMH4M+0lfKIPAPS6FWkpgQABNdBamBeeKpR1KDnHjGC5sE3cvYo13HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JqRc0ge0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JqRc0ge0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63FE51F000E9; Fri, 3 Jul 2026 11:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783076459; bh=sabPiJsYgQup+wvSkz9gFtMUgOZvj4AFEsJ0vJ306HY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JqRc0ge05nblUgF2b/LeuCzAPvgHqBwqRk0Dxn6AvlNzs5TOPjVtr7bU6qFVv+tUE fg2XaUy/CNsviVvG5Ttvv3Y2PgIPDT+GGlGSC9JGev0+xHSBL3MgAhz1P9UaAgoi5n CkQxx1j1RdDxA5yVkT2saEEf4Y7stLRTVqEXz9o4= Date: Fri, 3 Jul 2026 13:01:10 +0200 From: Greg Kroah-Hartman To: Alexander Usyskin Cc: Menachem Adin , linux-kernel@vger.kernel.org Subject: Re: [PATCH char-misc] mei: lb: fix incorrect type in assignment Message-ID: <2026070333-rabid-flavored-4e6e@gregkh> References: <20260610-fix_type_le-v1-1-15c2b08b6451@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610-fix_type_le-v1-1-15c2b08b6451@intel.com> On Wed, Jun 10, 2026 at 03:57:52PM +0300, Alexander Usyskin wrote: > Fix the mix between __le32 and integer by defining > the MEI_LB2_CMD constant as __le32. > > Fixes sparse waring: > drivers/misc/mei/mei_lb.c:284:32: sparse: sparse: restricted __le32 degrades to integer > drivers/misc/mei/mei_lb.c:330:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] command_id @@ got int @@ > drivers/misc/mei/mei_lb.c:330:40: sparse: expected restricted __le32 [usertype] command_id > drivers/misc/mei/mei_lb.c:330:40: sparse: got int > > Fixes: 773a43b8627f ("mei: lb: add late binding version 2") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202605091533.79Zcv3CX-lkp@intel.com/ > Signed-off-by: Alexander Usyskin > --- > drivers/misc/mei/mei_lb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/mei_lb.c b/drivers/misc/mei/mei_lb.c > index f6a258c2b838..a4e3f788c8b8 100644 > --- a/drivers/misc/mei/mei_lb.c > +++ b/drivers/misc/mei/mei_lb.c > @@ -104,7 +104,7 @@ struct mei_lb_rsp { > > /* Late Binding version 2 */ > > -#define MEI_LB2_CMD 0x01 > +#define MEI_LB2_CMD cpu_to_le32(0x01) This will give you an odd thing when you use this directly in a printk() later on. So perhaps fix this correctly where it is used instead? thanks, greg k-h