The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Carlos Llamas" <cmllamas@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] rust_binder: clear freeze listener on node removal
Date: Fri, 3 Jul 2026 12:27:23 +0200	[thread overview]
Message-ID: <2026070344-alike-ducktail-5fe0@gregkh> (raw)
In-Reply-To: <20260615-remove-freeze-on-remove-node-v2-1-93b31766e7a8@google.com>

On Mon, Jun 15, 2026 at 01:13:16PM +0000, Alice Ryhl wrote:
> Generally userspace is supposed to explicitly clear freeze listeners
> before they drop the refcount on the node ref to zero, but there's
> nothing forcing that. Currently, in this scenario the freeze listener
> remains in the freeze_listeners rbtree and in the remote node's freeze
> listener list, even though the ref for which the listener is registered
> is gone. This could potentially lead to a memory leak due to a refcount
> cycle. Thus, remove the freeze listener in this scenario.
> 
> Cc: stable@vger.kernel.org
> Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver")
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> This series is based on top of:
> https://lore.kernel.org/all/20260615-binder-noderefs-spin-v3-0-3235f5a3e0a0@google.com/

Hm, but that's not a bugfix series, so I can't take this patch now for
7.2-final.  Do you want to redo this one or wait for 7.3-rc1?

thanks,

greg k-h

  reply	other threads:[~2026-07-03 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 13:13 [PATCH v2] rust_binder: clear freeze listener on node removal Alice Ryhl
2026-07-03 10:27 ` Greg Kroah-Hartman [this message]
2026-07-03 10:31   ` Alice Ryhl
2026-07-03 10:44     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070344-alike-ducktail-5fe0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox