From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A893F3D952B; Fri, 3 Jul 2026 10:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783075432; cv=none; b=SwgjWjG4pbHXEuODDkhJ3MmPN3ixrpb1+Ahu5fu5xhEr3Wtr87qWPGaN1Axju1/4XbFxCrG84vnQ1PSsQdmqFFkbm0cReEnp23+QZKjAGU+ZhY51TLZCdwVmoBrd59Ufh1xhwtFZSmC97f1R9qVb4PZADoGrVcCpZXUtrmBUraE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783075432; c=relaxed/simple; bh=fBrun7eOA73kZc7NK6fiNO2andM9BoI/53VKoOLQtRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F1V76kViFe3acmuYc4J3Hcs33o5AizI3jLFN5lVAs8sZdSzWtjMahEDaUzeKcjUjCF7z4BP7d8LewC+PqmvchZ54ss+W6dtKW0Ii1F/X+eM+ae4kK+phr80CIOZcFNEpEfNpbVh9kho3w/lWUb9JC9/aht+1vsu7nTDWTl/z3gM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2qIkdEJ3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2qIkdEJ3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDF281F000E9; Fri, 3 Jul 2026 10:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1783075431; bh=FAC+Sn738JC5K5fZooG4j32IFdZBaKWSzQu+dKY4nj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=2qIkdEJ3Dyyep0wbGY63F9d+QBfwa/1Et1FE4DvLnrfRtfgfrqPG3PqcdglXJc+TT ouOTqHafGcf7ctt4V3v0Akqw1gIPYbZpTfjgu9gdZRcUqP08V5noQ+bCNASZVYxCtW 3+5971SADThzSh9FrU9Ocms1n46Vee1pEMga30pE= Date: Fri, 3 Jul 2026 12:44:01 +0200 From: Greg Kroah-Hartman To: Alice Ryhl Cc: Carlos Llamas , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] rust_binder: clear freeze listener on node removal Message-ID: <2026070357-expediter-neuter-b331@gregkh> References: <20260615-remove-freeze-on-remove-node-v2-1-93b31766e7a8@google.com> <2026070344-alike-ducktail-5fe0@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jul 03, 2026 at 12:31:43PM +0200, Alice Ryhl wrote: > On Fri, Jul 3, 2026 at 12:27 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 15, 2026 at 01:13:16PM +0000, Alice Ryhl wrote: > > > Generally userspace is supposed to explicitly clear freeze listeners > > > before they drop the refcount on the node ref to zero, but there's > > > nothing forcing that. Currently, in this scenario the freeze listener > > > remains in the freeze_listeners rbtree and in the remote node's freeze > > > listener list, even though the ref for which the listener is registered > > > is gone. This could potentially lead to a memory leak due to a refcount > > > cycle. Thus, remove the freeze listener in this scenario. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver") > > > Signed-off-by: Alice Ryhl > > > --- > > > This series is based on top of: > > > https://lore.kernel.org/all/20260615-binder-noderefs-spin-v3-0-3235f5a3e0a0@google.com/ > > > > Hm, but that's not a bugfix series, so I can't take this patch now for > > 7.2-final. Do you want to redo this one or wait for 7.3-rc1? > > I can reorder them. Great, thanks!