From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD0B2DEA64; Sat, 4 Jul 2026 05:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783142489; cv=none; b=l6faLAeXvfV/zzhLKuF/LrqTk7eEjFM2nKlshjEmnWpHave3t/VhyJ2pp/M0RSFW2FjXF0gUF3VFRzbdjyJtqKWm4cG0D2Wou7WedR115yw/qMA/GfFlM/927sX4fg70ulRMdRO/puotkcVVlBjnvTaZkpxM++1zpmGpMeL2VeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783142489; c=relaxed/simple; bh=jEggrTol82OUXPf6ckt8EgEimMY1MYiuNQnTfMbjWlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PreJxdG2o+pi8lMXZyOYGh7NUQOe1Hrm1vsx3p3P7MSMve2pwjFbN/RRVaXfSorWOBxMj/yA6jXafrA45/DXzkNvlSnJd/Ui5GiWYsk+vJgXBFvZGi3/aDK7WrX9SvsfyGVFcFKl+BQaK5Le9dDEnzpAM9dwH3BP+OLzkGgV2Sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EP5Uch0S; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EP5Uch0S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D1861F000E9; Sat, 4 Jul 2026 05:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783142487; bh=CYDOQJsjhk530hF90YdapxyKM5jfGqkWjC+R6iH89QE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EP5Uch0SRUZ0ZvOUZvgSHjR4VJX0W+cI6Z4o48IG7MLaMhlZcHOWKdeIfkrC+jaes TmrHnTkPTSAvBztrW/s32vsUv2/esnZpsPDwpRF+tDUtKbTzDzUl7X2OHWH+4f4e0f YPgvnP4XOQYp2Hn8fml8/m9B7fZVmeKX5NIPZ9nnh3SWO2ySSGdB/iikdQUsM7l2dR SQ+KJvvFtuZrWJKcMELzIBSjj9iWSzuAvKiUh10dR0FBK0SYS59fsBRDlO3S5SURfF zl3AH0lltF5ulfkjcWHecy6VcWjVeNgrgzA1Df+36vfa6vS0kvB+HLv2uACU+g4zdL bVs8F1kl4RzYA== From: William Breathitt Gray To: Andy Shevchenko Cc: William Breathitt Gray , Mark Brown , Mathieu Dubois-Briand , Bartosz Golaszewski , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-gpio@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Michael Walle , Yu-Chun Lin , Fred Eckert , Matthew Mohn Subject: Re: [PATCH v1 0/4] gpio: regmap: Keep tracking IRQ requests and releases Date: Sat, 4 Jul 2026 14:21:19 +0900 Message-ID: <20260704052120.798323-1-wbg@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260702130903.1790633-1-andriy.shevchenko@linux.intel.com> References: <20260702130903.1790633-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2371; i=wbg@kernel.org; h=from:subject; bh=jEggrTol82OUXPf6ckt8EgEimMY1MYiuNQnTfMbjWlQ=; b=owGbwMvMwCW21SPs1D4hZW3G02pJDFkeM3jm9l7I322/o3DnEQllyezUzX/OfVqXH5j7LejQk S/HDhT86yhlYRDjYpAVU2TpNT9798ElVY0fL+Zvg5nDygQyhIGLUwAmYmjJ8JuVk+/tQq9bC648 3TThwgIJs5c1WntuPjPMs/3qVL+LR3kXI8MKFdnMnSZKzR/FegW2Ot9eeIZhMWP0Yy855ZL9ydV rOJgA X-Developer-Key: i=wbg@kernel.org; a=openpgp; fpr=8D37CDDDE0D22528F8E89FB6B54856CABE12232B Content-Transfer-Encoding: 8bit On Thu, Jul 02, 2026 at 02:42:53PM +0200, Andy Shevchenko wrote: > During the review of the v3 [1] of the series that adds a driver for > Realtek DHC RTD1625 SoC GPIO the gap in the GPIO regmap implementation > has been discovered, id est the IRQ chip that is created by regmap IRQ > doesn't have IRQ request and release callbacks and hence in terms of > GPIO does not track if any line is locked as IRQ. This might lead to > undesired and most likely faulty behaviour. This series is to fill that > gap. Currently it only fixes the only user of the automatic IRQ chip > creation facility provided by GPIO regmap, but also provides the exported > callbacks for others to be possible to call them from customised versions > of the callbacks in the respective drivers. > > Most of the affected drivers if I am not mistaken are the Industrial PC104 > ones, hence I Cc'ed William to look at this and perhaps even test. Hi Andy, I'll take a look at these patches when I get a chance. For now, I'll CC Fred Eckert and Matthew Mohn who have tested these PC104 drivers in the past and may be interested in this patchset. Thanks, William Breathitt Gray > > Yu-Chun, can you give a try with your v3 based on this series? I believe > we can use regmap approach after all. > > The merge strategy is to go via GPIO tree with the immutable branch or tag > provided for the first patch that can be done by regmap tree for others to > consume. Of course, there are possible options, I'm all ears if you think it > will be better in any other way. > > Link: https://lore.kernel.org/all/20260512033317.1602537-1-eleanor.lin@realtek.com/ [1] > > Andy Shevchenko (4): > regmap-irq: Provide IRQ resource request and release callbacks > gpio: regmap: Provide default IRQ resource request and release > callbacks > gpio: regmap: Apply default resource callbacks for regmap IRQ chip > gpio: regmap: Order kernel-doc descriptions with the actual appearance > > drivers/base/regmap/regmap-irq.c | 22 ++++++++++++++++++++++ > drivers/gpio/gpio-max7360.c | 7 ++++--- > drivers/gpio/gpio-regmap.c | 25 +++++++++++++++++++++++++ > include/linux/gpio/regmap.h | 21 ++++++++++++--------- > include/linux/regmap.h | 2 ++ > 5 files changed, 65 insertions(+), 12 deletions(-) > > -- > 2.50.1 >