From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 512EB38D3EF for ; Sat, 4 Jul 2026 06:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144888; cv=none; b=c2vlM9L+vvRQyBfspK2yeiEEmAFkmr1nqEzgFppDFn5zDY4vNR22/ir5J4WBXF5QCCbWz8QLdfi2fXzr4KN0ZuICd+a7lBk+eoYx9H/jNAG642xkqmvW1/54tmvLNnwLVJ2E1JVxbRjulAac7YGli58KDe4UZlKsOoUANVpSi1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783144888; c=relaxed/simple; bh=nUO7dEkOKEvVNtuM2TAkm7x7KFkgTmD7CMdjUA404dQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LhN16rmE3zEYNrYZahtUo/XPUhQ8WAC4zK1F6igazIAPOPS4F37yVSZHOx40fX+idM8BPqPp++tM2z5H/BccvgmxLgrZFJwUdHjFJvP0dUKjyhhRah2Ow4dzEc8Ee5ockoSjU59hzcVJ1aFO8G4uNapUhQ8CWY+QZd0rLDKJJWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ePiNHNJf; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ePiNHNJf" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3817f800c8bso710132a91.1 for ; Fri, 03 Jul 2026 23:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783144887; x=1783749687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fqS+8jznfiHJXZ6W2GHvBNlXgFpmVGJB+A9fPcFpydc=; b=ePiNHNJf412scRHStFYZLnB6pRixzAr1qp2S6FABZXV6bB1StkKErf8yR7Q46vsBN2 eR9jAokCY87TnTdRc+oZjk+F9tYr7+v+YOAHenGtdIZcpSEWu0iqKYSPlhLxoCIvmCzs r7bIcPI+Lm4TSomCU08AjxGau7sRogGkC3r8a1+w6UFjSiwdFNc1WGkwIiAl65cIbxWC WVqTO+isiIIVouwjNV7P0/0ob+4q4c6X3ANcHv8WeaT8shwZjQfXhuOom9TQ2J/Kz0Dg 7V/m5bnt3wrofCQ+2oQqQhcifytPtY4YEMoVJWE4f8pbFI1bBeGsbju/whri35Uh33Ld t5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783144887; x=1783749687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fqS+8jznfiHJXZ6W2GHvBNlXgFpmVGJB+A9fPcFpydc=; b=aU7Le9QTNCvhRLqqjGbGpedY/DuxTZbuY6AjPUyvw93D+qjKc/6Dy1K0nF28Rqatb1 Temsf7c31sWSX9/AbCT+O7XcONImdKqiAZa2IL05RtUnLVGKxxL5Cn65FEEsRtQaDsfM 7DSSgfDE+XXKokiy93Jdmt/Bt1301wFppOEwL3PC6KjKD8ReATPQn+iSt2kTH2L9LyBp mg23NOkikjoRHLwR1mEa1HpSLa2pM4baRotJl8MYoX7YyBUF8mItwDANFa4jQYVNDS5l OgyY5v3yR8D2S2LR6ccM+/bWzsx2sKk/xu/MkMljOOgYWRj4RdULyDx2wTPn3fyJNTeS RkXQ== X-Forwarded-Encrypted: i=1; AHgh+RrD10/gq6zaNuMcf0r7bIy8LOyTbszVEx/FRFRlBQBStt7eO2jBRfHQg50U1Csg5VGppHy4PMzgNfCYElE=@vger.kernel.org X-Gm-Message-State: AOJu0YyejLyomkj8dz/g8K8685sy01HUqeCVOGRBGGtWZ7B2ap+7kwfD SR//ddzbBW9Obk6YJtNh+HnX+Rx84OK3uaFKRlQxNuuAxtRxnt71LU4z X-Gm-Gg: AfdE7ckmwp0lWeRQrrTTTl32Okm5TZISUZ+8XFNbOe0rBVM6S/zB6JSiKJSouY/Ky9w xtALL7COLbV+DUTPazJH/tQAnC7bk3TK1k/fxB2bs6Gl3ZN7su9h999bQOfZsKp52KYS61nKVke oC40rWyY/4hUOUAmIFvMH6T00Qnun7EBmG0/HfxaP6EZecPwgbMPUQs6KSQfAos6MFqC6QuchQB RF3r7BOUgcSR5OGnz0lNLdQxT6gG87xR38UcAfOoj2FEliyv//6EbHPZylJ05qMBRBOFmuCHaAT Lgf6Xc136fhy71vpdA8Opp8q3y7DtXOkKwh8aLRP1D8I4XZUznNT9rxLIEePP0wJOy/H6ozIust T5OD1dPlWnk1uA5U2/4m+hzMS66fsrWNsn7KS2MDwHdVQfPA/niksk8qr0+BGTVfl3wvBezAI8M gAn/DG/7qIoC+O+8rcDdjHQJVqRrg4NYR7C+PA+teGMgeqqHERAY3WsKztU1OOEN1iJ2b8wE5Eh KQ= X-Received: by 2002:a17:90b:184e:b0:37f:9cdf:f0ad with SMTP id 98e67ed59e1d1-3829f9e3ecamr2167194a91.28.1783144886647; Fri, 03 Jul 2026 23:01:26 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:880:86f9:3b00:6746]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f116065c5sm25081378eec.11.2026.07.03.23.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 23:01:24 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Bryam Vargas , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] Input: mms114 - fix Y-resolution configuration Date: Fri, 3 Jul 2026 23:01:14 -0700 Message-ID: <20260704060115.353049-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog In-Reply-To: <20260704060115.353049-1-dmitry.torokhov@gmail.com> References: <20260704060115.353049-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mms114_setup_regs(), the driver mistakenly uses props->max_x instead of props->max_y when configuring the low bits of the Y resolution (MMS114_Y_RESOLUTION). Fix this by using the correct property. Fixes: 07b8481d4aff ("Input: add MELFAS mms114 touchscreen driver") Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 84afdadb3bcc..27911a9f4e9e 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -408,7 +408,7 @@ static int mms114_setup_regs(struct mms114_data *data) if (error < 0) return error; - val = props->max_x & 0xff; + val = props->max_y & 0xff; error = mms114_write_reg(data, MMS114_Y_RESOLUTION, val); if (error < 0) return error; -- 2.55.0.rc0.799.gd6f94ed593-goog