From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEFB39D3FC for ; Sat, 4 Jul 2026 08:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783153901; cv=none; b=Ayz9d3xjRHnVQU7p3jetPMXv9N3M+HGraifRRpEAb448Ks2mL47ax2ivOYY1O308LICVl+IPLgdMtTkiPKbKfRoCi1/0xrHVQi1bOCvlhkm24DjoEBe+qAnqeLJi+WOStrOccY5zEqao2ny6moekFvWFlzKElXKjXOh9EOGjiZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783153901; c=relaxed/simple; bh=y6mNeTzCyc08DlRJ6m8uHGdrjccntn+S5pSqgS1q7kY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K+84STHcaj2KJqYRsQHR0YRg+Cqn2YF2Ro9NPyKCYPX/qJ8lBx8WHGDqwX84cyPiWqGtJsLYGzDp4Pp0N4a6ZPxs+7VKxAHjaF+j+57YuirEF7b3tVSL1OGqzX4VI6BiRTFqN+WOhqZCxOGgcubUo1VvrotrR/7/OM9QtTu8o8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KUf7BNMH; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KUf7BNMH" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3811e59df58so736740a91.1 for ; Sat, 04 Jul 2026 01:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783153892; x=1783758692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6SKjOfWBF6wFcd/KZhxMJdBWrz9gubI4LNJ7uJpHMQs=; b=KUf7BNMHz0ksjbzDNtXOeoCoo5wGaRDIdW/Tw1FrosXBIn9S/fPs8qwal4qxBQtnJI QpLns/KVgMACHn5e5XYyFZx1U1TfzckJq7eqvUzd/JWa2dgvPKDTYqYtk1YTSRmLwJvm UKiQfXUOKQNgqh7JyX8QoznocBCBBozAMnPObVwg5kE/1WOuS1w6sDMWgRp3TBxEIp+y Z2OdfxhL/zMpMp3dNFUIDcAKeWdYLxdNlsNu/wt1UMbw2nyATW3daj9xT1WgcqTFcmAd tEngJeiSkzzMTOt/WJRFeOdjQ6rKySiKBPPUeDyt96AfIdgYss4LQi/J4C6HnNOoUb5Q uI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783153892; x=1783758692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6SKjOfWBF6wFcd/KZhxMJdBWrz9gubI4LNJ7uJpHMQs=; b=q+7dtBrSr8HW/Ec37NfoQ//OAMIaMOqLHvAABwX6kDdXZvD3GwdFsgu3QqdzM5jHNk 5SEQVI8FF422w59czP1NBGRVGwkdnSL3zpA5wzbTCQKtCjpUuQYtDimtIcS7T+0ent40 LUk8zoZ3S3COUF0NlLWHsXYAQ+iazS3XMcySGGLCROptXcK6iiSiLLWcOjWhlLd8J4AF +zJeIp8Dqv+gKuBhl+IiCGSBnOdAKY5kCmMmk+ngrUTcG7Y7rt88HGbze6iuuOYyxlSh +2kyNZlU/6NoOgHDhW9GCgQqNka020xIzPj5/zlSx8K/2w7BA1m4LjUNvko1cKirX2ll qBVA== X-Forwarded-Encrypted: i=1; AHgh+Rr/N7cdDGoFKJ4/QIu0njf0nsUXPfqvgayqPiBY7elfpRgpIsC94DPrQe4lMMTthcxj/tETpowipA7aY5I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/Ty6YGBSnNw4jSZtfSsq+o1V9m2eUiay5opGnmBd1EXNRs5lr MKwCyqdqGCruIrlnrok68UPV5IjuuVTuh6Lim8RPn31DUtcEA4JTChTt X-Gm-Gg: AfdE7clMqMZeuiAkCIkODUgkfFvYdZgQaf8NLEmMhGlp5b6oblOVcjZ91bEPEoj5Juz 1uVp+fzr7joLfyuux2Dk/rVqgLcbyxugzubB+n9Z+UXcNmDKPPIxFiqQyhllu3w2t06byTN3Jaa kUUO+zENHUy/tcOP+oVsU86ZWwNnlg+yWEx9zREzqPehytRm4WJIznESrg7D7F54FJkbBFfo70x Bb2KE/GruELvf2TmB36qkiAcjV55/NhxAp6yniNaPuSvFtwnvAKxPf9qMURmpc+lTTDwBu5+PjY SeNxemOBBx+7ER+Vpq5tl1RbUSjYLYB5JvOEB6FIVN5eh+A7LhnJs7NmjjgbG/L7BYcOlplXKdq 6Ebg+azpzAKRWLkbM51kCgBdTH+CyxzyTo0rj8bdnKgPt/ns1dKtoii82CVkMBmbGyClf4ietus 61M7+zB69ShGArTRc8u2LSouKO+hkz9Zd7tRZCN+zXqP4QA7HxUi/U X-Received: by 2002:a17:90b:4d88:b0:37f:d9dc:557 with SMTP id 98e67ed59e1d1-3829d70cc3bmr2590824a91.16.1783153892139; Sat, 04 Jul 2026 01:31:32 -0700 (PDT) Received: from primary ([223.181.23.202]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f376bf710sm10074745eec.6.2026.07.04.01.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 01:31:31 -0700 (PDT) From: Vidhu Sarwal To: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org Cc: bingbu.cao@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, kernel-mentees@lists.linuxfoundation.org, Vidhu Sarwal Subject: [PATCH 2/2] staging: media: ipu7: fix pm_runtime refcount leak in ipu7_resume() Date: Sat, 4 Jul 2026 14:00:31 +0530 Message-ID: <20260704083031.8524-3-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260704083031.8524-1-vidhu.linux@gmail.com> References: <20260704083031.8524-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipu7_resume() calls pm_runtime_get_sync() before resuming the device. If the runtime PM resume fails, the usage count remains incremented, but the error path returns without dropping the reference. Use pm_runtime_resume_and_get() instead, which balances the usage count on failure and avoids the leak. Keep returning 0 on error, as resume callbacks should not propagate failures to the PM core, matching the behaviour of the ipu6 driver. Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") Signed-off-by: Vidhu Sarwal --- drivers/staging/media/ipu7/ipu7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu7/ipu7.c b/drivers/staging/media/ipu7/ipu7.c index 056af3a07507..48a35bda4237 100644 --- a/drivers/staging/media/ipu7/ipu7.c +++ b/drivers/staging/media/ipu7/ipu7.c @@ -2702,7 +2702,7 @@ static int ipu7_resume(struct device *dev) if (ret) dev_err(dev, "IPC reset protocol failed!\n"); - ret = pm_runtime_get_sync(&isp->psys->auxdev.dev); + ret = pm_runtime_resume_and_get(&isp->psys->auxdev.dev); if (ret < 0) { dev_err(dev, "Failed to get runtime PM\n"); return 0; -- 2.53.0