From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11D92046BA for ; Sat, 4 Jul 2026 15:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783179327; cv=none; b=P0ZoKcYBrrw03VN2Q28DNGb7CM6gGJFUKHStZ2b1PKYH67WaStv+YMPtcYZ1LagXJduK/QK5HadBc3Aceu1Z3Y6C7AnzJhWKrAh0QBdctlVqKRPJAP9q2ufD//exCVd03KjrL8DEDLZTUy7uAJoi7cExOcMnayb5ghxn7bYi+3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783179327; c=relaxed/simple; bh=2fQ9urNSxcklh0phZkHbGfVadyqUTMqX8qpnTPawXYQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HMoiGAsywDmb8qEnbBFfsj/RJXTBhyjjro3O+jLed6d1H24AMM41sNMAjifDpJXtXYr9HitEMUJyo92RKsH0jHlh1Ar9nBXp1ya7DNw//mAmivFOuwRS5ET/Tb2RpWN33E63Y+XsATbiefv2iAIpjUTo/hDdjUz2rDT+rViZH/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ea7EP/Ug; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A+SyJ5+5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ea7EP/Ug"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A+SyJ5+5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783179323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eNL4oD7c4ez8lPpkyBqxMc2/GbTsjJZa+epkmtw6DhY=; b=Ea7EP/UgeMy34+xGrL3EKmJXhUe+gZhGAZWASYF3VMaEAn6MyDk9oxssSigvmvHTxgtx+o t/w4nOTRz5q0pg+P2R+jN98LWRzVWhUYssro0RR91c6pEtcU5PjEWMPSH+F5COH1PJDGBs RyvhU0m8bLbHnPXgkgupERpEQqPxEJM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-bBJVYuqBMpCOtR4KXfgAvw-1; Sat, 04 Jul 2026 11:35:22 -0400 X-MC-Unique: bBJVYuqBMpCOtR4KXfgAvw-1 X-Mimecast-MFC-AGG-ID: bBJVYuqBMpCOtR4KXfgAvw_1783179321 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493c1bc7a70so12652485e9.1 for ; Sat, 04 Jul 2026 08:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783179321; x=1783784121; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eNL4oD7c4ez8lPpkyBqxMc2/GbTsjJZa+epkmtw6DhY=; b=A+SyJ5+5LUOz5fERjWi7cAMMZrOeAbZ6HBdbhsdyFHRhOQQnsRKAWblYliG2baiIY1 WaLaRD+J3PxaUJ+7KIoUsF2biF+8p2QCSGFhpBVnnX8nCN0VWZsmMJ6tw+U377q5Yz1H CiGQ7KBpsE1Nr0ljfUlruPWjfIVyL1ubm5qqbntL7YuHaVUEl4pdw7jgXeF/xwwiRxV3 /dHCHx0GtM3VaoV2gspQq4Rm/sXhECFG5+PjU6Z0+EK2X+I7IteimqBpMAqhXvylqjsb JVDStwGtCADHQdhDM1Wa/g/AFcIK2uxys1Zy+V5dTzY0z4JjuNtbM+iQFgNKJ5oFoMOf aaqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783179321; x=1783784121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eNL4oD7c4ez8lPpkyBqxMc2/GbTsjJZa+epkmtw6DhY=; b=PQoW/t+NU+NxzyfdnoZBcZ45wgSnmBx8dK7PEkitTvWsdc2B5fdPEXM3sLogv6hJ3U NJju1iqsSJqH6FwYu/f6W6UJ40Y84haq1A5yFLnPAyBE6+JogXmLfoi7A2nloYqb+ZsN 5/aOdEv4oCaZlnjQGTC+vqBIL0LwOS1/0XJrEgwzRYtv+m9+ZWxjIMhnw66cCDqZfJ6x VzBdYNTg2/tJshGrxKUMGwAjuH5FiCMXzEw6yPMdMkFlTgXcMJ09fMLk1CPEI1A7ZHSc sTkZpLzokZxkkq2orjxb3+rK/n4n8wLQ93h3f/w1xv7fShQc7INtBbZ8PPCsm3ZYNuIn o3WA== X-Forwarded-Encrypted: i=1; AFNElJ+mqmTE4cm0Qu01re1gb1un/G9qNb3vzNMxvbZgsRqXqvSVW0qhNtAgQiVUuRh8CwDg92u/EEfN4eJpDQs=@vger.kernel.org X-Gm-Message-State: AOJu0YzrCHWB8hNX3UoWMtLwCwlpkvmbkLS3GWijkMtHJ+ck81Z6HDxl dc1+yImTmzdKb++CJVzpiUP5vYo8zAX7w4OPq5BDSmmRI4b/7ysoK4tk3vV2VgYHRBXSniyQLM1 bbxa9DcBQgxrMyuQBhcQVi5PJrxpHfX6seXeSF7P961k7twlxr2RO1AxC0wJOZEG0P3DjlAg4MA == X-Gm-Gg: AfdE7cneXpm2n2YinLxhTmwzBRqpMBSlFrmKnr5uRn1Qtto9xKZ5wlNs37+vxB7qFVt Bg5l990oVmxCfaycomeizU3z6F8aQOGl+zAKr3lEfQVpcsJcgIU4KKT8666TOb/Nm03tvnQGynq 8USr3lf1HnJ/xeNNCVIrKOyL5jBi3hOl1eELoXpv3OrpNd0k8hlxU6XW9jwHh0WVwrEPef5ide3 6X2NySxqVOWfqQj+g5UTxvl4g2HtJvZb/g9+CbjnN5wT+wP/kICP0v+jW0sxAq/UbnFCwXjwkPI ZYX/Lx36vecDFgq5rEdXjGrYyLpQ9SuzypuTG6IOI0fMio+T1bLxS+HsFgqJNOGJfJKd1FV9K7Y yIYJFTZZ1V2Wq04etLNVPxGHhDfMjl/V1CjeNnUo8Hw== X-Received: by 2002:a05:600c:3551:b0:493:9b02:484c with SMTP id 5b1f17b1804b1-493d11f7eb2mr43950775e9.29.1783179321050; Sat, 04 Jul 2026 08:35:21 -0700 (PDT) X-Received: by 2002:a05:600c:3551:b0:493:9b02:484c with SMTP id 5b1f17b1804b1-493d11f7eb2mr43950535e9.29.1783179320694; Sat, 04 Jul 2026 08:35:20 -0700 (PDT) Received: from redhat.com (bzq-79-177-145-168.red.bezeqint.net. [79.177.145.168]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdabda3sm139310675e9.5.2026.07.04.08.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 08:35:20 -0700 (PDT) Date: Sat, 4 Jul 2026 11:35:17 -0400 From: "Michael S. Tsirkin" To: Pengpeng Hou Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa: alibaba: add missing MODULE_DEVICE_TABLE() Message-ID: <20260704113429-mutt-send-email-mst@kernel.org> References: <20260704152732.55338-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260704152732.55338-1-pengpeng@iscas.ac.cn> On Sat, Jul 04, 2026 at 11:27:32PM +0800, Pengpeng Hou wrote: > The driver has a match table for the pci bus wired into its driver > structure, but the table is not exported with MODULE_DEVICE_TABLE(). > > Add the missing MODULE_DEVICE_TABLE() entry so module alias information > is generated for automatic module loading. > > This is a source-level fix. It does not claim dynamic hardware > reproduction; the evidence is the driver-owned match table, its use by > the driver registration structure, and the missing module alias > publication. what does this paragraph mean? > Signed-off-by: Pengpeng Hou > --- > drivers/vdpa/alibaba/eni_vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vdpa/alibaba/eni_vdpa.c b/drivers/vdpa/alibaba/eni_vdpa.c > index e476504db0c8..fd6fdba46094 100644 > --- a/drivers/vdpa/alibaba/eni_vdpa.c > +++ b/drivers/vdpa/alibaba/eni_vdpa.c > @@ -545,6 +545,7 @@ static struct pci_device_id eni_pci_ids[] = { > VIRTIO_ID_NET) }, > { 0 }, > }; > +MODULE_DEVICE_TABLE(pci, eni_pci_ids); > > static struct pci_driver eni_vdpa_driver = { > .name = "alibaba-eni-vdpa", > -- > 2.53.0