From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D3F208D0 for ; Sat, 4 Jul 2026 17:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187644; cv=none; b=LUgkqwVIMuoqIcRZsaiOHzUQSVhQe0FdqiMpYZryoOBoOshgJ/kdyfi/DesUD/dQwLe19sG+Fcc7p6xc3ouAwkld/SV2TCu6tDj+io4DPA06FD4KADHxRNifdQfnnoaMQLJ7IdmFJlkbVEnaPIMwGzrp/hMNd3nlhd/sgQBOzZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187644; c=relaxed/simple; bh=Z9N6pEsigWAk2UWIWHJBzftcZEwVRuN0TCZwIeyDEcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T3q9cSTLBMt8g1dZDnYHRMEzrXwv9X8sPKLIi00mUMOsYFZygMYBqH858o7HIdiGZckbtWJI6KVm83SreDoYSnWmOwqjy6Omu937MFfkcmjg7CbZYJx4FNDwAxFAUtbnaWmhtIjLAFckoEH3pNIjPdVUzzIYKS2wvmdmE/bDAls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mskwjMrL; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mskwjMrL" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso778969a91.3 for ; Sat, 04 Jul 2026 10:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783187643; x=1783792443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1BtSYlQaJpsM/z+8viYvtsDhnMR5+tk/oB714i1BVbU=; b=mskwjMrLePnHjiFK6ADgVOxM8F+UMdGCSlfwCB62u1OOF+NxJmoh8hJluwGZGXkDnZ uApmlaPnNmiuluxaNZXg1AesEX4IGf5o26v67edgNmeA830Tz74AE7XS3KkH3fpF3pRs wSblRu0HmTC4OEe0QekgJOkrKkku8HlHMhVFIJmBJVPJAWlprrtcZb/1meozVL3UCM80 dA7Ak4Jx7ql0BnQbv9uUsoh6ae4Kfmdglk70d/ajITGhT7Z7G4KOexWtiXO1ScIqpjD3 YzNFRCwincScoQJs64b03379crBsWT4EA8ddhudHqrSZCiQs/VLqvG6Soj9V70cUWpe8 SPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783187643; x=1783792443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1BtSYlQaJpsM/z+8viYvtsDhnMR5+tk/oB714i1BVbU=; b=dP1QE9yZXjTpMqp+dVhHDwPBNdDH7vM92Mpci6IRmf0fPLWFgIoP/PDCYHstyDYvnh DrBpPLZT+Cans0bAxuPCF3XS5WjFe5AUPVDTZG5SMx3EpFlI5fj/nOJf6xj8AetBMdTQ 157E9yeJHWE0QxT8COmn49XGXGzdtcXaz7p+aCRVeiCPu2k5N5py4YktWlSCKgVe9kYm SEpJZC7lUgVIX2Q8CLN6zwk3JEA9HKHjZJwOxsfmqdEzAc0hLTVZyvpF/9UBKsCflX5G 4sINffbwIdkPCShX5M7PD2Ks0B7n/thj9o38901Nqk5RVzIOxesjETMAZhcH7RjEoMwV 4VEQ== X-Forwarded-Encrypted: i=1; AHgh+RqzD86NMsbEKk70XI0qWR5PQzh/At0/KnfAJtyJ6FSx5k9t3hfSUsEFpnRq+eEU2boA9+iWpW0s4P3/T08=@vger.kernel.org X-Gm-Message-State: AOJu0YxkyjHqUTVQi++25INGvJD0lcl0GN/nV2Y2RPOms7U/Senv7Rcv 5FatlcP2/4IhBSSg+TL9yIyIbIseVHdKp/VbTl91ISPUUmKONfPFPgZu X-Gm-Gg: AfdE7cksbZGTxK/Hf+EUOrZ53stbavjTABKcI3iBOZhw2FXJjFOXoqQ4iS5I7PHrlE7 uOTNa0rN1UM5tq+9iqPUvXD/iDLogbTsD3x8RHLHBMg0eBWhme5dzCkODha3F4EV1hqgIjU11Z4 6NvDAHFY7vHnJArgqPiMEwqfa0Bj80kiWB5IHkEx+K9DzUdvXGAucmMGRjANnaqqW/g2PNlh37X KbfVQR276D8/YhiXb5xhGHbvgJsG/bouzCds+eFazc+yclccHPpiv0TyHMB1GRr6bqxJEjcEGAf imEmECtuauo7L+5aBA4ymFyyrnRc9kg8TtLifdvDX2dcE/MXqs7qNFUbwZ3Q0hVhaB5DzNxNQIO m2Ek7hot5CAiiF3cDrBylnvIoklFSZNono4TZD2udTneRk+Roz6qZ6NhrcTWqBOnTckZ7ohXFZ2 fRdTxipRIjgOyAZ/dfeUrogvsp3i2y+vmazlzJJeXZJFg= X-Received: by 2002:a17:90b:2d07:b0:366:132:fda7 with SMTP id 98e67ed59e1d1-382808b2089mr4165513a91.10.1783187642936; Sat, 04 Jul 2026 10:54:02 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f39e07e0bsm15588749eec.30.2026.07.04.10.53.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 10:54:02 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, Biren Pandya Subject: [PATCH v3 3/4] media: renesas: rcar-core: Add missing media_entity_cleanup() Date: Sat, 4 Jul 2026 23:16:42 +0530 Message-ID: <20260704174638.66302-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260704174638.66302-6-birenpandya@gmail.com> References: <20260704174638.66302-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe error path and the remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op in most cases, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() calls. Furthermore, introduce a dedicated err_entity label in the probe error path to ensure the cleanup is only invoked if media_entity_pads_init() has successfully completed. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c index c8d564aa1eba..5bae8eb0ee19 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c @@ -1211,7 +1211,7 @@ static int rcar_vin_probe(struct platform_device *pdev) ret = rvin_create_controls(vin); if (ret < 0) - goto err_id; + goto err_entity; switch (vin->info->model) { case RCAR_GEN3: @@ -1246,6 +1246,8 @@ static int rcar_vin_probe(struct platform_device *pdev) err_ctrl: rvin_free_controls(vin); +err_entity: + media_entity_cleanup(&vin->vdev.entity); err_id: rvin_id_put(vin); err_dma: @@ -1270,6 +1272,7 @@ static void rcar_vin_remove(struct platform_device *pdev) rvin_group_put(vin); rvin_free_controls(vin); + media_entity_cleanup(&vin->vdev.entity); rvin_id_put(vin); -- 2.50.1 (Apple Git-155)