From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA59433E7F for ; Sun, 5 Jul 2026 01:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783215105; cv=none; b=czndbnKK3NidW3qleohETKdVrmMUkZjJKqBPVbYpXLaW80b01xH/E9zW5gtv/VgE5D3eYmwK0IPrQ3KOKO/MKHVjAK3qh12eG2pGFVI+admOkFHtyaN1VXD/THYGZeYhtPs14bUXHQGewb1FFRW/ha568qSRJgfXVLdB6GE9aYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783215105; c=relaxed/simple; bh=br6op5jkci5EbK3N050DcaPtSQhX/bz4GhhVOcopjYw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=WaPIW5k0XnKKseiHUxVDszabANxc2WrxjxCdJt4y27fD6WWcbUCuQE9/EYlfHzqTdMEmu5wpDrm+fcIywM7JDiH7+m+snjTK0W62EjyuvFCRLG5p7t+GNSUMpLqC5aFfbxkLAyw3tNGYDJxqP5w7xuJadcMjNK58Zettg3qS1hI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=V5Xw/l5g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="V5Xw/l5g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC4331F000E9; Sun, 5 Jul 2026 01:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1783215103; bh=EHtF6h9gaVNf3CA52e458glPtDGJQnWrkUX2Zs49eIw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=V5Xw/l5gLPByGFI1MUXJOXOIFaXxjjlNAIxOcHZVYCEUSjznSVkh+7mt5bqIq22BT +Q7LnihUoVbXWY+IcBQ0zOsQE63esJmWwg3t5Ffgq2QQn1cLWHf4x01qIEA2ROA6Jw M2/l8CnOmjg4G8Vkn1v43UFFVVjmqyfkn7DGj2FY= Date: Sat, 4 Jul 2026 18:31:42 -0700 From: Andrew Morton To: Usama Arif Cc: david@kernel.org, chrisl@kernel.org, kasong@tencent.com, ljs@kernel.org, ziy@nvidia.com, linux-mm@kvack.org, ying.huang@linux.alibaba.com, Baoquan He , willy@infradead.org, youngjun.park@lge.com, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, alex@ghiti.fr, kas@kernel.org, baohua@kernel.org, dev.jain@arm.com, baolin.wang@linux.alibaba.com, npache@redhat.com, "Liam R . Howlett" , ryan.roberts@arm.com, Vlastimil Babka , lance.yang@linux.dev, linux-kernel@vger.kernel.org, nphamcs@gmail.com, shikemeng@huaweicloud.com, kernel-team@meta.com Subject: Re: [PATCH 0/6] mm: preparatory patches for PMD level swap entries Message-Id: <20260704183142.240ad7323db51d64a98c8e0e@linux-foundation.org> In-Reply-To: <20260703174832.55655-1-usama.arif@linux.dev> References: <20260630164143.1595669-1-usama.arif@linux.dev> <20260703174832.55655-1-usama.arif@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 Jul 2026 10:48:31 -0700 Usama Arif wrote: > On Tue, 30 Jun 2026 09:34:37 -0700 Usama Arif wrote: > > > This is the preparatory part of the PMD page table swapin work. The > > full PMD swap entry series has been split into two parts: > > > > 1. this preparatory series, which contains the first 6 patches. Zi [1] > > and Lance [2] suggested to separate this out from the core series. > > 2. the PMD swap entry core series, which depends on this one. I will > > send this once the preparatory series is merged in mm-new as v3 > > as the combined is currently at v2 [1]. > > I have not marked this prep series as v3, as its not really adding > > support for PMD swap entries. > > > > This series does not introduce PMD swap entries and does not install any > > new page-table entry type. It only cleans up existing PMD softleaf > > helpers and call sites so the follow-up PMD swap entry series can be > > smaller and easier to review. > > > > Hi Andrew, > > The series only needs 2 small changes: > > Removing a comment: > https://lore.kernel.org/all/157838aa-1518-46b5-8734-feab2c42ee2a@kernel.org/ > > and s/CONFIG_ARCH_SUPPORTS_PMD/CONFIG_ARCH_HAS_PMD_SOFTLEAVES/ > in the last patch: > https://lore.kernel.org/all/e37df165-8de0-4924-ba19-0d43a6b7d36e@kernel.org/ > > I am always torn between sending a fixlet on the existing series or a > new revision. > Just wanted to check what is easiest for you and your preference > in situations like above? Oh boy. Historically my preference was for little fixups - so I and every one else could see what changed. Mainly to avoid invalidating prior review efforts. It's comforting to have the thing stabilized, unaltered and to see the little fixies getting smaller and less frequent. But this process tended to make people's heads spin - mainly, I suspect, those who hadn't reviewed the earlier versions! So nowadays if I receive a wholesale replacement I handle all this by dropping v6, adding v7 then replying with a heres-what-you-changed diff. For the earlier reviewers and for author to double-check that they really meant to do that. I have yet to receive feedback about this, of either polarity. In this particular case, whatever you prefer. If it's to be a full replacement, please do include the v0->v1 summary below the --- separator.