From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7303279DC9 for ; Sat, 4 Jul 2026 20:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783196199; cv=none; b=hHx7SJWboWxgmNpNj6uzEd4wCLuGK4xrQOz5lYvv/vJWAkrHO0HaqgNnEucGPpbhgsX0H4I2IrPotABCSRJudcs4IZ3cdcaOC4EJ1nBMrTHb+SZlg9lhZopXlvrf2stkbR5Cd/QuR27FERnQTGicsEccf1aT59WPWQ8vJEqiw/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783196199; c=relaxed/simple; bh=tXOHWGUH+mLAhY12WSftjABbkjXUBFUyZ5r3XxC3FTI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RyZK1ojGG8zLdnLvM2LblYQlPux6ozRP3lHrwOMqbm66Kb0DhHPbl8m5CXlxpgvBI115sLMkQTICyhRX/WjyM2CaGtrNVYVcnCkymqCDTNnJMvyYZuxlVYPvGLolKoB04cqnh9zUpg8gV7Hp3hG8NnGzH2KAV0szUuCurnNxe1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JnFPCq1l; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JnFPCq1l" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3825c406ffeso831120a91.0 for ; Sat, 04 Jul 2026 13:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783196196; x=1783800996; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WB0PsRduN1OR6vgNnQ1H3urBvpeTtKBzrk/FhBQnt7c=; b=JnFPCq1lFG4EWozQv9aC6oyAzWNiZyJZvZ4r8aFBhanYXlG09SjRaTc9Sg5EPDvFQn CZn1w3vIAEMEn7wg++sxIi5kFaEp29CyNAXx3Bok29KCYahhTZZLMr77WPzkAVgzs2P9 Lj8RpIWBTCLYM537FMu2G/mRGfQsF8qIpWOOC1BD8UVLPxUlGkt4KXuPfvjNwH7vswXi 52EGwvBBXPyXhv7OB10gBv628foaXaxR+jiqCeRveYP297l79m6L7iD+B22+gE0HPr5c VKq+l+gc58mFtGEQ0a0oWEyn2Gbj3OHxQzcomxPZ+y+9rHL+WUwZIjRhLIX2PrGFBW6k eCKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783196196; x=1783800996; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WB0PsRduN1OR6vgNnQ1H3urBvpeTtKBzrk/FhBQnt7c=; b=CYy4gfpaDoCy+cy+dA8MAFkHU5wVyTq6NclE2CPf25HrQHaNlkE1q+cJjAf24eLclm fZv405cBIiF8cFhYh6U1WGuxkENA3QEAhbjG44WIKB/I65gFa4Euyevf0BGoIjVN597H mgyoNrRaUZzaR7XYI5dxV34u5NNUdA4hmJw1ytjWNJAgHKDHriIhpAn5aLJ+69Sd6OX1 GgIohq246USultiFLWuCnEQ4mS1+2u9GVRR+8MpJzpqrv0EGB/rye9ajsJFxk0e8kTRC gfbbnNugxPZc70ECy5Wru6d6awo6ypWESN0w0RdmbKnOAtWBAaASNs1sryeLYtnS0XOp 3NbA== X-Forwarded-Encrypted: i=1; AHgh+RpUA3fbeEGElNMPkIfY0/IpTJ+TLONeQOq709YkoRtkfUPjWZ+ifdARCq6VfFYuZh0NHLLGuH9+qKKQLZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyWc4MPB5DCgonBk00QiSH+xfAX/H86dtmbaQohI8kr3/sEGI8O dOnre0DHpds6zEGlvm2Ih8w+wIJo8Hk7NyaSZAPNkjX+E4abalGz5EOM X-Gm-Gg: AfdE7cmCpvP/dcg3PbE4+zRF5GbTVUW/vTGIfVh05lzBfHdu1kVgZFDpEMfQ+g9erK7 w1gL8RLPRopgMexKoJ45Y1Ub+oVHssIUbdvoBIQnqpvVH5ipW7xLOoz6oJ9xNvAUPH4WTDDKKH6 T7mqpypqvcPUtEgJqHFVYe2oZy1L1JPqq01nO3/v35aruBtAHEaRpVH8IaeyQHNFQefiG9IdT/9 quuGoJc2xSpl43hmhTr00SUiTWtZu5sMdPEUf6MzY6c++61KqnB6uchLL2h2N6v2wSM72u5t9d+ mcGQfh6RwK1w/0EraHvPv1GlRlZc6ux2B2RmKlpSYGrWLxbvjb8SAGKMoEXLPtmJI6m+9Z8CQ5f q3eZACostqpLouhpLYPvdU/MSYjodBEsZsYI0QzGRBXXYRfrcIq7SdAE+XCMY3RCRCbo2/GETw8 5mR0EEhqi93Dz274nL/p66YzNam7KaIGahcfQpagFlnafd4K2sr/lDEQ== X-Received: by 2002:a17:90b:510b:b0:36d:66d4:270e with SMTP id 98e67ed59e1d1-382803bbc43mr4429700a91.5.1783196196135; Sat, 04 Jul 2026 13:16:36 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb7fe46sm40571560eec.14.2026.07.04.13.16.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 13:16:35 -0700 (PDT) From: Biren Pandya To: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v2] media: i2c: rdacm21: Fix missing media_entity_cleanup() Date: Sun, 5 Jul 2026 01:46:28 +0530 Message-ID: <20260704201627.82584-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver misses calling media_entity_cleanup() on the probe error path and during remove, leaking resources if probe fails after entity initialization or when the driver is unloaded. Fix this by adding media_entity_cleanup() to the rdacm21_probe() error handling path and to rdacm21_remove(). Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") Signed-off-by: Biren Pandya --- Changes in v2: - Fixed a bug in v1's probe error handling where media_entity_cleanup() could be called on an uninitialized entity. - Added Signed-off-by tag which was missing in v1. drivers/media/i2c/rdacm21.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index bcab462708c70..ece8a410e7ced 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -588,10 +588,12 @@ static int rdacm21_probe(struct i2c_client *client) ret = v4l2_async_register_subdev(&dev->sd); if (ret) - goto error_free_ctrls; + goto error_entity_cleanup; return 0; +error_entity_cleanup: + media_entity_cleanup(&dev->sd.entity); error_free_ctrls: v4l2_ctrl_handler_free(&dev->ctrls); error: @@ -606,6 +608,7 @@ static void rdacm21_remove(struct i2c_client *client) v4l2_async_unregister_subdev(&dev->sd); v4l2_ctrl_handler_free(&dev->ctrls); + media_entity_cleanup(&dev->sd.entity); i2c_unregister_device(dev->isp); } -- 2.50.1 (Apple Git-155)