From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28F665192 for ; Sun, 5 Jul 2026 01:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783216642; cv=none; b=CUuY+XvkVj2h+C5tsu/uF/L3L7pgT1epn7MNTJNbSYF72ldETM9X4KroGqT2XJkxFxJ2+1a8YwsGizhR/t+2KFTENaCxVZVWhFGSSx+T/u1xHk7z/h+XuLtPcJo9VUtwusSQhbL5Q/1+g8QRSA+xReIyrSI7pAk9Eet9D/Kc9iA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783216642; c=relaxed/simple; bh=Uc1UeSgXcLQisE331Fx/w4AxESxEfcZ/fW5sTxYv6NE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NDwOOdG9vj8edR3QS60atsen78hwlJrBYSo8/XWZo2kCKjGi1q+74R//M/Oa0qNhzTvjk9kzcVicbhtQyS3QE7/wu3GiCCg8irFmRqN+n/jV8iBqByMl+BqRnCHPBduPSxytoFi2oZUB8z1ka79ycMKl+SknHmVfmlw31ftNrN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H3oOCAHr; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H3oOCAHr" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-44d069e5c20so1297341fac.1 for ; Sat, 04 Jul 2026 18:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783216640; x=1783821440; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=g8dZZ0ezVRB2v/8tDo+4cmpTy+MFf1s9r33Lw4vpQWw=; b=H3oOCAHrySC2Fm01dzULXMt2eDdGPgfwTLrACNGpiCu2gUByxo9N4spJqLyDY4IKQf TYIoliWnbD1u3myJ4G6vUYBk3hr5P1c7koz2I4FO4Ut/d2qRuOr14vKZM441PQO1Y6wZ iRHnJrvrvNaS766bROy+KU9qYdT5nr7WOeOBL6kLLT0B4vfZ3sdRIelSXLFX2iA8TWNd mBAQB5LMnJZto7XWroghP0ZJ7RYMJHgl7/aiewv7Izdkv11W0xC5HGaFTq03ZyfLP3z/ 8DM/IdiR5m5TmqBCLs1ZtI9rhYudzdDnzsxodrK91IL9Wxjg4mdDStSDXSgB1jIRkul4 X/CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783216640; x=1783821440; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g8dZZ0ezVRB2v/8tDo+4cmpTy+MFf1s9r33Lw4vpQWw=; b=nvtFVT7npdUNRa/EuFN48wjHF4ZuQA2bxTVoa3xsuRLg1UTjenDzE2HcolQHxMplA1 to3c2ks0ekUBRQTgFjQjZ+ENY+RVLesn4GMfu61JHhM2UYpq0gHFjpWY/0/MnDSqSlbL 9xZ4Pz8i7XAw9zb32gJ2sIsE3AFdE+seZqn8IvQDM9ja9vNDU05CwxgAiHox13vZ06kx ycdhePwNPw+z9+rQID4wJynxhoj3U2hLgLYvAxKdF9TEx0pPma7ohK8+c0CJH4Mib6Yx h2GIZaqhMWLK+pmx4FiBqqfrRmwqG4ogfhO+99xYXWY4DTStvmldIOESySrSy9lB3NhD V/PA== X-Forwarded-Encrypted: i=1; AFNElJ/5tCXyHCUw/kswH0031095z4p3l5pGVVbqhGKZ7Ppsz81Ko4iwXgkfT348w68aJFeUE4Ve7nbOpdr4YRI=@vger.kernel.org X-Gm-Message-State: AOJu0YzVuTo3ALALaV7lMNkq6kPaFRtiS4NqxdksK+LVhK4HAxS4oN3o a3eaJhGN3x/0RGg1KfvNhGwS2cyPL84uHXOs+mVlQw60CHdWeoxOsGmvXvp+VG7+ X-Gm-Gg: AfdE7ck4dagB+46KOZUKGCg2lZBbhxRw+/mVOSDMKnuRbAudbcWOpTXOzSk3CLxZ2jt VcHUydQaHPzV+t8wawcILJzF9SRMo5vnNs/4E/HV/UCAbrhZxo55VcUny7Wqoj86/dqbzWyVphF 2NHIv8fAyXKCfa1vD6NmqHZThgIxd43hLzhW2sRKgisSZHFAN4zsyOLMXaFJt8iHOKqrwKTcXXx oEAZ9h9RUN4W56AcpFegrJv2cT+cTuKkyh7Xo12xgk7ohesgeuXdFOIlwDYB8PLXQb9dfpouEjC knJPVJ+20uGsLM7lY3ZxgZSYBHHBfXhds7lRHELgE1dTJK/VJXCrTSWi9bk6J9N/mXUqFCNsxKP FznzgqNiLy5CmJYm28JLzvO9mrNXotRYdrGk1d4GuKr0WAvXM6yn5XkhZWqytNARAVGbYTk7A+e i6cUxrl8oaCINVu541lQBVeqvvF5jJVD8NqnUYJkqcNkzcbWG/KPxL X-Received: by 2002:a05:6870:8a29:b0:448:5591:15d8 with SMTP id 586e51a60fabf-44d18442248mr2902707fac.36.1783216639884; Sat, 04 Jul 2026 18:57:19 -0700 (PDT) Received: from linuxescape (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-44cfb1d011asm6467451fac.8.2026.07.04.18.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 18:57:19 -0700 (PDT) Date: Sat, 4 Jul 2026 20:57:17 -0500 From: Maxwell Doose To: Jonathan Cameron Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver Message-ID: <20260704205717.137c506e@linuxescape> In-Reply-To: <20260705000053.6e8fc3f0@jic23-huawei> References: <20260621004626.66629-1-m32285159@gmail.com> <20260621004626.66629-3-m32285159@gmail.com> <20260703010532.4fc0f46b@jic23-huawei> <20260704144503.2347331b@linuxescape> <20260705000053.6e8fc3f0@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 5 Jul 2026 00:00:53 +0100 Jonathan Cameron wrote: > On Sat, 4 Jul 2026 14:45:03 -0500 > Maxwell Doose wrote: > > > Hi Jonathan, > > > > On Fri, 3 Jul 2026 01:05:32 +0100 > > Jonathan Cameron wrote: > > > > > On Sat, 20 Jun 2026 19:46:24 -0500 > > > Maxwell Doose wrote: > > > > > > > Add a driver for the Sensirion STS30 family of temperature sensor > > > > drivers over I2C. The STS30 family of sensors includes the STS30, STS31, > > > > and STS35, all of which are supported by this driver, since they all > > > > share the same commands, etc. and only differ in accuracy and tolerance. > > > > > > > > The driver currently supports single-shot non-clock stretched readings, > > > > by using a specified delay based on the repeatability/delay specified > > > > by the user. The repeatability/delay can be changed at any time through > > > > sysfs. > > > > > > > > Additionally add Kconfig and Makefile entries for the driver as well as > > > > a MAINTAINERS entry. > > > > > > > > Signed-off-by: Maxwell Doose > > > > > > Big question first. Why IIO? These are fairly basic temperature sensors > > > which typically means hwmon is more appropriate. What does it need > > > that hwmon doesn't provide? > > > > > > > The datasheet says that the STS30 supports continuous reads which means > > that we can read it into a triggered buffer (which hwmon doesn't > > support) and at some point I'd like to implement that. > > Hmm. For a temperature chip that is often more about the monitors running > continuously than the ability to gather signals fast. Temperature changes > tend to be fairly slow when it's a physical sensor - gets less obvious when > infrared remote sensors are involved. > > Even more relevant - there is an existing driver I think. > See drivers/hwmon/sht3x.c which supports things under the wildcard sts3x as well. > Check if that covers this part. > I think the last time I checked the sts30 series wasn't listed in the dt-bindings but it may have changed since then. Oh well. I'll still go check it out. If it's (very very) similar I would probably consider dropping this one, otherwise I'll improve this one and resubmit once I get the hardware. -- best regards, max