From: Greg KH <gregkh@linuxfoundation.org>
To: adi25charis@gmail.com
Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: bootrom: power off module on timeout
Date: Sat, 4 Jul 2026 09:34:47 +0200 [thread overview]
Message-ID: <2026070430-exclude-improve-f318@gregkh> (raw)
In-Reply-To: <20260704071926.6606-1-adi25charis@gmail.com>
On Sat, Jul 04, 2026 at 12:49:26PM +0530, adi25charis@gmail.com wrote:
> From: Aditya Chari S <adi25charis@gmail.com>
>
> Previously, when a firmware size request, get firmware request, or
> ready-to-boot request from a module timed out, the driver would log
> an error and free any firmware buffer, but left the module powered
> on in a potentially inconsistent state.
>
> Fix this by ejecting the module's interface via the SVC when a
> timeout occurs, forcing it to be power-cycled and re-detected rather
> than left in limbo.
>
> Signed-off-by: Aditya Chari S <adi25charis@gmail.com>
> ---
> drivers/staging/greybus/bootrom.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Cool, but how was this tested? What hardware needs this?
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-04 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 7:19 [PATCH] staging: greybus: bootrom: power off module on timeout adi25charis
2026-07-04 7:34 ` Greg KH [this message]
2026-07-04 11:53 ` adi25charis
2026-07-04 14:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070430-exclude-improve-f318@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adi25charis@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox