From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CA83655C0 for ; Sun, 5 Jul 2026 08:35:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783240541; cv=none; b=hkVOI5yNRqG8wrbbOQyloqOiTmSxTtfRBvi6lC5DPglEIEuGojWpf9KMqbwbV2nW+dneFNp0VMg+uGE8hf9k9YqczAXfW05GLtNaVd/oyda19iGYM8IRfg6Y5vOESFb98WYM3EJLvMfn0kLsvHiXiciPS57kYD/EgHk/daAdSQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783240541; c=relaxed/simple; bh=8zu1GQKDq5ZrShEYTtokpdtb1cdZbJOpkDs6mpvam0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G72A+ihT4kIq2hl24bF7P/qJFkC+ZR8Hg6/TWDa6gLDkOKWXUHkWg+jL67Doyk/U9zoI0gA+acKp90M5va5nRAOQTH/3S7MvfsK2IJu3XGuFcVaCFCNIH6x5lJIqgixJQQq3Wsyt38q6is7Q76NyaioU2wXo4afhNMHxk1bSffY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f/xrMq4q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nbQYW/ZX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f/xrMq4q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nbQYW/ZX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783240538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dFQDBZsIuu7dJK0KUEdBQ3FE5XnU6Bp1zoNA3OFVPPc=; b=f/xrMq4q/uxk4t+cAshvkqMW/IeU1n/2oEOrqZgdKWh6X1LfSMMHJILa09uQjiGAge+9tL VsqDbhm2+papshg1hBGGSHWduUth7zX/YnKEiBMiCIR7rZdnyB9Z/bBrXyyYOGt0ymDnqK NpJ/pGBbzQtoE4VQ546O6ShYwjsctuI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-xYYFMi5LOdC5barh66DR2Q-1; Sun, 05 Jul 2026 04:35:37 -0400 X-MC-Unique: xYYFMi5LOdC5barh66DR2Q-1 X-Mimecast-MFC-AGG-ID: xYYFMi5LOdC5barh66DR2Q_1783240536 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-47780faf8cfso1244767f8f.3 for ; Sun, 05 Jul 2026 01:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783240536; x=1783845336; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dFQDBZsIuu7dJK0KUEdBQ3FE5XnU6Bp1zoNA3OFVPPc=; b=nbQYW/ZXdU2elYTok94styL6hHvXVb7h8bKIaP68dETgnrvjFit/lPQNym7E4DvgRy /5AzLrNozvdVYKAZz7UPYccqsaeSLUI01FjxzU5fB6uKhkT0OalYgS4NbnRdemhb7dKD m3hwphbV4bm91SCujHplFnoFBrukJ5iVddKwXiyvrF3DEf56V3bNu7k5D9eZPVujYNLB fyPUQ03v+3mPWlb6RT2uGT+FnruM9j7s6wZfHkeUXdqr/YZNZNqDDlYh1MyMLSQ5F+wP EtHeg4kD16HcnZGlQsZsjxbRgs71OgHMWGk9yQZG5ceTxHffGQfhWxHN46D2IQTEInGq 8cpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783240536; x=1783845336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dFQDBZsIuu7dJK0KUEdBQ3FE5XnU6Bp1zoNA3OFVPPc=; b=MDB92lSwk/oGyWCAQ5i62LTrmZC7yCv62w1YqGHrvoc9JYF7krNRSm+w9HkIDhRHL+ PAf+CtRWzsHS0oHRyjR+artEcFpih0A2lxEmnLGpxRiWt5o+/bee7UT1D/owQCbWxxkY 7g25DbqCOX9J+D4OKKIoVWMKak7xhjTJ7EBsILTXvqUqNE6Nev/RQh/QK6ZUju1SUzN8 vUTiHE2r+YtgJlR0SLAFnEkWIGoJc6uE17Zsu3WE2edg6gqRUbKpX/FMiU634EAAaCz2 XzVP3cyve0Vb+Yf2EWrcgypH9Lb4I86CY3tRQYPToARWUWOS/D1F4+ng+uF69814HPuK t29g== X-Forwarded-Encrypted: i=1; AHgh+Rr1+HGec2QWB2sAlgUlf6T7d4aueAGHi775MfCz0dnKRVtFA6DTrBe3NBTUrtLUC2UF7AqmdblG5qjNUNU=@vger.kernel.org X-Gm-Message-State: AOJu0YyAVzJBG1Z3vtns0uJtYs9vTWzVkUkSMlJblDXPL8PCrOQSk66L p/4BODmXgpqGteUZHe6OsyhZnpGeACtr6NIM8ltJCegxwTxu35SLy0T9kYTuH6PiQ/6xlBSo8jH XylB/4oYHZtfeG/pyno4M8s8dn/e3Pu1goSrrbQR6TKfdfVs0ZNqg/9wtjMpc5yD1bw== X-Gm-Gg: AfdE7cnp2QM6+pcf0Xo+dv0grymIyPnYDXi8cjUf/ZVP8XZ1tmh9ZN5zUmnyYqWQBIU NGwHGr/VILRT9AHKMSXYJs7yeu6vVhr6LR6SUdG6tU29JNCGrmCqVUUeCCQbfDIdNJCut4ymfM4 f6MOKFxyadpPbyfW7jMBoSJfPoqPg430+kePnXbs3ODpE+LcH+Jsinx/BDfft729A2AmoSCN00G 22A9+tgRXQJ/V+CPOYmoz1njQ3KfxRUUPlNo2PGv8n9F+f3KYpYGQ5sMZehs944tBghEHFu0AFv XHEss5vSQNTONS+feOenZrVOK64k/zpcUnBcGTYPDxoL0RhA7ORc1QmrDEMiiGxxTDfP7q96suO EOMW4dhe7R5SF3GE3PzNz+FcPbhhu5Nyr X-Received: by 2002:a5d:5d83:0:b0:474:13ac:a91b with SMTP id ffacd0b85a97d-47aabe3096emr6401642f8f.32.1783240536187; Sun, 05 Jul 2026 01:35:36 -0700 (PDT) X-Received: by 2002:a5d:5d83:0:b0:474:13ac:a91b with SMTP id ffacd0b85a97d-47aabe3096emr6401613f8f.32.1783240535738; Sun, 05 Jul 2026 01:35:35 -0700 (PDT) Received: from redhat.com (IGLD-80-230-68-31.inter.net.il. [80.230.68.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a558easm14222697f8f.27.2026.07.05.01.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 01:35:35 -0700 (PDT) Date: Sun, 5 Jul 2026 04:35:32 -0400 From: "Michael S. Tsirkin" To: Pengpeng Hou Cc: schalla@marvell.com, vattunuru@marvell.com, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa: octeon_ep: add missing MODULE_DEVICE_TABLE() Message-ID: <20260705043510-mutt-send-email-mst@kernel.org> References: <20260705002546.85004-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705002546.85004-1-pengpeng@iscas.ac.cn> On Sun, Jul 05, 2026 at 08:25:46AM +0800, Pengpeng Hou wrote: > The driver has a match table for the pci bus wired into its driver > structure, but the table is not exported with MODULE_DEVICE_TABLE(). > > Add the missing MODULE_DEVICE_TABLE() entry so module alias information > is generated for automatic module loading. > > This is a source-level fix. It does not claim dynamic hardware > reproduction; the evidence is the driver-owned match table, its use by > the driver registration structure, and the missing module alias > publication. what does this paragraph mean? > Signed-off-by: Pengpeng Hou > --- > drivers/vdpa/octeon_ep/octep_vdpa_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c b/drivers/vdpa/octeon_ep/octep_vdpa_main.c > index 31a02e7fd7f2..9bedcd81a174 100644 > --- a/drivers/vdpa/octeon_ep/octep_vdpa_main.c > +++ b/drivers/vdpa/octeon_ep/octep_vdpa_main.c > @@ -884,6 +884,7 @@ static struct pci_device_id octep_pci_vdpa_map[] = { > { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_VDPA_DEVID_CN103K_VF) }, > { 0 }, > }; > +MODULE_DEVICE_TABLE(pci, octep_pci_vdpa_map); > > static struct pci_driver octep_pci_vdpa = { > .name = OCTEP_VDPA_DRIVER_NAME, > -- > 2.53.0