From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616D23033E6 for ; Sun, 5 Jul 2026 09:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783242201; cv=none; b=FyViOj+9mUUQ0RatEZviBAq7o/5COitF2pzK/B2RYQHSbA2LOOPYMulZKHid+K5gZPF6xiu12qDAWS91nSqM1auhYzNuG0ICQStzHFoQHZl8B9uu3JrPEUf48nb1pBovgiqvGAphJYC3tkBpyQDX6uKa9eGSZRqltJbEUfEVfI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783242201; c=relaxed/simple; bh=brbV8/1DPwfsgqRed2mZmbC3fwIJoy2L9mJnekMiAyY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FLoQisZVG2e0ccox8dwxT8bgEPXcQGK97H8UZDf+55Om716qeZB3UU0uObWEcztcvu2b3EI+ULzuzf4TzSn48sG04ErM+axTllfpuN0eZ1RfoLMz8homViidor+8FY3Q4QV5yyCkQ91P6KekmAT+hiKhjbpBSBUsbGNVkBMPQOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aZUcgZyJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=o/PmlE72; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aZUcgZyJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="o/PmlE72" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783242199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yx1i8H1guo8skt2UVrwpIqA49iMJYRdNcjVq3Vf0DQU=; b=aZUcgZyJxIogRvxzR/TfbhqXPD5WYsScmQoF+ufnqM+ZUW6JKtycrwYgSCu30hKxhoi5xF /DiPFgnqr9w94QWYg/KpiU3g1Y3JAp3b6hZVBP6vxEHU9QudNYmKnzflgIB10g1d2chZa7 5v/pimNk22ik5RO4Lqn9STAs/2vzQVE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-gRe1l-JYNiiF19dW2YG6dQ-1; Sun, 05 Jul 2026 05:03:18 -0400 X-MC-Unique: gRe1l-JYNiiF19dW2YG6dQ-1 X-Mimecast-MFC-AGG-ID: gRe1l-JYNiiF19dW2YG6dQ_1783242197 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-472c330e555so836548f8f.1 for ; Sun, 05 Jul 2026 02:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783242197; x=1783846997; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Yx1i8H1guo8skt2UVrwpIqA49iMJYRdNcjVq3Vf0DQU=; b=o/PmlE72dDeTPb0Ln/UnULzJ1XtpCs0U2b935Pi80W+IgMiB5DofJo9K8Wh38dkgsC edrOJ8a3GiTyVE+QugOhUzr9brPUwEGUJVGnCS0kQmQ3oc8DX4LrNa21yQqsUm7FY0kP xmXRnkP7ixUqs3zdr1qprQfLft9aOulYQKWzIK/p1CWYhDNcaBDIIOkLiEfIFQfEPafj iZlvNIMsjCnyQAz/Ft7yCbIBV84S2HL9rKPtWwfpuz2a4Ce5wpEcr4a3DTzoPRPc5vC2 upS3qPEjMMHjQRDlKwljDuGkix7GB7VrLSQBAj22fR7ezmFoiltwbsEvMWK3sKj+BysT 1Alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783242197; x=1783846997; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yx1i8H1guo8skt2UVrwpIqA49iMJYRdNcjVq3Vf0DQU=; b=lVMeJAxdJtf4Hrri5T5TNAQ4fczScHtuQXVA8rUequnFMcukrcsoraGM15N1P5y80G p40nVr2XdUkHYA4fLVs29KI8JBN/7YTqBOjiPu+XkihSr57pfGFolS0zETtwD7ySp8Sb mS72fyMuKf5F5lc3BmCySSuCmMGUxdzUg3xrdTOJDYsv+i/ZQn9GMXU0jKVkh1aazJgZ rwLBo7i8NjKeSCMiJOstR4CjoQ/W1eW+V8fRrWX4Ha/njky1akeuxQHpCAxiJ0bgVkTU lIMsz9t1hAPTPUrmorugm26nzenp11utgN/8GUrrJijY2ShpdZ5z8Bmvqni4bf7xZWDb nrKw== X-Gm-Message-State: AOJu0YyDiUhgyRyZvKdVzR6DlXMY10zt3OUc2JV+qFZQPMLy3ERyPoCu Do2vEmYVxByC8vsBjxRH854n9e+uaaHFtLxYUtJwN/KaR9cdyKbAiSRAI6NaWY7OP0WdYLJaogp lyEpU9xZi8emOoaj8xH2vaz0GsZ3DLQSILLFu7ZHoxGcWPofwXih+t5f58TXwtOMOahAAyRtvFA == X-Gm-Gg: AfdE7cnqjNseoQQhcaDYw2rG8D5rHLTK2xB5+MS6OkL6aizk04sKF3Fiz/KZhHx0pI7 akzVzLZnQPFJAo6nZraY6s4YanPEHdYgDeTyPAUpGeTceA0aynrM8wwEtDzgK1Atkj6apJ9yYZZ LFTzMz5/Wf2i87i0plPeT69qm9M/b97VLujxU+aXZ+r7cbDB4Yzlzo+tQdeCvVskC6INKwlIqWm esppm/MLVTTRYuQP/hoaCWNjPTQLFsMv2dMfWiqQEJese7L/Wld4XMakFxhiTpxpDJRhEh+gNJU oV9XWoWMlW7/nestu3o92JPGPcFWZ7dPyQq8wQBu6IEtd5bwvx6miGMmwe9y3kEviwGyQg/id3i ACxon3BdBU5OiKDGvQRcmg+5+k+FbiNkR X-Received: by 2002:adf:f9c5:0:b0:475:f100:3605 with SMTP id ffacd0b85a97d-47aabe31110mr5574722f8f.52.1783242196750; Sun, 05 Jul 2026 02:03:16 -0700 (PDT) X-Received: by 2002:adf:f9c5:0:b0:475:f100:3605 with SMTP id ffacd0b85a97d-47aabe31110mr5574682f8f.52.1783242196164; Sun, 05 Jul 2026 02:03:16 -0700 (PDT) Received: from redhat.com (IGLD-80-230-68-31.inter.net.il. [80.230.68.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6da9sm14391797f8f.12.2026.07.05.02.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 02:03:15 -0700 (PDT) Date: Sun, 5 Jul 2026 05:03:11 -0400 From: "Michael S. Tsirkin" To: Andrew Morton Cc: linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Gregory Price , Zi Yan , Pankaj Gupta , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Alexander Duyck , virtualization@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: page_reporting: allow driver to set batch capacity Message-ID: <20260705045807-mutt-send-email-mst@kernel.org> References: <444c24cf39f3f3620fc90ef4695bd6b0979f4c4b.1783232420.git.mst@redhat.com> <20260705011635.9974cac7f0defec9961e85c4@linux-foundation.org> <20260705042313-mutt-send-email-mst@kernel.org> <20260705013956.36f649b5cb13409d9088838a@linux-foundation.org> <20260705044139-mutt-send-email-mst@kernel.org> <20260705015116.bdf3335e9a955f057a6d9c5d@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705015116.bdf3335e9a955f057a6d9c5d@linux-foundation.org> On Sun, Jul 05, 2026 at 01:51:16AM -0700, Andrew Morton wrote: > On Sun, 5 Jul 2026 04:42:38 -0400 "Michael S. Tsirkin" wrote: > > > On Sun, Jul 05, 2026 at 01:39:56AM -0700, Andrew Morton wrote: > > > On Sun, 5 Jul 2026 04:25:53 -0400 "Michael S. Tsirkin" wrote: > > > > > > > > > If capacity is 0 or exceeds PAGE_REPORTING_CAPACITY, it defaults > > > > > > to PAGE_REPORTING_CAPACITY. The 0 check and the clamping is done in > > > > > > page_reporting_register(), before the reporting work is scheduled, > > > > > > so we never get division by 0. > > > > > > > > > > Thanks. What's the priority here? Should we fix 7.2? Earlier? > > > > > > > > If possible, I'd like it in 7.2, have a setup like this (small > > > > queue is useful for perf testing). > > > > It's very early in the cycle and the code seems straight forward... > > > > I judge the chances of breaking anything is tiny because > > > > it just failed probe previously. > > > > > > No probs, I moved this to the the mm-hotfixes-unstable queue. No cc:stable. > > > > I suspect the Fixes tag will make their AI pick it anyway. But hey. > > -stable maintainers have been asked not to do that - only backport > patches which have an explicit cc:stable. > > So should I add one? The "scratch my own itch, I want my hardware to work ASAP" part of me wants to say yes. But the "decades of experience taught me I'm fallible" part says let's have this out in the field for a while first. I had time for coffee, and I'm dr Jekyll now. So no, thanks! -- MST