From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4232FB97B for ; Sun, 5 Jul 2026 17:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783271460; cv=none; b=JTA7krxNeiCbN7vXGQ9NnN+NgzzTsljyAtJGFoVZRnnDrAtM1zaXmPe+qsxnODJmh7X9/76fWmunUx9TauclAbfSF4hzOrcB+e4M/zRWZ0iu53XMFn4pp6557GU4kTQFfDf4n7EBg2KtGGio4HJ1BO1s/7c0a9a8OTV7/ezMwk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783271460; c=relaxed/simple; bh=dKbDeK5JMWOskgWhH2hh7caMG/c2GZ2IPAktPg/6cNs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JGm/7+TZRvn1hR0NjEKTwXqtF4R4Am+bW0veWsajxYxkitN0U7sZtwLWN8nLqWEZXSAEKQPGpIztUyfeDAYF+SV0xxBsee3I1DDbV5/zou/y4Wb7OYWVfXERgPPC5OVi/xQu2GyaEziVL//+yXxWgsw/MfQVNMVzmXz+53BnmR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nhSDDkBi; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nhSDDkBi" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cad4170e8eso25648355ad.3 for ; Sun, 05 Jul 2026 10:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783271458; x=1783876258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=F6oriXBGQKRVO8BFxyvH8HRrLjtHNA6kmEs+Bsjv0iU=; b=nhSDDkBiBbe/r0O/hrmVo/YXhZdHa8WqS6U9CtYjhxg8iFf361CYu87vCKxNe+rvkV jCn+TnXqs3z57weJ4naFi3ojqA/Yay2eOVNlHrJ0tEy05rXgZoV/aD09CTwhjI0s7VMa KhZA8M0psaUqHEVuOOVDIOFnAD1dFQLFrdq+dgZ79jfsIomVJ/VTWmaNjIn0X9nS8TYJ mt7jILqPdkOKKGriexoVN8RWssC6kwQEBLTwOs6X8WUMmpDAU9jC9Rg5BbEjcx7Hmdge eGXp5QWarXJjx26iHNphU5Z4SJzvBmAILPBExRX/5j2oqxGMrYhL7jJH9wPUhZsdqSLo LJBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783271458; x=1783876258; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F6oriXBGQKRVO8BFxyvH8HRrLjtHNA6kmEs+Bsjv0iU=; b=TSeWVIj9+3+FdlRNpDflRfiJdTxnfiLn+GI7V1MrKAIrdjqIQlrBx6a45FxUeCgffS FpkkmGOTyBoxSjFwBgNFPHcTnaw7XrFClEX/uCy8fYFLmY05Fuk6FaaapNoTn2BgSPWo /Ap+WSDOl+4cZ0TPbD4pHrxk4T3i3nurBew/Nii9xGxKb+k95jtyv7EvrxpRB/4XIaEU HoWhXaGY6W3TpWh+9utolrjEKtMhsnMD0by/9QTPfTYoCtD1VT49KEgvKNWXDNJDozxu netZsrMMC5JYG3d9AnsXCYuHtcnceK9CZIBK/h5xJ6jj5+hs9I8cmxOgqu2oJWi2IyLh vG1g== X-Forwarded-Encrypted: i=1; AHgh+Roncfs3ZmMDDnOyCI58Gf01jt3lx3YO8nruYQ3jdJoJSOQ6+7tSxec9vI2MyrhlVwqVRTCcLEy20Dklz2Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/rTwKqjcEVXmU9GCW+kILOTCanqFArUARN1fEgvP+xoNraFin 4phPcXjk1x/IUDVO7S1lAjn4z5BLcBHBP3xFbsqvz+VWM1Bc/lbPzcWk X-Gm-Gg: AfdE7cnrgfKtVLBkWNIUgn9hgQJK6HWvNYTHXUxTUUvnsHCmSaCJLzC2B0ki7Ei5aa5 A5iDY7zQ1J11UJlDpSJmK4b3lsR1LDcu9ITdsk90YAbnCEnWZ1zJATak1GAAvqh8r8Mj/uSqjvi /dNS1HexK/95P7z8mzY0dFeXna6co6y7vos4OsMods+C4RuOPAs0TyJzKaIuwdjp8qy8pnzAJNh jOOAIoYeNhw3ZPZsXlKKuh9HgSC7Z0FbxhZIrYwRO2H7FjrhU3DE+pXbTqtreec0wi6hj36wQmM XaEBOx6ghmWg431hxYr1pblBeIEATCdkGgnE4T0r88YaAhNkXdF63IBzgIkGnG16dUV9Dr1cByX BXXXH6UDcpKPtDCxZRMPYSB0yycgy9p5dYb7MveyUvWqzNh4rDjKHmf6/ectoHf5u2ZQRV2R7DQ +3hNKr+NDPhemxxMB4YDQk2ApjIzEYNEPYOZ0ekrC9LPKoQNOwcqVUmwzdTA== X-Received: by 2002:a17:902:ce83:b0:2c9:97a7:71ae with SMTP id d9443c01a7336-2cbb9f2a80emr65200725ad.41.1783271458503; Sun, 05 Jul 2026 10:10:58 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c876ea9sm39655434c88.13.2026.07.05.10.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 10:10:57 -0700 (PDT) From: Malaya Kumar Rout To: linux-sound@vger.kernel.org, tiwai@suse.de Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/alsa: Fix format specifier and function mismatch in mixer-test Date: Sun, 5 Jul 2026 22:40:38 +0530 Message-ID: <20260705171038.171966-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the ctl_value_index_valid() function, when validating 64-bit integer controls (SND_CTL_ELEM_TYPE_INTEGER64), the error message for maximum value validation has two bugs: 1. Uses snd_ctl_elem_info_get_max() instead of the 64-bit variant snd_ctl_elem_info_get_max64() 2. Uses %ld format specifier instead of %lld for long long type This is inconsistent with the minimum value validation (line 335-339) which correctly uses get_min64() and %lld. The mismatch can cause: - Incorrect maximum values being reported on some architectures - Undefined behavior due to format specifier mismatch - Potential crashes when printing the error message Fix by using snd_ctl_elem_info_get_max64() and %lld format specifier to match the data type and be consistent with the minimum value check. Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/alsa/mixer-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/alsa/mixer-test.c b/tools/testing/selftests/alsa/mixer-test.c index d4f845c32804..242a0b21e85e 100644 --- a/tools/testing/selftests/alsa/mixer-test.c +++ b/tools/testing/selftests/alsa/mixer-test.c @@ -339,9 +339,9 @@ static bool ctl_value_index_valid(struct ctl_data *ctl, } if (int64_val > snd_ctl_elem_info_get_max64(ctl->info)) { - ksft_print_msg("%s.%d value %lld more than maximum %ld\n", + ksft_print_msg("%s.%d value %lld more than maximum %lld\n", ctl->name, index, int64_val, - snd_ctl_elem_info_get_max(ctl->info)); + snd_ctl_elem_info_get_max64(ctl->info)); return false; } -- 2.54.0