From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A474840D56B for ; Mon, 6 Jul 2026 08:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327461; cv=none; b=Sn1o2/RXGDYarT30lqlw066NqHlRGv7/jJRbNr2gfefv1uAFUUnz0heIThioEasmizfrziVzGlWm3dbapcYqJ1dIOF8d9J19JdfbCByWlTXAqrXbkrmyGhWG7TRwohmO8MSN8Xs4sg0ElwoEK5H4fR+GoiZxuSb1z/XTXetVhdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327461; c=relaxed/simple; bh=fcHRSt2uu6fC372J+gEM8pzdWzCOu8p2V+bxQ9uVUUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M+pw1hao82v/Tif2LY5/2dXpJVsNXDEUwWsxZu3XdcbXUvh1HcDYaiIE0Dqbnz3WMnU6ngRQVZEbe0DFx5RIVt9NpM0B9202G8m3EyiNjmOPbMb7GpsyDpAhKOUMoJbEvDo7o6hH8ChW8Gf4WuKZu4vamc+7dLEwkHDI3Rj71+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TQ8xpR3B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NtDjsUNO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TQ8xpR3B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NtDjsUNO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783327445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RLCqgq8bJA3wDjgxn0V0PvA/+/Oia2v1so+e3G6fRBo=; b=TQ8xpR3BtfIHIjkL6h55ltfki8UrsG+lzlNzk8Pjddr6DWTUFYRJevKJWSNfR/nfw/OLhb 0zSqQvGZwp4VvAghkjAXkqEll9VNTO5QwDlDF4guKl6+ofI8o04ecOZUH7+GuZx7uH/Vcn l/rg7kJ/p5l/Gl6pJSgWgcPS+ocIT1M= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-QsIo4I1tNJeGjL7FNZ62gw-1; Mon, 06 Jul 2026 04:44:04 -0400 X-MC-Unique: QsIo4I1tNJeGjL7FNZ62gw-1 X-Mimecast-MFC-AGG-ID: QsIo4I1tNJeGjL7FNZ62gw_1783327443 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-476608a9fefso757436f8f.1 for ; Mon, 06 Jul 2026 01:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783327443; x=1783932243; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RLCqgq8bJA3wDjgxn0V0PvA/+/Oia2v1so+e3G6fRBo=; b=NtDjsUNOjPKVLKGxLL3nMGKUYxcd3xB1TidLVGzWuX2168gF1ccWOoDtjMAC+NWjmb O7QQkUjG4RtOlhZ9QHQc+6u02PKwQnglGf1dcSqK2Kut9Z8YgJO2ImN57uL2VoL+2oY6 1+DhM2mGBEEysAeMDTAzYlhC6ZSTjCIZCE5d5c7ohAuBJBZ8Vll2NTQeuzNPgKAymBap QuoQsq+tycik8UqNXNVO61xDRfTgIquuqxY+oUO9EVe5FGa7lqKFE+bokTM6LDoM5a+l o9BTEJlMQDb+29BYYcVxG52WuPYWcMLhPBktdahXDelMm73jDm3xyOTESfRR0ic3RXvV L6nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783327443; x=1783932243; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RLCqgq8bJA3wDjgxn0V0PvA/+/Oia2v1so+e3G6fRBo=; b=JMHLYd5GKfqZtpRKJcWbnvdmzXOOwDfWqLUkv6sG084NOy1KBbR43rpdFAhDuLahAD 19ZsXWYhiZS0ZJHfb3yDFOZsxMeyp6zV2IvTLPdpZrPVm5p6hzmFBoGHxPYEhzYMuAfJ lK/PCqfbX3jeE2LUIhYmTeRvWIlU8Ocu30jqgChYH/JsONwyqTlu3LgOCH0q2WG4R+0z OmcFqo/J9nBri/NUver8jqCREuGNcl/iexH4jweKfewrS1A+QHep394OYIF1OSmUV8WU tmjUCcTnxtO/6pO00XpAyHew4P/rs4NWAggcFqzvqPKL425G0dGPP+ws38qK0IO7YT7C ypkQ== X-Gm-Message-State: AOJu0YwmLTLrJ1eSuChz84TE+6MgrBwOeq7SrzPj+dK4VNJ4yakvl7F6 HGyISQzbB6YFiqtshf4dvp9iHcjHFj7TBPTf0jBHthf6eH82OHL4GfYaTH5aLnXAKkxyeFnyAG+ jANvcpNQs9/YHT0N+IKaQV9Jdu1biTRROpaoSzYP4lvLCTF1gmQzEIbpf4FbHkjx86A== X-Gm-Gg: AfdE7cldZthebdHcsEW/rPWTE/RWcXrg2dxcAT1EBOjnPRfGYnkP9skxQfX8xZGFNss yifTFZrWBoTcKHTMbT16d6+6UiBtMfU4OPJ4OWth6tMUVxb0Wb2wDnv5gFcMBT91IET3ZONOTih LZLyKVvFJB8LWcwPzNxQUsXh+51krVe8jrZJz7S59+vp+9zHMyUymOA5Cka+mkQiXOcHhjXscaJ oUZj53+pyFPL3mLlKc1iqd+s7K5B2+F3zsiL6FQgTAi0qyt8+d501wXWEoVPaBjMKiFvvaFSFj1 xYiyLt80EHVQ7Hrlbv8LUo7LEYAleVboQGg2XeA6rdvSEPcvbkeVHaRWIPngMax1BxQW+w05PQb Uz0waScyDPMP1ojk4Gfb6dgaAfMzrkBho X-Received: by 2002:a5d:5d85:0:b0:473:6590:c42a with SMTP id ffacd0b85a97d-47abad9f1d4mr10815764f8f.9.1783327442853; Mon, 06 Jul 2026 01:44:02 -0700 (PDT) X-Received: by 2002:a5d:5d85:0:b0:473:6590:c42a with SMTP id ffacd0b85a97d-47abad9f1d4mr10815728f8f.9.1783327442334; Mon, 06 Jul 2026 01:44:02 -0700 (PDT) Received: from redhat.com (IGLD-80-230-68-31.inter.net.il. [80.230.68.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960af0sm21194916f8f.30.2026.07.06.01.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 01:44:01 -0700 (PDT) Date: Mon, 6 Jul 2026 04:43:59 -0400 From: "Michael S. Tsirkin" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Adam Litke , Rusty Russell , virtualization@lists.linux.dev, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v2] virtio_balloon: prime stats vq after virtio_device_ready() Message-ID: <20260706044122-mutt-send-email-mst@kernel.org> References: <2f0d0de033f3005d3b985883be3e5cf37b3f6c42.1783278596.git.mst@redhat.com> <13794c5e-375a-4fc5-84b4-a637d077f8a0@kernel.org> <20260706042207-mutt-send-email-mst@kernel.org> <6b8e4ad3-6909-4d0a-89a4-104a5ad9fe79@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b8e4ad3-6909-4d0a-89a4-104a5ad9fe79@kernel.org> On Mon, Jul 06, 2026 at 10:38:18AM +0200, David Hildenbrand (Arm) wrote: > >>> - virtqueue_kick(vb->stats_vq); > >>> + disable_work(&vb->update_balloon_stats_work); > >> > >> That's to stop the stats queue triggering stats_request() I assume? > > > > Yes. > > > >> Is that > >> valid before we actually added+kicked ourselves? > > > > Why not? > > I was wondering whether the spec would state something about that. Sorry I do not get the question. Virtio API expects callers to serialize calls for each VQ. So this just prevents the work from running and accessing the VQ while probe calls add_buf/kick. I'll add a comment explaining that. But it has nothing to do with the spec. > > > >> Also, can't we simply handle that in stats_request(), just ignoring it there? > > > > Then we'd need to maintain a special flag and I dislike that. > > I was hoping that we could use the device-ready indication, but there would be a > small race window indeed. > > -- > Cheers, > > David