From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115DF3BB687 for ; Mon, 6 Jul 2026 07:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322727; cv=none; b=G2xjiAZeqASFOOzsLA1c6bkXidCW/1BMXPvGr+rlERgwz12xeXSmnHtCBqMTTOhTl2tKKdR1BW9WY7jRx3mGUnVdu1cM6IqYO6El6/sj6K3AQdh5po45IGvzDfrQaAnDjklMaOghKTaywXPrgAi49+9tI9GFThZebOBitEsHahM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322727; c=relaxed/simple; bh=rMATcTzNEPAExjisuV4h8drnguRJS39nPvUj5pvdhT4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y/B0bkDaa5Pa7invxuxa3BeXt0kbIacbJmiarTWpfi1y0vIsQvs/PzIC3tWXjIB45NoK6y2pR2vPjOKa05l4wNTRRisTM1ilBeMFcTmHGmG9mM4qr2P66XznTm6Rp7OtFxA/15bDcAD7lhwJDqN89OCMpP5BAGTb/dJBWAYyHQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ionos.com; spf=pass smtp.mailfrom=ionos.com; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b=VCNsJ5ym; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ionos.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ionos.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b="VCNsJ5ym" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493c2c0b9a8so24014875e9.1 for ; Mon, 06 Jul 2026 00:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1783322707; x=1783927507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WlUx7FJI3jHMt0+d6JmF1hqOHHnUGnwftrb8B/z+p8k=; b=VCNsJ5ymAGEpKlnPH3QaVDMVT5aAq0nrSvACrNkA/Q8KraagtFYuy3pplINdefH9gA 8QimXWiBAsTB3pGB5sMTJyH/HU4b1eMIPG+mwVj8jhPRS5HIdoNiNlszkgnpqKwK59ec ha3K/CxBwcFYM6pIhhx31Bj5O8le17ltGo/bT2g9WNShW14cbaFgnEC6yJLt7baTRZF1 jWVS8p+qhfv1SjG1xcBPQBWs5uW+qkLtgK4vDKwHacpdXe6kaWnpwjBpkaTTaXgOLD05 t9GXrvfNk0Ufm+Qui68+2W3pZsu2Ud2/Q4cTi4KdCiBn9eCUt87HqsJTTU6L1VVal0cx pUUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322707; x=1783927507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WlUx7FJI3jHMt0+d6JmF1hqOHHnUGnwftrb8B/z+p8k=; b=HYaa0PEMmY+lRbAymE5NTzo2PO1+2e5H6iseEMUBBPT29Da22icutDqBhHKSb67GHp qxe8mAUdUWsikWZeySGJ4nkW+tU1/PfC3Uscs0piRITbv3NCpYwHw9Zg/4nIjB8hbxqj BYwSDZypGzvBILUekaeW3VqYESRE1xiVDYC6cyg9qLlEbpwKErKgJZ1UGWHX/zOdURZP uT1nFu36IxVLU/+S1vNNwDUwzWG4EMfnxC2ocjaD6chBLR6HdpIvTWZWDkroj3dE2ilE 1bpt4OyBf3G8UE9d13n3B41A63gYMY6TKIV+dudn9zWhcBZUhOLJaUHe3M+Hd8slY40C H8CA== X-Forwarded-Encrypted: i=1; AHgh+RrgqmtX+W2cpayD1eCAi490t3t5fmil8/+uh2huGHUwSI4xXSSB1Hd5/hvsVJqjlgQfwQ1luV7cwnWc7B8=@vger.kernel.org X-Gm-Message-State: AOJu0YzVr8WwrxrzqJfVN2cpKazhna9isotva3Ilb84y+MkHThNZ/vZR 3T1Rf/59HCU1ExIJ5L1F9vpDCZ/9AezvawO7Zlkz2t5F0ncwrfs6sVaY+vnbGyDWSQI= X-Gm-Gg: AfdE7ckiBz5FpC0G8bEfQIexoEcNOAQGP6mnxzCVqEMwQ5mBnfkDr4JE8P8Ntx3acTr 3qE1txV5+/SvS7uBF9GOY1s88Z/BQZBka0llFoxXEkb4dqkx4GtDl5xEAVnUpgWc6ggWKy/j6UD 7QA+P2nti/uKZKGwSoF/XRbD+AhqO4ZPlSDtIGOcgNWR40Us1VUZnc1VL3H1LP+cnvfLGWS3Q0M 8jhRYlPsdEcXluJuFz2CaRUeAG1KDA4bKq6mF7naJJKx6NIFJMCQgfxZx3iG1vhW21qJBP5Qupl A6NJBsLCOtFzhgRSSCrRgyzX7RoDZJdlek72qjKNgFhSt6V6irSdyQMa77vhD9b+CUoV7xH8B/w jXzJBm5J0eOFt0I+DMh5VBaZ0Mq0yd6CWpRpB3fa0NzxJBgSfbp5AscdyYhUqCsPlKCbCFFMuQb xHQZJX8Jwk2TpQaKc93EazjDmyjEyFptIKbf2RA6PMS536rIEHDdvmY8KIIXVdocinLA+rKx96J TZnpieasQRCSwRO X-Received: by 2002:a05:600c:6792:b0:493:b4cf:d37f with SMTP id 5b1f17b1804b1-493d11d7dd2mr101176875e9.16.1783322707462; Mon, 06 Jul 2026 00:25:07 -0700 (PDT) Received: from raven.intern.cm-ag (p200300dc6f45eb00023064fffe740809.dip0.t-ipconnect.de. [2003:dc:6f45:eb00:230:64ff:fe74:809]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d905sm22324916f8f.2.2026.07.06.00.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:25:07 -0700 (PDT) From: Max Kellermann To: idryomov@gmail.com, amarkuze@redhat.com, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Max Kellermann Subject: [PATCH v2 16/18] fs/ceph/snap: add a kmem_cache for struct ceph_snap_realm Date: Mon, 6 Jul 2026 09:24:47 +0200 Message-ID: <20260706072450.3920010-17-max.kellermann@ionos.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260706072450.3920010-1-max.kellermann@ionos.com> References: <20260706072450.3920010-1-max.kellermann@ionos.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There will be lots of ceph_snap_realm instances, and having a separate kmem_cache seems worthwile. Signed-off-by: Max Kellermann --- fs/ceph/snap.c | 4 ++-- fs/ceph/super.c | 9 +++++++++ include/linux/ceph/libceph.h | 1 + 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index f064b5ad3bf4..12f80df4b651 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c @@ -118,7 +118,7 @@ static struct ceph_snap_realm *ceph_create_snap_realm( lockdep_assert_held_write(&mdsc->snap_rwsem); - realm = kzalloc_obj(*realm, GFP_NOFS); + realm = kmem_cache_zalloc(ceph_snap_realm_cachep, GFP_NOFS); if (!realm) return ERR_PTR(-ENOMEM); @@ -205,7 +205,7 @@ static void __destroy_snap_realm(struct ceph_mds_client *mdsc, kfree(realm->prior_parent_snaps); kfree(realm->snaps); ceph_put_snap_context(realm->cached_context); - kfree(realm); + kmem_cache_free(ceph_snap_realm_cachep, realm); } /* diff --git a/fs/ceph/super.c b/fs/ceph/super.c index c05fbd4237f8..73c316c23315 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -910,6 +910,7 @@ struct kmem_cache *ceph_inode_cachep; struct kmem_cache *ceph_cap_cachep; struct kmem_cache *ceph_cap_snap_cachep; struct kmem_cache *ceph_cap_flush_cachep; +struct kmem_cache *ceph_snap_realm_cachep; struct kmem_cache *ceph_dentry_cachep; struct kmem_cache *ceph_file_cachep; struct kmem_cache *ceph_dir_file_cachep; @@ -945,6 +946,11 @@ static int __init init_caches(void) if (!ceph_cap_flush_cachep) goto bad_cap_flush; + ceph_snap_realm_cachep = KMEM_CACHE(ceph_snap_realm, + SLAB_RECLAIM_ACCOUNT); + if (!ceph_snap_realm_cachep) + goto bad_snap_realm; + ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, SLAB_RECLAIM_ACCOUNT); if (!ceph_dentry_cachep) @@ -984,6 +990,8 @@ static int __init init_caches(void) bad_file: kmem_cache_destroy(ceph_dentry_cachep); bad_dentry: + kmem_cache_destroy(ceph_snap_realm_cachep); +bad_snap_realm: kmem_cache_destroy(ceph_cap_flush_cachep); bad_cap_flush: kmem_cache_destroy(ceph_cap_snap_cachep); @@ -1006,6 +1014,7 @@ static void destroy_caches(void) kmem_cache_destroy(ceph_cap_cachep); kmem_cache_destroy(ceph_cap_snap_cachep); kmem_cache_destroy(ceph_cap_flush_cachep); + kmem_cache_destroy(ceph_snap_realm_cachep); kmem_cache_destroy(ceph_dentry_cachep); kmem_cache_destroy(ceph_file_cachep); kmem_cache_destroy(ceph_dir_file_cachep); diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h index 63e0e2aa1ce9..379629cafbce 100644 --- a/include/linux/ceph/libceph.h +++ b/include/linux/ceph/libceph.h @@ -276,6 +276,7 @@ extern struct kmem_cache *ceph_inode_cachep; extern struct kmem_cache *ceph_cap_cachep; extern struct kmem_cache *ceph_cap_snap_cachep; extern struct kmem_cache *ceph_cap_flush_cachep; +extern struct kmem_cache *ceph_snap_realm_cachep; extern struct kmem_cache *ceph_dentry_cachep; extern struct kmem_cache *ceph_file_cachep; extern struct kmem_cache *ceph_dir_file_cachep; -- 2.47.3