From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2A993EDAD2 for ; Mon, 6 Jul 2026 08:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327830; cv=none; b=j3DtqzEo3kyF/cYvcqQfqh+ssUl9Ag6CdCeZbDuFKGdZ0wF3OW9MqueLbBlCi5gKsIeA9eDlQ7kQrC/XWF96Nop3LvQdm3syfqE7FZc2bclL1B5A4+4eERl+96BQBM2WDCQRE8oSzHG36q12fqrbVD4F9aJlMYIHEGF8vOqXJow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327830; c=relaxed/simple; bh=w24kCOhd0coL7UOZzJIQAkRBP5LzvS4+x/myXHiLLnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uHIAm5jHppBKaX57Ue7eXC+Gm+HeJ+Ssgz7a3Cytbndv+eD0wP6P6K4Qn3EujDc7nvaIsbI++ltEIIKZeKDbEVnnt9dnWZEgeGGr/0tptTPBYdSZHUM1zUPGVo7YgAKBMxsgvWqbCfetxbHn3zSLAueoHlsqE85AhS58uCRVzEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ezUKEk59; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ezUKEk59" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8453427d3f4so2529443b3a.3 for ; Mon, 06 Jul 2026 01:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783327815; x=1783932615; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sg/TjGf717Hj/OrWbBMOEQ2vxvsdop73pQNz4dt05yY=; b=ezUKEk59N4/RLkNxnAFwJmq7zYgS1imIIlfeOCvZ9z3YLnXsGfNo44S/GutJ4UOSf0 dBKbLcIeNoj2ecYwu9BYETihy8uWvftJvgXMiRRwgtQ6B4US1AgZ9kxyDalAl1BQ6Kxx Bicnk5VRY8jq9H/+6BWSj7b9qC8XsX/Sl74aQxddFyWAhcPyfZTXUTUyEEG6ssMMtrnw nRsPoW6XA0UR2Qx1zEs/A+B/AldqFx99CLcwXOPvxVAETrpAgAyVwhXIwPQyIollW90M CeXgSeZ7lab2wY63f8E6nbM6mtCWneftA2O0Coae9mXBuSTJ19QyJ1N8Dhg7aabimCuY yckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783327815; x=1783932615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sg/TjGf717Hj/OrWbBMOEQ2vxvsdop73pQNz4dt05yY=; b=NpGlwFC/l5MRj5Ag2gygLgmnH/lKZVVX8Xt/SYRMjWDLhw8Xl3hIyPeBb/st33VQVx CCmrqa+AJMVUwXG0XlxWrrVLeBTinH+TEh8VTEElirY+1NV4Igz4FmsBMCeHg/b2kw71 Fgv+TtgOWP4b3I8E0Vz6oXV8p1pHQVMLRYnjPSdJIhcDtbWZv1lOSWidLWuvmy0L6ygH mQ7U+iD0zf8ZNe3SZOqBf9zKzVWa6VBQN+sd3wfJdmV906gMseLJyQFF78MzRFen+3DD 3OidcbJAYV+90LOQtNenni+noEn4QrUNRSKiCHzDjlcPxasfw3MpvZh9lsJKbA3Rv7Pb V9xw== X-Forwarded-Encrypted: i=1; AHgh+RpqnSnJqng1VtKAa9+jOZonD7aB6QI4EAlicLz7XlTpEX0z66QchhvHMvvok1iAov9ISaCmReKu+0TlfM0=@vger.kernel.org X-Gm-Message-State: AOJu0YwLHfJFa2nHMSzy2sx+vxRJC7IWlXApqZcq8Pz7m2U1HdM3sdBW 98V34oxKstktjIAsbD453CP3q5xtlfjZYXNtksSpLB+ONqa18pAM19G7 X-Gm-Gg: AfdE7clTaz5+TZxxbZ1THcCv2CIfMKTI48sLL3eOSQ6rqcHijlVjzYEo+9v1PS9KxDQ CPPHH9+uMBMBuxI9qPJC2xW0xfCw7ihtmFx9UKfoFMB00nm3x/P19YgiUgp+VpiBwF4b5FXmv/a vwFb17gpYnGVAAq8DE5Wyh0h+cL14QUgAEZDoGS+fTVM3+uBA2eIoYrX9HRycy6jgiU/nKq/j9k 3/Cw3qL7vzyMBn4u50C4+RXOz8XHsI4/jewFffbDmOQN9BvDHaP1jbP5klRVJQl1fdUG5EGE2KB 0VIz+NZOVmkX2Qn5CQ1wq5lRmIAauqnm6reIiRaX4+ugzwi0v4/b7rlegErVhSqYY0WtmrY/0T/ //yT7u8Y5Jn+YAsqRxQZ3Ifv3IqaOPB0RM3J4+rdr5RQ7qTDF/E1qa3r8qzWHNixybZtx4yenex 8qomJvuJimi/XM823fox1FkQgznJocZI5KJWGY1h2clq+qAu4= X-Received: by 2002:a05:6a00:198d:b0:845:ce5f:c934 with SMTP id d2e1a72fcca58-847f6d37744mr7331968b3a.2.1783327815050; Mon, 06 Jul 2026 01:50:15 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d7c142sm3422924b3a.45.2026.07.06.01.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 01:50:14 -0700 (PDT) From: phucduc.bui@gmail.com To: Cezary Rojewski , Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com Cc: Kees Cook , Dan Carpenter , Cen Zhang , Len Bao , Mehul Rao , Sebastian Andrzej Siewior , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/6] ALSA: hwdep: Return -ENODEV instead of -EFAULT in snd_hwdep_open() Date: Mon, 6 Jul 2026 15:49:46 +0700 Message-ID: <20260706084950.49331-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706084950.49331-1-phucduc.bui@gmail.com> References: <20260706084950.49331-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc When try_module_get() fails in snd_hwdep_open(), the owning module is going away and the device is no longer usable, so -EFAULT ("bad address") is the wrong error. Return -ENODEV, matching the other unavailable-device paths in this function(the NULL hw check and the card->shutdown check). This changes the errno reported to userspace on this rare race. No other behaviour changes. Signed-off-by: bui duc phuc --- sound/core/hwdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c index 973d11732bfd..352047e0b33e 100644 --- a/sound/core/hwdep.c +++ b/sound/core/hwdep.c @@ -87,7 +87,7 @@ static int snd_hwdep_open(struct inode *inode, struct file * file) if (!try_module_get(hw->card->module)) { snd_card_unref(hw->card); - return -EFAULT; + return -ENODEV; } init_waitqueue_entry(&wait, current); -- 2.43.0