From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9CA38AC75 for ; Mon, 6 Jul 2026 08:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327837; cv=none; b=uU8c5ZIve5q8j/2YsueH/LWVfYMZK8y9kAzmbLJ9TIG7KG33nw2grd7RQtwDGfyom8HXO7IG5X5u0xD6W6i+1vjeKML3eZas/y7ZW/v9QmJSEwYZdLw8lEEvpUb6mzZ3OMvmS5qOD/KU+9NRmx40d1q6WUCR4OQH505Y1zTOXSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327837; c=relaxed/simple; bh=ENhMp/0z4K+KPk5wY1qhXxOXME7jnjqS6L7CXvLQ/xM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eAYtZ03d/v27b2yB7gdAGA71VD2R2wHwD5ataBpKq7z+QpWEMhecxBwZ70HazuKhTErsfxtDQBOh4W/YGvfs94hhdHduSefFKpJvu2cO9htvYg3T6PtyVUvevKJ/IK7cFJB/Tg9i0RigiCghPVG6I5IlWKL5U/6qT+Zxw/MR8qI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eIahR+rS; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eIahR+rS" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8453427d3f4so2529604b3a.3 for ; Mon, 06 Jul 2026 01:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783327824; x=1783932624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xbJwjEcYiJxFPsHxxXYWr10WIjJN4DhZ+T0K4JfIccg=; b=eIahR+rSVFjngCZtxaH6cgeFbPM8dtDo7VX0hgpbml35osqh5xZNComeaFmLQiKU4r 0xSIOVAX1Y/DruoFh/2g+J3fMZsOaUGdJ1XotOeA+bGCrx5lhCjZ5hOxnpXIobT6jVFM 80Mmvl6JD412ig9TxdGml+BiL8ppqjs6gnxKxXKEGbtVcOdsTD4BJgsPBRPlTHD1IF7g s+tSVnvJ/3p+V3tES0ECiY5slW16ntOOwVUtOMkk+EZIGjTGOO50qANrDWQidSYxLnFl ocLSzCVRu9XMl3IID45xg7HCruG32Q5EWxtfgbytw7Fc4F0EgD18Csb5mxUG9uldJDte yfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783327824; x=1783932624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xbJwjEcYiJxFPsHxxXYWr10WIjJN4DhZ+T0K4JfIccg=; b=R/6cqlePFwhd+XYp38wleNkZY7EN6oylVd/EvEzHicAsimY9oH57nFwvmsICMieirM YJ0t8bIJcG3nnJYa4TNxo+ZfZh/ia2KoKj/Dn03wGprwHEYzbSyEyvfM5+a/5cRq8EeZ AmwsliJbrFQK47hWQHa91iTDxqDB03jhFDrZCljin4RIsdmW1778/l95vMuFreQhv9Zs uLxXEUOe2RM0FgxK6V//JUr8Fw3PZuYTTks6VHzzntgxEJ1eEHjLKPbUowkuJsLJfHHv ERjG3DuCktZ5habNcCQWwQBxVWnaJIIyQnncm60Y1Gy/l3i0NjsLqX4XQ4s3CBco/WFe eJiQ== X-Forwarded-Encrypted: i=1; AHgh+RrigJFqmkltHsTlboBvRPfDSFMehOuNOqohPOZBbRgY9YgINn/VotehPWpFmIgDn2SDmll5/J+giY29mcI=@vger.kernel.org X-Gm-Message-State: AOJu0YyWhfYMUgLITJP5Bhc0rz7BtmMpXtj7zPQ6ZD5bPWU1Oy6Ej06/ xsthMOU0eO1IwhTGAef6jBZSnBZAo50wGNAYZcX5HdaJw0jHok2YYN5k+BBegA== X-Gm-Gg: AfdE7cmZjk3HjIyxLRHb0e+K7zi7wD08aBOVfp5OG5I8225i19SN7T4RDalc9jESPhy siP9SYFG0Pf1ATqiy7n1+yafwh2hEdSGNoS3pynWb71WzgjmAeqwVGoGNf0kjZpcJ4JClZ49ezO PMUpE7ZhbpysaGILXWveh+llx9CoJAKGTEJ1xiHOGIfQlKVZYJ6rMH/L2mBgcusrTpdH3aKl/mA qfmoktH6KXSXVazb6SrV4HvqZoIV+6WP78MNkqf23Bp8HbEEh98foyaDadvjGJOI2+CiKrKx4yj odnms9eMYaejORETKT+lidhGgw5kW/Rdi8zjiiJK2P34ZGvCd21tc9O1W3W08hUcOoZzP9xapOU Pav7qPF+7gL9xHDzVpi3BHkwaXy6+KGBdL7L+KCpaAxht4lCJVrQfQWBSUnqUR6m+a9SMaV7eAx 4Hj8w62wFTXwdQw4Vb2PlhfbCG7vKQXe7mFviZw7FINnZk+xU= X-Received: by 2002:a05:6a00:812:b0:847:8250:2b2a with SMTP id d2e1a72fcca58-847f6f95c50mr7929971b3a.60.1783327823659; Mon, 06 Jul 2026 01:50:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d7c142sm3422924b3a.45.2026.07.06.01.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 01:50:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Cezary Rojewski , Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com Cc: Kees Cook , Dan Carpenter , Cen Zhang , Len Bao , Mehul Rao , Sebastian Andrzej Siewior , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 4/6] ALSA: mixer: oss: Return -ENODEV instead of -EFAULT in snd_mixer_oss_open() Date: Mon, 6 Jul 2026 15:49:48 +0700 Message-ID: <20260706084950.49331-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706084950.49331-1-phucduc.bui@gmail.com> References: <20260706084950.49331-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc When try_module_get() fails in snd_mixer_oss_open(), the owning module is going away and the device is no longer usable, so -EFAULT ("bad address") is the wrong error. Return -ENODEV, matching the other unavailable-device paths in this function(the NULL card check and the NULL mixer_oss check). This changes the errno reported to userspace on this rare race. No other behaviour changes. Signed-off-by: bui duc phuc --- sound/core/oss/mixer_oss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c index f5bcc7896542..3a1dd1edd26d 100644 --- a/sound/core/oss/mixer_oss.c +++ b/sound/core/oss/mixer_oss.c @@ -58,7 +58,7 @@ static int snd_mixer_oss_open(struct inode *inode, struct file *file) kfree(fmixer); snd_card_file_remove(card, file); snd_card_unref(card); - return -EFAULT; + return -ENODEV; } snd_card_unref(card); return 0; -- 2.43.0