From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEDF94314AA for ; Mon, 6 Jul 2026 13:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344231; cv=none; b=EL3g3jcB14qSh4jTzRpYMqG7y6wvF/LAH/oTXd9MxhqvEfTDPsu2916kMA52oTRVBoBXgM35GY1g0xqd7srrHGs/4P9gz04IDblI7K9YIG8q0ejpyPMkFKm8s9AOkx4bWzSZtgcqWjZidfxG1JZSXoRkIEUgNMTDEoJCjaV51tY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344231; c=relaxed/simple; bh=N0QGuvm6HyGdu49K4Td11hFP4tn89+ZNKW65vJ51WLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mbN3AkeZzwGzmQpILVZJK8EmypRsyuij78N3OiS1osqJqZa9BE4Mmw6OvtT9SU64EzXF5fxCajQNwboutbVZNMgrxecLW6E9zjzQMJNea3TVHM3yBzdbYu/H1UiwG9rqQanNfhdNYvrKllOkC3IDpNU0ROlTzrwxKH9/O6V2Roo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PHCdvLGS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gr4VmvyM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PHCdvLGS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gr4VmvyM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783344227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=PHCdvLGSnRnOsJxz+lEoZw44sBwm+vvGC26AadjxmT6yvSSiyNGZWw6qEz2fsvSd0FhdpN 7wSoCC1jleSzemNiwpakP2Yc1njIahRG4/8V/Uk1hkEhtCXqChHSz2B1lThYPKsn0B1NKm XN25pPQtQb4NaYVdheAfFFLjvFNNmHQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-kvIvbO8VNdmM1nL2SdldMA-1; Mon, 06 Jul 2026 09:23:46 -0400 X-MC-Unique: kvIvbO8VNdmM1nL2SdldMA-1 X-Mimecast-MFC-AGG-ID: kvIvbO8VNdmM1nL2SdldMA_1783344225 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-473941177b0so2738351f8f.1 for ; Mon, 06 Jul 2026 06:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783344225; x=1783949025; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=gr4VmvyMrtRLBnl5WQXAhAg4GBCKakKO/7NFJYJoCN49Im7ZcfvUA9hq4KLZJS9Cgd 9DwMj9+rcsbBUNtb2Ca38dTpUcvNvcgpMDwvYJDm8toHIPJNAXYMK5oe+qQG30wPQia8 Am1G9XrgAtUeIZmo1q/B8IU0KlyxvNkKkjWDJkwpVHuCFSMXrwwwEvzDfTbwZKKJ4J/a nOIuTDV31bsIB4NPZdLA2YwuhYhew0vzKkzN2hl36cjSIbDqCCsj3um1QiZn1x8cWSmd Iwsog+XOMWZkUtu0wcTdRqjnirm8jTo1lm1yDyW0YN6YgjUgE7rNmpH6FGFUgBk0K3mH HtpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783344225; x=1783949025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xwaVaSQ5TrM+UFp0WZFnLdkXUL3cYc/gcLsGvJWd3Uc=; b=KKfl7+fVVCgnl0DCZ/7jYEjB05QXglewycBX6judAR3onVUR/OE1tg6iBvMCeGwIGB Iq0/4/joWZT4F4LzHQu7hz8F/4u6Gc1zpPZv8JPjxrfL17gTReHCRpSr7aei5azPJmHG IKMYF8ED8XlPDmhdcXeVgYScLRzAjZGByq68SBBLSRy6+OakdKwnlZoKMYiC21XWZsi/ RzcY+qsWQrixTURwBTGGvflqneHDP29q9mJ177KI/CZQVBr8VBK+oox5E1xlbBj7RGMb vUJ+95G9uJw19ARgrXZFH7K5ssKMcCUSAPqo+9eTjcFjpSzji0dWog6ZULNKIiFuFSHD LtDQ== X-Forwarded-Encrypted: i=1; AHgh+Rrj1bnR+P9ixthgfmAEnmWm4O//kz4pSIPSiihf7vT6WCpUF/Ul0XxxYE2bCn+Fva7x37f1vqLHnsEh5+w=@vger.kernel.org X-Gm-Message-State: AOJu0YySE8XEGqCDgaSSFGlJrU04EPi0SnwLuHqr6HIE65Mll92lwvzE jdqKK7Ig7kyD6E6aF1atdvmZWu3oQXOBT/s2+Nsr4LgdGC5EhuF8PYU2R4gKS7G5o3i2/T3gc8f AFklcZbqan0DfGgXL8zkdUu02WzF7ji67G9SDZnYxU8DEbnQlaI414Vtbb0tEGNwpzQ== X-Gm-Gg: AfdE7cl0YWcQGbv/Gveri0OkB87WV1bliKXOzgNFtIUua+QE7c06wHpjFMWQ5gsGHOv vjPiaMTnyHRLbGoe+g5sGjTw5ReULIP+dAlBJQPsiSGXb1rh0XsnhSE3MxDPn5nBm5YEDQZ+/Em ApW2fuSASYIwORIORv3cC4E1xFB9ZwZjK0LCSzS/x7+6BWdgzF4AUiJ8L7luoUGJFVYBvetReU2 YKQFiGqTyQtu7qmiN5RLMLCbPtZSZaSof/8Y7PHbkMrvroH+72qxDVttk6rT1Wu3Xk/pqONfWES KTWtS5bXdofW3V8ku3Dv4JF3STLfHPZgytd6FKmBbifpU7B6FsMs20krne+gwZZN07apALoMnMP NnSzRKhBjyqng0CbbeNGGmrT8obfRIyGc X-Received: by 2002:a05:6000:82:b0:472:90af:e406 with SMTP id ffacd0b85a97d-47de66ce06dmr154908f8f.37.1783344225273; Mon, 06 Jul 2026 06:23:45 -0700 (PDT) X-Received: by 2002:a05:6000:82:b0:472:90af:e406 with SMTP id ffacd0b85a97d-47de66ce06dmr154861f8f.37.1783344224726; Mon, 06 Jul 2026 06:23:44 -0700 (PDT) Received: from redhat.com (IGLD-80-230-68-31.inter.net.il. [80.230.68.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d7801sm25370218f8f.16.2026.07.06.06.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:23:44 -0700 (PDT) Date: Mon, 6 Jul 2026 09:23:40 -0400 From: "Michael S. Tsirkin" To: Brett A C Sheffield Cc: Simon Schippers , Willem de Bruijn , Jason Wang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Simon Horman , Jonathan Corbet , Shuah Khan , Andrew Lunn , Tim Gebauer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] tun/tap & vhost-net: make qdisc backpressure opt-in via IFF_BACKPRESSURE Message-ID: <20260706091706-mutt-send-email-mst@kernel.org> References: <20260706094242.115992-1-simon.schippers@tu-dortmund.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 06, 2026 at 12:11:15PM +0200, Brett A C Sheffield wrote: > On 2026-07-06 11:42, Simon Schippers wrote: > > Commit 1d6e569b7d0c ("tun/tap & vhost-net: avoid ptr_ring tail-drop > > when a qdisc is present") did not show a relevant performance regression > > in my testing but on Brett Sheffield's librecast testbed it shows a > > significant performance drop in a IPv6 multicast testcase. The regression > > can be pinpointed when multiple iperf3 UDP threads are sending. For 8 > > threads the performance dropped from 13.5 Gbit/s to 9.13 Gbit/s. This is > > the reason why this patch makes the qdisc backpressure behavior opt-in. > > Your v1 commit message was correct. The iperf3 tests were TCP, not UDP. > > The original failing test that alerted me to the problem was IPv6 multicast > (UDP), but the reproducer tests I provided stats for in the regression report > were TCP "To eliminate my code and any multicast weirdness" and also to verify > that this also affected TCP. > > Sorry for the confusion. The command lines used are in the regression report. > > I've tested the v2 patch (with IPv6 multicast), and verified the > previously failing test passes. > > Tested-by: Brett A C Sheffield > > Cheers, Just to clarify, it's more of a work-around, not a fix. It's not really great to have a flag that says "change something opaque in the internals of the device, it affects performance in some way, we can't predict how". So maybe we really should revert for now, and work on something more coherent for the next linux. > > Brett > -- > Brett Sheffield (he/him) > Librecast - Decentralising the Internet with Multicast > https://librecast.net/ > https://blog.brettsheffield.com/