From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD0E3FD943 for ; Mon, 6 Jul 2026 14:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347484; cv=none; b=CNR3UESW+2fUo+feb5vHEKcqFnfOTSuXx9Rz1oeOEn0fjLdUbOq64Mnlh+iQiSsYDticPU+uo27uhoN4Jgc2n1Ur5o2Czts0TTNjPJCVOo1CvIoE29vzAGWQ3popnc6PtAm9YJxl3NmgQxSNHbwP1tUd7BMhrZS9/x0TMuAw8O0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347484; c=relaxed/simple; bh=CvrF3v+GJlUKfPBoWOvn5i8PYE2RXVmPU6DSfM1kQ/Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n5Q91hBv6RNpgpWZYDOtbHeZ2PxDKusCFqByF98bgb0JnZY3BfyGI2DjUzTU7DpMPtUjUV1O3k2Syp/TJGraMvF/MTfvHy41kQcwf5Mfrpx9i7hLF/5tXw9tEyQ/iJUPAtKMk9JO3SFASBpxK7w3bYnD359zaz4PdDlu1OAkQ+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=NI/1Nf/F; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="NI/1Nf/F" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666BIMvO041181; Mon, 6 Jul 2026 14:16:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=SlZg2WL9PhzUTcVOC L9j+gYbUADaKzo/Ork3fhiGgTo=; b=NI/1Nf/FOhtsnglBF1G89SDuIkaiq/wxo k8ubfvVMX6EGZ5wGud78oAkyS6bkz8dvqDjsGUZ3AvKLfRuhyoTVLsoDi5x4rRkW 4iGg8bcgUIuywoL1e9LPcgK+RktvREErr+GaLjwoqSo62u7rr8AQJueeKlTqiD9Y 3kpPxo2XC1gb7RnKvljLxITZy0lM8plXUzb5vpQrkf7MKtY4fL7n1KViAghdtpBy 7GO2BXxk36vYGDFV7pSHNRCwDE9ekJk0xp6PBJTfk09HIxule5dJ83/UtaXg1OlA RVy2+uEhO+6jUH8NoQBIWtwKb3PH16kB6MzzQrNAzVOHkpqvigXJg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6qkn9x3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:16:18 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 666E4jCY019274; Mon, 6 Jul 2026 14:16:17 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7cgpx44w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:16:17 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 666EGDMl30998886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jul 2026 14:16:13 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A90E20043; Mon, 6 Jul 2026 14:16:13 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 74CCF20040; Mon, 6 Jul 2026 14:16:11 +0000 (GMT) Received: from li-a84c74cc-2b13-11b2-a85c-acdd023f0674.bl1-in.ibm.com (unknown [9.123.7.57]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Jul 2026 14:16:11 +0000 (GMT) From: Nilay Shroff To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com, Nilay Shroff Subject: [PATCH v3 15/18] nvme: fix context analysis warning in rdma.c Date: Mon, 6 Jul 2026 19:44:17 +0530 Message-ID: <20260706141452.3008233-16-nilay@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706141452.3008233-1-nilay@linux.ibm.com> References: <20260706141452.3008233-1-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=Q/XiJY2a c=1 sm=1 tr=0 ts=6a4bb8b2 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=L-zbExpT5qCHzqbmkREA:9 X-Proofpoint-GUID: vpBfwbYDqkP9O-97Gy9PY1q13vMLmYdd X-Proofpoint-ORIG-GUID: RhMeqG8a0iw9YHvXyuwGa14W-pP96EBt X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX3gUbYRBoG4QS OnKoL+uSYKjaMwjvflcNv2yboJIiDn8D0DALmIpYhaB9tK7olp5EAuDLV8ZfK2TmhbAhBQaqweZ 5MqoBrqho3KjJUX3ZoWsjyMPB5PHCYo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX89eLb8WQ+MzW KNjBVXQd8P6Iz+PyaasKf3dhqXdwU8bDyv6ewRZraUqQSvOMWb95q0fP40RsAam6fVLWLDekds1 rcWjN2NAmt0Pal+UgyfaBfsM5CsQeT9F/rmLA5XiM/eLtlRk8guP8JMyIaDYsQPT1P5DhugkQEG pz43I5s9gqADeWcNl+6d2OCud316gW2yoVnzPrS3BU/6Gqy3YLlAtfpjj9iPCOdPcJtEB9lwHw6 qgI6AbGQdNDRa9d1pGx+c2KAdnSVfHcoHeeuYUQISVK5n+UXS0AkVkBCbhY0ZWNL7BNfYyNDF8A CAZypkb9CDX7yO+1k/aMIafSl2FqtSqh87Czi/WMD6EWl+zOtrLi1O3n5Tou7MsPF6t6DUlqhM2 jw1kflW0Luso/yMpU9cmvTveFLqPbxetEg2gzbvNprby5q7twDb9nutZ/Q1kE4c6CiCz8b60aqc 15ji+6hg1cD4VzAGYyw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 After adding Clang lock context annotations in rdma.c, Clang reports the following warning when context analysis is enabled: drivers/nvme/host/rdma.c:972:24: warning: passing pointer to variable 'list' requires holding mutex 'nvme_rdma_ctrl_mutex' [-Wthread-safety-pointer] 972 | if (list_empty(&ctrl->list)) | ^ The warning is triggered because ctrl->list is annotated as being protected by nvme_rdma_ctrl_mutex, but list_empty(&ctrl->list) is invoked without holding that mutex. Replace list_empty() with list_empty_careful(), which is intended for lockless inspection of list heads during teardown when no concurrent list modifications are expected. This suppresses the corresponding context analysis warning while preserving the existing behavior. Signed-off-by: Nilay Shroff --- drivers/nvme/host/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index bf392035037a..cdd8837da03a 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -971,7 +971,7 @@ static void nvme_rdma_free_ctrl(struct nvme_ctrl *nctrl) { struct nvme_rdma_ctrl *ctrl = to_rdma_ctrl(nctrl); - if (list_empty(&ctrl->list)) + if (list_empty_careful(&ctrl->list)) goto free_ctrl; mutex_lock(&nvme_rdma_ctrl_mutex); -- 2.53.0