From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D317243148F for ; Mon, 6 Jul 2026 14:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347398; cv=none; b=iVvoDR4uD0zy+Uhmn/WFWczTu1b6zdePSsm/gyFXcwUK3OfB0Dc8lw5s/0Ov7DVaUPxF6pQ793JjPLooCdwKdlJmLUeuWArNEtQk6oRMx3Mu+sOFGj06K3Bf1ujyaFP6tbQSU4IiVGHhrADi4kKY1NkFYTBCAKtJIPpnuJ3931k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347398; c=relaxed/simple; bh=SQYssl+EKWIt/yYFuLAu40YaNGMZGrqV7ZQ3CDdlFV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+C6s2kkP0xZHWIgt+0O1t1QJMPnMWoTIZ+IVGT/fmmbwGfi0ZaAGobedYcucbPQbcMIwRhRbVo5fZiFrvBdAazbk2bXBC6bA0xGbBZxaDwn4lxtTQs4z8XFVARTlN6sczf8LpZKKIct2fLZwx05KFKFzvLeZwRh88RW61DTFnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=rTF5LfPi; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="rTF5LfPi" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666BIjgO4095230; Mon, 6 Jul 2026 14:16:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=vaatYQhQiYTzBO2/i UmWVXdWlKHkVWN0eT8ZSjsZSnQ=; b=rTF5LfPisTmWFE10Sud9WT9QgicZxHZIi LaCpPJteiz1A1CveovJuEGu6uWdQcOwWNAGoaVWMquYd6UdS5WcpM28dVi8sfaT7 2yd9YETapQgtyIzM/Y/9Pl1pdIQawzAQnoKvA1LasQsGq4PjvRxcQ6fLnvDVqRXr vjlmMX9VfvqCbON7LNJvA/ycEn2Ho+0HZe0WpgiKVI/Iv26QspfILPsKCKMkNor1 4LcuwGKK3VJlGDAaq5U6MlQJHqmtWyXtVtArJ7dybJXznHnB/cynXfYbassWF+V+ XiSo/uT5jl7OX0nUOKCTeRSUEwYUAqg9EE0TL57Ba0Kv+S8Ps96rw== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sw4hsup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:16:22 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 666E4diF015305; Mon, 6 Jul 2026 14:16:22 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7eqfwpaq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:16:21 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 666EGIIA26346074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jul 2026 14:16:18 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B36620043; Mon, 6 Jul 2026 14:16:18 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3804E20040; Mon, 6 Jul 2026 14:16:16 +0000 (GMT) Received: from li-a84c74cc-2b13-11b2-a85c-acdd023f0674.bl1-in.ibm.com (unknown [9.123.7.57]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Jul 2026 14:16:16 +0000 (GMT) From: Nilay Shroff To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com, Nilay Shroff Subject: [PATCH v3 17/18] nvme: fix context analysis warning in tcp.c Date: Mon, 6 Jul 2026 19:44:19 +0530 Message-ID: <20260706141452.3008233-18-nilay@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706141452.3008233-1-nilay@linux.ibm.com> References: <20260706141452.3008233-1-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: UibSa194OQV0JQAtMm75Pp2tRi_l2Cu- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXzWkK3ejaE9Wm tEE6oViIZFRA7LfEZweSZ1H5MCxJT2+DTHH2MpbJ6Et+cmbhkesaQK2nSi2VQ9sO666qSf77ZWg 7fX4dISL895TQn+Lh+jTZJAyM8V0xmgvjrFdXue5hWvz4q3LBBQCds+s863Zqvqe/zCp4msDp2z SV6RajNXZrHvemDl7dvbIpUNl9kWfxg0TbvzWXY9gvfuEQ2ExaMFemCp86PNGB05TNSfauDDJbY 3CqboB9PZNrXi0WBAxjzvOPWvuxbx7774Gp9PzvLCyQi6/y7b0UPXZ968jQOzjY47kRDrxkt1Ie zW2lh+t1XRRoZPgWiLu8/dwwhV8dnlozM0vVo4bRDcDm9Mu5NBGzWXZnICt9XZOlEQGBrfIMIfT 4Rj1InJO6ZQAL36ZMEVJgfYA9YA9Ewk2KsN3LM+zwmjuiQl9BszbXijBaaa7sJmqXqLN4Qkoc2Z OD/SFI/XeBnWl+hbbkw== X-Proofpoint-ORIG-GUID: Cz2iLel90qiSwS4JnvNl7jZuFbStvQUA X-Authority-Analysis: v=2.4 cv=FqQ1OWrq c=1 sm=1 tr=0 ts=6a4bb8b7 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=OaIR7dClPEixnHXHKS4A:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX1FStJhx2wEV4 Mdswv34sMCv/WaSJWD5gtUsyICE6OLHWVNR85o1M9OVJx7+B7Ttjm5UkgyTCXJsRNKbNinULtRp sCmswiapJh0C/+cCiL90kBJlN5kUZ+M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 After adding Clang context annotations, compiling tcp.c reports the following warning while context analysis is enabled: drivers/nvme/host/tcp.c:2572:24: warning: passing pointer to variable 'list' requires holding mutex 'nvme_tcp_ctrl_mutex' [-Wthread-safety-pointer] 2572 | if (list_empty(&ctrl->list)) | ^ The above warning is triggered because ctrl->list is guarded with mutex nvme_tcp_ctrl_mutex but when list_empty(&ctrl->list) is invoked it doesn't acquire nvme_tcp_ctrl_mutex. Replace list_empty() with list_empty_careful(), which is intended for lockless inspection of list heads during teardown when no concurrent list modifications are expected. This suppresses the corresponding Clang context analysis warning while preserving the existing behavior. Signed-off-by: Nilay Shroff --- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 8d2fbfc7cd8d..87d8067f3283 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -2579,7 +2579,7 @@ static void nvme_tcp_free_ctrl(struct nvme_ctrl *nctrl) { struct nvme_tcp_ctrl *ctrl = to_tcp_ctrl(nctrl); - if (list_empty(&ctrl->list)) + if (list_empty_careful(&ctrl->list)) goto free_ctrl; mutex_lock(&nvme_tcp_ctrl_mutex); -- 2.53.0