From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0831C3955DE for ; Mon, 6 Jul 2026 14:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347355; cv=none; b=YVIIfSCNpFBBruUnI+5pZlssl0r4yPsHWFBPiilRxtXD4VZzRWrcJx0i7TzCPymuC18JXY2FfRzTqy7C7WXN5szkvJ4Yl3L5uEuAJlaN2SFa5IKFseljAGpM2E2GtU1UE6D2T4qWeEhRQxBGC+IXGe9G9OmldYhbgyRQsd4bI+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347355; c=relaxed/simple; bh=DBPpneQG3eKsHd7bnS4HNzj/2xHFvkDMmaH6lPZpMMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oEFI8Jbw6obkcHZvHtLAovjgTNlo/DyrVdMnP9Apd/HGKb/FFybgXISmd8A8+3vwey1i4w+K0vHZ5s6Q0H4Mm2KpuZzzq4hNXKwxm9dHsQ+VefzQX+0Qlc047+5Cm09H0dP92Al42bA2NvdM2+JDeLBuFkxFD4nLMz9w4WU+kC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=GMmljfwD; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="GMmljfwD" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666BIVrV007960; Mon, 6 Jul 2026 14:15:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=8+M7RExt2GjfkCztu hQCS86rc+iABZUktjOmqv/Izig=; b=GMmljfwDHsfV6XUG053Vrar6VtgTlF5oK 8/lv3yfGFWXgUdPJ4EzSMzZaEGkIxy7W6el5KOaG7Juh/ShZDn2Po8/PWNsINBgM /LbM8/wABPeIwU/D7j27bSz2HsrBwjf92KrTw23BHW0VEaVVtTeKdtoOW3wQRNbV +mPJoi/zDKk0qsG/ys5Nr1GL2bU9sbB0jNPzryo1udSQiT4kvWoB5/aPR+Fv/ZOg wval2lBdgT37chmvuG6TWwVwLL+PATdEIE0qbI1s/4gd9QZ8ms6/r0l9gjv+2dtX wciFkAA2FNbzzGKfGSXd0YF4vFFGwJsawdkGeMDHItK8AQ81pFF/w== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sp3hupb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:15:37 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 666E4md6022950; Mon, 6 Jul 2026 14:15:36 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f7dgjwwym-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:15:36 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 666EFWf151184120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jul 2026 14:15:32 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A21D820043; Mon, 6 Jul 2026 14:15:32 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4ED820040; Mon, 6 Jul 2026 14:15:30 +0000 (GMT) Received: from li-a84c74cc-2b13-11b2-a85c-acdd023f0674.bl1-in.ibm.com (unknown [9.123.7.57]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Jul 2026 14:15:30 +0000 (GMT) From: Nilay Shroff To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com, Nilay Shroff Subject: [PATCH v3 02/18] nvme: add context annotations for nvme_passthru_{start|stop} Date: Mon, 6 Jul 2026 19:44:04 +0530 Message-ID: <20260706141452.3008233-3-nilay@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706141452.3008233-1-nilay@linux.ibm.com> References: <20260706141452.3008233-1-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=KsJ9H2WN c=1 sm=1 tr=0 ts=6a4bb88a cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=7bgEqNGeQr-mGYOCYikA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX3DhLNUADekyb c+E+vut1CcNkNUZiw/+R43R4hvqsOeYjuCLhpOjPu6VCShiX2ob1hTAQz1lBUs2o5IBOnGukw8x zlqzYTCNfDTg2OoS0P/cdhOsO+IaMWI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX5Suw+LQYMwh9 cpuL6lKyPQitLyNOW2mkUGKbHAVcwvVr+i0eUj5LYcYIdwyqbL1LwjK/7najg/4VfLZkXFw8WUM UgS1qXbG/Lmuvprfd1jGPEkBmvNaeGkuNVE/+iIVicm6wrJQWXLKNmX14s0H8CGcVwOuezBudbs C36gvDwCpsEazUWJZHi4WPVDk6Tl24zjOLx5eKjE8yNTPfOw6Qh7It5nTb32W3v5YR1CxmHeScf 7fedVP9lMY16DTw/ooALMjqBPVFbtfD7NFX3X3pgM6LFyhh/LeGlcmSGzfgssuC5ayghcgimtYJ 3CwUga4SSQSP56wp/Xy4f4TPE5odIG7f8AknVcHzWSbtM+qA3OR7fh7VjqWXHyfReAsfQTYqXb+ ssIgo5kJvslZASTdP2KV5kGurX1VxBtxAz/7h4PpQpvkKQ1EplysmQdKbAVUCFeP7UKsFiwn89G ylvdbjsAPiOVi5Ck5cA== X-Proofpoint-ORIG-GUID: WdYfRW52j4qqsMfb-64ctPV4Rd_ej2Ed X-Proofpoint-GUID: v5wzHTPuFr5epWPcT5AebVxzsAQmZ-0h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Annotate nvme_passthru_start() and nvme_passthru_end() for Clang context/thread-safety analysis. The __cond_acquires() and __cond_releases() annotations model conditional lock acquisition and release based on a function's return value. Use a nonzero return value as the abstract condition denoting that the associated locks have been acquired or released. This allows the analyzer to track the lock state across the nvme_passthru_start() / nvme_passthru_end() pair and verify correct locking semantics. Reviewed-by: Christoph Hellwig Signed-off-by: Nilay Shroff --- drivers/nvme/host/nvme.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 0797c3a6a9c1..fba2d7674623 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -1290,10 +1290,16 @@ static inline void nvme_auth_revoke_tls_key(struct nvme_ctrl *ctrl) {}; u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode); -u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode); +u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode) + __cond_acquires(nonzero, &ctrl->subsys->lock) + __cond_acquires(nonzero, &ctrl->scan_lock); + int nvme_execute_rq(struct request *rq, bool at_head); u32 nvme_passthru_end(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u32 effects, - struct nvme_command *cmd, int status); + struct nvme_command *cmd, int status) + __cond_releases(nonzero, &ctrl->scan_lock) + __cond_releases(nonzero, &ctrl->subsys->lock); + struct nvme_ctrl *nvme_ctrl_from_file(struct file *file); struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid); bool nvme_get_ns(struct nvme_ns *ns); -- 2.53.0