From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07BA2423784 for ; Mon, 6 Jul 2026 14:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347370; cv=none; b=FrGRgs76r3kRCnSS6eyTPtlESYZ1S3fLZS+y06in3JSUdRwz3c/Uk36mKPl58ZsMen08cZI1uepz7Zc78H/xHWHPqenP2t7cGBgR7JG2kFQ5JGkC/bsHSJVZQJ3QvKFszvU+b42pa1qiacGaVPJIATcLIODNU1SzlYqlB9ZLdEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783347370; c=relaxed/simple; bh=nnMyAitwlMPfSa1KgE5WB1T8ODSsAVUA3xaECxi//Mc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xr55fvX0+JftC+lkvFEBeHN0ECrn8SWTd5UBfkoo0/lEFI3lMMMZZBOg1Wn3rmmKJjl/i4IieRCV3FleQQ2i86ctaNRBfPdV40QDrL/c82/WoiSal9JWS8V9azPDevcyzbvyGE/MCEodoU5MohNl5bKe7Sl2ZHwhMXU2rnF/A3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=eiLlhHK0; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="eiLlhHK0" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666BIQ4A3465302; Mon, 6 Jul 2026 14:15:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=EQ/135VJVeLMIERaY ABh/o2+dfGg4dSPAPpzTXu39NQ=; b=eiLlhHK0LSeHsG2TjzC8cH4QMzD1R8o0A y3FCjXiHnz+FS9DB0AwhFXUXxVvUkOYUM741i/RGo6X6yrO5UdDzh75eiXlUPoji swzO7QIHcqRQtuIlqFsnrjptjEccnj9VU54a0IWHJczUbC4YfY5/8Qo++aKwhbzU aCDoFFhq6AH3IkMcs5uTG7l7usgu0FSjR0J3LVj+TS9jHlnfvZCYNiOfMrgiDK1Y g+OV7XO2Ck99YvfROJQs139RGMH9MyKiLzuvMEcGqSvTHjDeohsTii0SXjpW15bR U+e48jyL1I1uQ8IkpAUoiZ66EMKE6hUG7RV//9AN9RnaqQ02o12Sw== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6rkdjexj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:15:55 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 666E4i9W024780; Mon, 6 Jul 2026 14:15:54 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7f6xwk1b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 14:15:54 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 666EFoGd13500878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jul 2026 14:15:50 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D9B820043; Mon, 6 Jul 2026 14:15:50 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 613D220040; Mon, 6 Jul 2026 14:15:48 +0000 (GMT) Received: from li-a84c74cc-2b13-11b2-a85c-acdd023f0674.bl1-in.ibm.com (unknown [9.123.7.57]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Jul 2026 14:15:48 +0000 (GMT) From: Nilay Shroff To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com, Nilay Shroff Subject: [PATCH v3 06/18] nvme: add context annotations for nvme_dev::shutdown_lock Date: Mon, 6 Jul 2026 19:44:08 +0530 Message-ID: <20260706141452.3008233-7-nilay@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706141452.3008233-1-nilay@linux.ibm.com> References: <20260706141452.3008233-1-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=M7J97Sws c=1 sm=1 tr=0 ts=6a4bb89b cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=lhRNW2dt6MhivXYX8oYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX39034UtxugBW p+JgwH0eXdguv9g+nkBpS+kLd4O9uwanUziJcWp2s9Q3ddg3PfR1FefKBsoptmv0OmfrYoz/t4I MU5yRzUJY4/i8DSSy/zGgxI51dzJh4usWrnzxn1x+CmQBCRnHcjZb+406PiReZs3a7Hlfikxiqq hNEAjPgJvWp7mUqoHcfgfU+ebny8QieImGp8EfumphHzmY+ry0F/zReOKaU9aPSdWogYG8FEijw 4hJ16LGNWgQmlf2lOK/jvMf7keFqtE4aBplJx/KoHG3KAFfhRR1/8u46tcNKxi4Dqb9qN4rlArH 5p6xxpAaSirsCpKClI/DEmSIawZteFX5jLKwgzQFD16gtsYgVsgPKIbko8CGd3aNHJQqCN1dySC aABOBXXiUnDrYmCSU9qOYEQiZEel3+XXWV1TwUJhFwiBbjgyWI5w2MO8PHieXtmNK85PGS9niCt Y64DfnA1afL/rbgWvJg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX2uTL7q1lKnb3 UDnSFuf5CNZTNXWyuzJkHn8I2554X7fRsXgeDSI/y6DxdKfw76K4OkyGUH65R7DDC9c+LZ4PflB tVSBnpbr8q3WMlQ8M+uQGEmlc2CslYM= X-Proofpoint-GUID: f3312v65kP1pvXXiPuuScJ666RNovmk8 X-Proofpoint-ORIG-GUID: 0pH80USSrJ6Kqpw93Kq-D9bBMu9xCAVg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 nvme_setup_io_queues_trylock() conditionally acquires dev->shutdown_lock using mutex_trylock(). The function returns 0 when the lock is successfully acquired and a negative error code otherwise. Annotate the function with __cond_acquires(0, &dev->shutdown_lock) so that Clang's lock context analysis can track the lock state based on the return value and verify correct lock usage at call sites. Reviewed-by: Christoph Hellwig Signed-off-by: Nilay Shroff --- drivers/nvme/host/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 69932d640b53..7954417d1252 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2199,6 +2199,7 @@ static void nvme_init_queue(struct nvme_queue *nvmeq, u16 qid) * Try getting shutdown_lock while setting up IO queues. */ static int nvme_setup_io_queues_trylock(struct nvme_dev *dev) + __cond_acquires(0, &dev->shutdown_lock) { /* * Give up if the lock is being held by nvme_dev_disable. -- 2.53.0