From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC0343031E for ; Mon, 6 Jul 2026 16:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783354124; cv=none; b=ZyDeIWKLhH+/Ac1K7f4DerYzvwjYPmnBy8XwEswcVSHn6QRrIfwGSn4WW0wlWTqnSDKgjYPcXjX8+oATKbmSHK9wttVS02D1vF9kOK27W9act/d2kpKZV+n5wkkr4EDtGz08c6iJWo6TJq5aLmQ5tXxvP/ow6Rzgi30fucdAVVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783354124; c=relaxed/simple; bh=aBJe19napSs6kyYETHjwpmtrLIRAU1o0VhwqTbuWJL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uuU1QKL6XF1qB2ZrfE5RlBRZ90C2AnnmfpYfVVQyyXZv2WEG4VgkL5JPHH+15Rz5hM8r1lE0u8CSPpGtpxkmLaC/UCz9gxDu1WSysnFOWyivucIKYO1h/FrEH/DjiPPBbrK99VP9eLqD0KTEuG9ocv9V7YIUCagMPwkGqy96BLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PI8sTfGj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B9YUY2Iu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PI8sTfGj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B9YUY2Iu" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666FF5Bn825893 for ; Mon, 6 Jul 2026 16:08:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wgArOPJwbc+ DaWtG2tIECGMzRP1R/wtS6y7TeRFG/58=; b=PI8sTfGjNskLcLv8po2SkXPqFNe B5qj3LKDL7MZ6jtT60pf0A7+hgt5xsYHjV/yXYbsOEMkIlbcmkGCoLlJ3doGdx4O 1t21ybT9svpsiOtx34oR4qBgvMirMUw47QHOswcIbnuv2g+fjXhJ4oVliQZCE5Ou yql4RgFLJ3UyRPanu/HqHTI+YKpyZKcKPNVTAZNipFnT2MuQzzOrCPrldGG6Wnal BkBjsf9V8LEYToAr681yj1cHAWZWYBwayKO6Ue3jdOmSUeqsvCgem3tGcRB/Dcaw 6J4smeiyz9Ah4l7YsfEiN1lV9Hb/kIfxHoEbyHchyPZ9LGBRTDdVyq24OcA== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88t8a2gm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 16:08:42 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5bd7905b135so737519e0c.1 for ; Mon, 06 Jul 2026 09:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783354121; x=1783958921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wgArOPJwbc+DaWtG2tIECGMzRP1R/wtS6y7TeRFG/58=; b=B9YUY2IuRk4Ts3DchCSO8dmWvdmC7EPz2qnvc61TNJXWywi71+3Hc+dhfK/yAgTCxa /RdkmCVg0TRJUriEUq+ZOEAo43xtlYnBHKGO+Vgb9GYfiNW9qX2TfvLthSn0w2tSUVUb Zc/ywaFTUgCfmlz50dIEGfcnrojsbOChcMZLN0KZTT2st7gePwwJgxLq9H2Ho4KQ9q2Q 2F8X/g53c55E2qI8l4KrIcLyWWtXTHF2QBoEnWYubhVxYBN/MSpuki4o4uwVUDHeq5vf BIPIgg/radOQTD6PrP0ear9whnjfK9VoI3Uh2pWt2OUKrjkvmKP6bI56LVRlvnQLTQEc zt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783354121; x=1783958921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wgArOPJwbc+DaWtG2tIECGMzRP1R/wtS6y7TeRFG/58=; b=aGntEEu8doe/HREz+W9HK665QIlUVJalPC08SLuAV0kaakGBgATDhvbA4584OUW9AZ 7bALkmLuNYtd1yt9r4maCZhdSyk95pDeE453nG89m7zWqdScX+UKpe1A28zyJMsIbN/7 EjI7ZEF1Nili1jOqDtnP9zgb6fG3Ret9zGf89o70iTjnTqRIsQg0xmVKaN4k8nl9VzhI f2wgC2RA4qoCt0JSArrIBRQ7AfBCZurEhRly6ZR+/+UodiTf14hxuRdmxpXAoa994+X6 T7OkQU/ciJQH4kaO/LsOf87LmfXQ/J2FpnOWbaDXRd9wKM/xGgOG25Tc5Gup+8/Q2myH GGCA== X-Forwarded-Encrypted: i=1; AHgh+RrkNTPhUqnGXFtUQavbh6D0hD6WWHkbFMrdcskpxf1UkpE5OG7KqeQaZ4tFo/kd7g125B5xcfNQP502kSc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpkM1LzWJlzmvYoIN8ndNDWssDBKWCnpn4J3o8V+AG1ciW+EwA Q3Kz5DreN0rAxvFgdEbzHCRhOIR+4Nz49z0Yg9/UzWTsmd3rurtQXwQHZ+UXkm3l5Uz1FCju95F 8FaRfbiWD/BlH+yPdHTZ9K0I6ELVUKz+HCsddXlKFnCXRhC+S19cYnQXZ7pqiYcR/8lc= X-Gm-Gg: AfdE7cmdVKi6ukYhhfASv00HuRRxy88rF1u3N60z8tEtMUqFI9VktmW6qNHUbP1E69D fFwNH0ko+w3WRM1z6r19ioMShaPS8o9opLVf6Xk8dwSP7cBu+R8U/zxw9tUjpCa2SDH3E5hY+pJ 2/lw/expSPKnijvMxzGF54DGbvM+MLkMIhq0nNynAhCWcmko2l5sJExv18/80jJbkxiRyn34BxJ kDUYU5HhC9xyESu53aoMwcGz9dVMIjuX2+QKfkd4NIFDltvXAHtNpxVtYQSijR1u4bZpA4X6xvw fsTAHFT/tEQYg2gjNbciotRzrDS3jNXhELsFS+HvAfLaB9qlFa90luddIu3BikOETRAhe85wxrW +0PZumuos2dEtLuJ9mihra48qFAZpVhwIVnmrXNGydk8LYA== X-Received: by 2002:a05:6122:1793:b0:5bd:fc20:b7ed with SMTP id 71dfb90a1353d-5be90755ccfmr681038e0c.7.1783354121118; Mon, 06 Jul 2026 09:08:41 -0700 (PDT) X-Received: by 2002:a05:6122:1793:b0:5bd:fc20:b7ed with SMTP id 71dfb90a1353d-5be90755ccfmr680797e0c.7.1783354119220; Mon, 06 Jul 2026 09:08:39 -0700 (PDT) Received: from juillet.box.freepro.com ([2a05:6e02:1041:c10:8405:4a9c:95fc:4b8f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e3e2702sm26071966f8f.9.2026.07.06.09.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 09:08:38 -0700 (PDT) From: Daniel Lezcano To: sre@kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@roeck-us.net, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, gaurav.kohli@oss.qualcomm.com, manaf.pallikunhi@oss.qualcomm.com, priyansh.jain@oss.qualcomm.com Subject: [PATCH v4 1/2] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures Date: Mon, 6 Jul 2026 18:08:28 +0200 Message-ID: <20260706160830.17698-2-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706160830.17698-1-daniel.lezcano@oss.qualcomm.com> References: <20260706160830.17698-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE2NCBTYWx0ZWRfX4wwSmgD1mpSH yzGMDSRSlcsjnI91Dq3BbWKUeAqKm/eniA5wSQp0EDOcSzSCW9PFXtXo65eScxOLemVGFySm7x2 RvnzWh51tg/HRcmr0YF8EIxVeAnI7zA= X-Proofpoint-GUID: ne8-R0MWghWmwv82I1j1dgbazpoISUbh X-Authority-Analysis: v=2.4 cv=C6zZDwP+ c=1 sm=1 tr=0 ts=6a4bd30a cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=9Fj74KSAFJAma6AI3IUA:9 a=vmgOmaN-Xu0dpDh8OwbV:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ne8-R0MWghWmwv82I1j1dgbazpoISUbh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE2NCBTYWx0ZWRfX8Kv4TmDEqaw3 TQD420KDlZBmREYHM64YSrJHFflaeh0IBz0VKpPH8KobeDy6+q6HtYXjcQojS7FTV0y5h1FnVDo sTeMhfI2j4apjmCAeKlLYeXhEAWsJFjNnyI1hctVSmoTArJFJYQbadmBuIZtjtuWXyFsg78Y3bb 6kmkrZiFvfJp5WDtRlVmSgYcC0Vdox/ez53tDmi/nX3Z4tzILp9ra1F/UnADIHknq3d97YjxLFb bYJLVy4A0//AXP03FydvXlKR+SzAs0FStCxvqLcGHy5ZS7XwJn7vlX9PDMQTCys8fDB0ZO8mGo2 ZWQMocyjktHxGHyHjSQJNFQMdp+rUqa6SlMG2QjxNjBD4ZxXKBLDlWKCuL9quLkKHjlXDvtkEQE 9DOVM6vqVcBPdRT2M50QeOfAVawiCzbItyjZ30HzSLlIaaf24YcLkCqXwwkK/VdfjXxtOQWQNDP 12MV+EPUIc5pwy5d/cw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060164 Expose the Lenovo ThinkPad T14s EC environmental sensors through the hwmon subsystem. The driver now registers a hwmon device providing access to six EC temperature sensors corresponding to the SoC, keyboard area, base cover, PMIC/charging circuitry, QTM module and SSD. Sensor labels are exported to allow user space to identify each measurement. This allows standard monitoring tools such as lm-sensors to report platform temperatures. Tested-by: Neil Armstrong # on T14s OLED Signed-off-by: Daniel Lezcano daniel.lezcano@oss.qualcomm.com --- drivers/platform/arm64/Kconfig | 1 + drivers/platform/arm64/lenovo-thinkpad-t14s.c | 131 ++++++++++++++++++ 2 files changed, 132 insertions(+) diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig index 10f905d7d6bf..121043348740 100644 --- a/drivers/platform/arm64/Kconfig +++ b/drivers/platform/arm64/Kconfig @@ -75,6 +75,7 @@ config EC_LENOVO_THINKPAD_T14S depends on ARCH_QCOM || COMPILE_TEST depends on I2C depends on INPUT + depends on HWMON select INPUT_SPARSEKMAP select LEDS_CLASS select NEW_LEDS diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c index 5590302a5694..fc480f093238 100644 --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -21,6 +22,7 @@ #include #include #include +#include #define T14S_EC_CMD_ECRD 0x02 #define T14S_EC_CMD_ECWR 0x03 @@ -67,6 +69,13 @@ #define T14S_EC_EVT_KEY_FN_F11 0x7a #define T14S_EC_EVT_KEY_FN_G 0x7e +#define T14S_EC_SYS_THERM0 0x78 /* SoC (CPU+GPU) */ +#define T14S_EC_SYS_THERM1 0x79 /* Keyboard */ +#define T14S_EC_SYS_THERM2 0x7a /* Back cover */ +#define T14S_EC_SYS_THERM3 0x7b /* Charger / PMIC */ +#define T14S_EC_SYS_THERM6 0x7c /* QTM West */ +#define T14S_EC_SYS_THERM7 0x7d /* SSD */ + /* Hardware LED blink rate is 1 Hz (500ms off, 500ms on) */ #define T14S_EC_BLINK_RATE_ON_OFF_MS 500 @@ -93,9 +102,19 @@ struct t14s_ec_led_classdev { struct t14s_ec *ec; }; +struct t14s_ec_hwmon_sys_thermx { + const char *label; + int reg; +}; + +struct t14s_ec_hwmon { + struct t14s_ec_hwmon_sys_thermx *sys_thermx; +}; + struct t14s_ec { struct regmap *regmap; struct device *dev; + struct t14s_ec_hwmon ec_hwmon; struct t14s_ec_led_classdev led_pwr_btn; struct t14s_ec_led_classdev led_chrg_orange; struct t14s_ec_led_classdev led_chrg_white; @@ -555,6 +574,114 @@ static irqreturn_t t14s_ec_irq_handler(int irq, void *data) return IRQ_HANDLED; } +static umode_t t14s_ec_hwmon_is_visible(const void *drvdata, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + switch (type) { + case hwmon_temp: + if (attr == hwmon_temp_input || + attr == hwmon_temp_label) + return 0444; + break; + default: + return 0; + } + + return 0; +} + +static int t14s_ec_hwmon_read_string(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, const char **str) +{ + struct t14s_ec *ec = dev_get_drvdata(dev); + + switch (type) { + case hwmon_temp: + if (attr == hwmon_temp_label) { + *str = ec->ec_hwmon.sys_thermx[channel].label; + return 0; + } + break; + default: + return -EOPNOTSUPP; + } + + return -EOPNOTSUPP; +} + +static int t14s_ec_hwmon_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) +{ + struct t14s_ec *ec = dev_get_drvdata(dev); + unsigned int value; + int ret; + + switch (type) { + case hwmon_temp: + if (attr == hwmon_temp_input) { + ret = t14s_ec_read(ec, ec->ec_hwmon.sys_thermx[channel].reg, &value); + if (ret) + return ret; + *val = value * MILLIDEGREE_PER_DEGREE; + + return 0; + } + break; + default: + return -EOPNOTSUPP; + } + + return -EOPNOTSUPP; +} + +static const struct hwmon_ops t14s_ec_hwmon_ops = { + .is_visible = t14s_ec_hwmon_is_visible, + .read = t14s_ec_hwmon_read, + .read_string = t14s_ec_hwmon_read_string, +}; + +static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = { + HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ), + HWMON_CHANNEL_INFO(temp, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL, + HWMON_T_INPUT | HWMON_T_LABEL), + NULL +}; + +static const struct hwmon_chip_info t14s_ec_chip_info = { + .ops = &t14s_ec_hwmon_ops, + .info = t14s_ec_hwmon_info, +}; + +static int t14s_ec_hwmon_probe(struct t14s_ec *ec) +{ + struct device *dev; + struct t14s_ec_hwmon_sys_thermx sys_thermx[] = { + { .label = "soc", .reg = T14S_EC_SYS_THERM0 }, + { .label = "keyboard", .reg = T14S_EC_SYS_THERM1 }, + { .label = "base", .reg = T14S_EC_SYS_THERM2 }, + { .label = "charging", .reg = T14S_EC_SYS_THERM3 }, + { .label = "qtm", .reg = T14S_EC_SYS_THERM6 }, + { .label = "ssd", .reg = T14S_EC_SYS_THERM7 }, + }; + + ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx, + ARRAY_SIZE(sys_thermx), + sizeof(sys_thermx[0]), GFP_KERNEL); + if (!ec->ec_hwmon.sys_thermx) + return -ENOMEM; + + dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec, + &t14s_ec_chip_info, NULL); + + return PTR_ERR_OR_ZERO(dev); +} + static int t14s_ec_probe(struct i2c_client *client) { struct device *dev = &client->dev; @@ -590,6 +717,10 @@ static int t14s_ec_probe(struct i2c_client *client) if (ret < 0) return ret; + ret = t14s_ec_hwmon_probe(ec); + if (ret < 0) + return ret; + ret = devm_request_threaded_irq(dev, client->irq, NULL, t14s_ec_irq_handler, IRQF_ONESHOT, dev_name(dev), ec); -- 2.53.0