From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CEC5220687 for ; Mon, 6 Jul 2026 16:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355930; cv=none; b=gx/Bivm1nLw4nPjuEKOW3OgL8bbFFnnRUv0weBUeqAOy4mQq0MsfcCCGBpQUUdH1ECSan5Fme1MbXyXXoCdiw7O6xqz1c2TW3ypDMr8cJbnZezTSJfV8iXb/L6mJQ7xKwzbMukTZZKhw5AqLtQSwf5+wytRLNubKWPmnusTF238= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355930; c=relaxed/simple; bh=7bWL7uUaWVpjOFK7KGND3N73dvQqoB8oILQDZFP/+NA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lgyy8Q1KmPnuFj6HD/xryzRk99dtJmfwVJ9k9eaIsNFfHYuw836JOclKEQpI76MqU/5vpSa0/x2dt0+cpXJq2dQfyu7AE+zPcekOTliOcC7/q6R55AP+M8IgB8XViw2fexIl7yEj3PfGEfsJIU5m/kQKJqZx1YvCCNLnq4Bah3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J03ESv0C; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J03ESv0C" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cacd69a9c0so27392025ad.1 for ; Mon, 06 Jul 2026 09:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783355928; x=1783960728; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KEi1MjXj+z1W6jRPKa6Or+XS7xlVkfSz1SFMtHSjLrM=; b=J03ESv0CjVQwiMwmfVEF/nefPeqfbheZKmJcBfacY49Vi325jzNDJgq1hwk2tDbnMY Eazg/SJ+X6lsj1VXbd+Nqrozyl8h8aXMfJeCOWZY4Wc3B7V7H77AVCG1H7Elt2E6wt3x pEImyTfUInVtDI7ccFKGXvjkA+shOn7j4lT7rum7J6kDZtvgIPwv44ePyeGtT2u46/vU 9uE1MOLYPd4cJ/ntanG5TfkQL8fgIVWzfJoKHsJXt82WgiD5aptWtjgxDzj7ei/2YQZS vIDVP7fO3dtaqrVm6HTFzlpbMF1MdBh+QxPqs/pyyRARvT30jErKUL3/lmVT5e9Lc/zP U3uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783355928; x=1783960728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=KEi1MjXj+z1W6jRPKa6Or+XS7xlVkfSz1SFMtHSjLrM=; b=ewMAKIUYG2Btw0Jj/8sqy0JUqZJ8GqsNVdOjfWEIAw75JLZVUr1rxBQvJnt4MiKoMW 0L63DqUdVb+cQmkrAFVsdnGoXAkYDW5xaO4qwVuBmpYDAigcyOVbExBaPhSXCzAq+8Qi 1uMmH7d9CNv61Wbh0b36KQaVRHVvm+43pP/oVhwOQYkOaFp7BL8zX+RqjM/kF3ST1Ddc NIAGvAOg7onADSxUoydTODTaLDHgVaeLspAD+6UXJITuRb0mcWAfsACChe+0DGDQUtTu wb7qhp6hOL+X1YMJ0MoNSWFA2NpKxFNWxxbGm0EwnBlNEkqQCO42qNSFHbRtXh1NR7Lb LMHg== X-Forwarded-Encrypted: i=1; AHgh+RqZNNOGubrgHBNQ9JUVqkrrzU3U9zQDSFjjQh/DtpU6u3uBzfHTMXM0IcQr0VvJ5FlMmwWGRm5CM+GGJPU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtv/JK7n5c1SAHpfrHm7XMU7riIBWl/dGw/JVNdsVgJwEXomcK bGDjlMr2hYY25+yGvlwIgFeLRQaOQIXa+lS5lbiU3W4iNwMEsFR8LWCF X-Gm-Gg: AfdE7clpK+r0+WbNE9J+ZBV2XmIOat32zoUza8Il08YN4fdsrmZ2QXd+4f7F+tDJtfG okaC0qHv90PRQ9K2PCokgVsNo6CIUbQ+W+Rmjx01m/6guiUO/OIxxdgOzuoGpwu8yTJ/O65sJ2o PingVJrCFQ+mnLROF5i2kvzdTbsciReP1ymITIUYB2rl4IGAxisT1fxLqijvWUH0e5OSXpVE6XF 2lc6MXCHswGe+qmse5Acq4rJ4zr4HQTs9zzpSl7uu+Y6mVoqmifQloxxpMIqVBz3UpyDTzJGKIO sbkZiygIZ5bHwkobfJ6IYlgGwuqTUwYjYyspEDyC1Ze3U/GRv2ekxU1YK8uxywCtoz3UjJxVtpd Y3N7DEbgur+wxhXNqNwatg2FopwcLudEjD5JBIEU4zIVB59JJyfdOLVwPIadtoUMvZSECttTQtz llsUKC9SQ= X-Received: by 2002:a17:903:37c3:b0:2c9:854c:a45c with SMTP id d9443c01a7336-2ccbf04371amr14923415ad.34.1783355928162; Mon, 06 Jul 2026 09:38:48 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7893a8dsm53103305ad.73.2026.07.06.09.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 09:38:47 -0700 (PDT) From: Sang-Heon Jeon To: rppt@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Cc: linux-mm@kvack.org, Sang-Heon Jeon , Ard Biesheuvel , Chris Zankel , "H. Peter Anvin" , John Paul Adrian Glaubitz , linux-kernel@vger.kernel.org, Madhavan Srinivasan , Max Filippov , Michael Ellerman , Rich Felker , x86@kernel.org, Yoshinori Sato Subject: [PATCH v2 1/5] x86/setup: remove unreachable memblock_reserve() return value check Date: Tue, 7 Jul 2026 01:37:49 +0900 Message-ID: <20260706163753.193875-2-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com> References: <20260706163753.193875-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit trim_snb_memory() runs from early_reserve_memory() in setup_arch(), before e820__memblock_setup() calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value check is unreachable, so remove it and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/x86/kernel/setup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 46882ce79c3a..f9395bc632ca 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -742,11 +742,8 @@ static void __init trim_snb_memory(void) * setup_arch(), so there is no need to reserve it here. */ - for (i = 0; i < ARRAY_SIZE(bad_pages); i++) { - if (memblock_reserve(bad_pages[i], PAGE_SIZE)) - printk(KERN_WARNING "failed to reserve 0x%08lx\n", - bad_pages[i]); - } + for (i = 0; i < ARRAY_SIZE(bad_pages); i++) + memblock_reserve(bad_pages[i], PAGE_SIZE); } static void __init trim_bios_range(void) -- 2.43.0