From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22448434E25 for ; Mon, 6 Jul 2026 16:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355935; cv=none; b=OXRuqToPUkW8rIRxoxk1+yaczpOXp30m540uH4NnbZVK/D4OMhSrBfN9GZEBfg7P18qR2TDAPZGJIigL61ZrUZ3YdK0yNTKwmhTo8WXS1NsuSPYcpo8m3UblQ+KqQ8OB7Dtu1x9hjljvWS36Zi/HqfNjSA4ibJm1nHneY4iB3uA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355935; c=relaxed/simple; bh=dybo8/HrHeGrJGasUpHRaqT8xbB02VCrzfApuMlEzCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E0Gwxr4z4fJCX2yzRmRD+v8Rr3AAMSbRIW/UTLrCrFG7NorqARe2emZgLwX98P1GQaP+79fkM9o/fGa6OZ8WacTSidp1x9N/u6Pcpp45Qgkb3doSayINs7alfhpbx8YrRdaM6Inmv9EA/L0I8L2Brmb+iExgOBQoHV2su7jOmFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lne6RAzV; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lne6RAzV" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caea3f742bso44522775ad.0 for ; Mon, 06 Jul 2026 09:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783355933; x=1783960733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VtnXNaxn+fspW0Xw1nKXB6TGSGdVBv01OAGdj8wNpN0=; b=lne6RAzV+cu2p2JVqlwsZIbYdda0Uvb726LljdYmoOwSncBxXb4br7ZAiZ0nL/E0q9 pPaN9JgblE/CEVoX0vqT565Qg/BQJe776U0RjO2eLuVvLkbwKBQr5waiNBQ3y7F0qwQX xOcLPBKVYYQhglMMjwVT+IWUrKvaLMR3w5Ipd3DM/IuXi+aBguHWwetJlHcd3qFtoGGA HUbwuPiuLEP7zW8hwoWchJk2mKYpCvDuhIVOpCVl23LtDXqETO6QiDQMRsYdf75P0R+W aYjuK8ljitHUMQtswBzxOsCgQKr4A8Z/4TkGytMrJcOf8LSyIFtrY1YUEhJAE/7W/yLY 3HjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783355933; x=1783960733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VtnXNaxn+fspW0Xw1nKXB6TGSGdVBv01OAGdj8wNpN0=; b=CAu1o9pkb8dZVDp1+XE0P8aKZugs8BwG39erPQyP4jVy3ugnYpowi8qQUAp4N3lzYQ r0cfPd69xUo/iIrujUP93KkrWfU7IuWcffgUtx87RbhxFiTIwGaHhyD1v65Br/vIIgg4 6xoOK978VhaXQCs9GHoZFEWxcNFAFLezRlvg/qYcipNfL0+e+A28PtLExXRhDljbGGVK zj4nZmaIisJ/6xcvZoTZ8aB4qqeI3MjBBozZKnQgRIeyES+bdXZViDt+M9Pft/skdeLt GBYgrsiPoRUdv4Dhqi8EB5PKD2uQWnsRFFxr/qqfwVoJy1NhvKeKizK+pk7kdzhwP4eU YRUQ== X-Forwarded-Encrypted: i=1; AHgh+Rr77Bt5S8umcNVEQZon6FucFpCKouLasIl1euf6MmD38peBkieCPEol7i28KHK6QEKcdD6mEgIsDM20V1Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1rtJlkNAhYJg6druOOoMv9sRi5VAg75KSgGKF/+5GORBaf6iZ YqtoLsbMEpSWI5CXdX74YHO/+AAXioeh6mawyTAhyerHzhoyWh/uOYq7 X-Gm-Gg: AfdE7cmA9g8shmDy/MOOE0xk5WMpZx5+sL1oV+D8h0LFf0Nm9FLQwfrBrWFctnqWsSE 2k4smdZvcUHMedX5VsP8JV1MrIWucbZIf0yNjOkfCm6VaZ+6GngLTDx9F2YMe/SQvdkNWf7p3pN VG6oyF7kqGdicMvH6lhLH7yBo689fzcT9n0jkzatbFQbUVc+84DIIS8S6kZV8HEf/6HRnBYqawE fKW8u4mJ0hlNWE3wwa3bBvAjNKitjf13zlVy3gdZTc28f61ek8WFRvXww2fK1Yp+BW1l5m/lnAw nrrhida8I1lsaYi3SqZDqSX4R31e6fW176gQaHuaucMAgk1724EG7Sd6OtEnecfZs5iuSf6b+aF cpPxfqqehdY4o8kZ7bbjTQsO2O3CLuQFrqBBX00wSoevorPnus7AQB064NcoXK6vypAuqdAHCsg VgZxvaS5s= X-Received: by 2002:a17:902:d486:b0:2c7:fae7:8af with SMTP id d9443c01a7336-2ccbf0105bdmr14950715ad.24.1783355933532; Mon, 06 Jul 2026 09:38:53 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7893a8dsm53103305ad.73.2026.07.06.09.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 09:38:53 -0700 (PDT) From: Sang-Heon Jeon To: rppt@kernel.org, Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: linux-mm@kvack.org, Sang-Heon Jeon , Ard Biesheuvel , Borislav Petkov , Chris Zankel , Dave Hansen , Ingo Molnar , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Madhavan Srinivasan , Max Filippov , Michael Ellerman , Thomas Gleixner Subject: [PATCH v2 2/5] sh: remove unreachable memblock_reserve() return value check Date: Tue, 7 Jul 2026 01:37:50 +0900 Message-ID: <20260706163753.193875-3-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com> References: <20260706163753.193875-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit reserve_crashkernel() runs from early_reserve_mem() in paging_init(), before the same function calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value check is unreachable, so remove it and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/sh/kernel/machine_kexec.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/sh/kernel/machine_kexec.c b/arch/sh/kernel/machine_kexec.c index 37073ca1e0ad..ba9c412f14d9 100644 --- a/arch/sh/kernel/machine_kexec.c +++ b/arch/sh/kernel/machine_kexec.c @@ -165,12 +165,7 @@ void __init reserve_crashkernel(void) goto disable; } } else { - ret = memblock_reserve(crashk_res.start, crash_size); - if (unlikely(ret < 0)) { - pr_err("crashkernel reservation failed - " - "memory is in use\n"); - goto disable; - } + memblock_reserve(crashk_res.start, crash_size); } crashk_res.end = crashk_res.start + crash_size - 1; -- 2.43.0