From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B3335AC24 for ; Mon, 6 Jul 2026 16:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355940; cv=none; b=O+pujUmuzkxvL3cDgE0p66RDWW0mWJU9j3+gxRv5+w9v2G8FsdTE/Gg5nc0+s26t7GWtBzkxjmY/LDKqFG2GlQIrVsLYkmLHpMcMVyNonAB1nturbJVUV+O3pz1aIg3DpRa6+MAnlob4TipnQecGoqtJkEJ89cMNQDYT8tiViMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355940; c=relaxed/simple; bh=6tZeQREoP1ofXRtRZ/JQ7UQ9t4y1lXOhInIr+Flzrw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fcRq9PVQSvifqDFji7Tvw8tEj5e2qK8JngHl9LGCIh/c679gDh1WMSvDOIYfHsNQAG3utyXKcY/O8zMfjAtEedoE9kFJ4OW0FhQ0m2qOZpt7OYG05Btn78jXzvPErxodC8IMfAMy8kUUgfyXIqbbUWuC3zqs95fAgQrB37IOehs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d5xuHBNm; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d5xuHBNm" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc61541f8cso273895ad.0 for ; Mon, 06 Jul 2026 09:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783355939; x=1783960739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Yf91G0E96liVZH8Q9brrUTzp4Zjh9n4mTBgTUdMqis=; b=d5xuHBNm0S1OuAJpz+DeLZ19yLLS39ioFRSui/4uM6xCpHVd3ZmiHZ444NsSM+Gtw7 62BwHZ5sjjemejXpZ7Kam3BJgOt+U5CyNSOrdaHMffV0MI+aoSxroD9V/tqbFMAtbmp4 jX65Lf2NhhAnhIaTqbMkwLdd68Uenw0Ezx4aGe/8F62gNQ96bOT2TZWuJmyohvkGe3gb Vn6lkOhtE5ho8Fi/Yb56wqQO+nztq3x/I15cs6jXdyYPbkdBEvh1bVXgDXmMB8ePdAEl +un1ypxUTZLViOTQGnkMOOkepizadJ8zIww/ESOSb06U0lXINKLwWk3KifvCa7iIkH69 U6hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783355939; x=1783960739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3Yf91G0E96liVZH8Q9brrUTzp4Zjh9n4mTBgTUdMqis=; b=iNFk1K+oKd8ygdEHEenjQj6EZcNu4XHqr+hyIfAOOmr0KvDtAsICDHxfccIc5JirSF b2MMLyraYBKDKVzUMWMNE/aRDlhNvO5lBscHhmiYgDsluAzBVKUs2qmBevRfxlpbUjRV JGaJjUXo9VA9DHFm9j7b+uJ46FxePOdOJT+27e48iRRQXkkFGtDHVQrrMq6hCtZpLD2h ktsXJJE1JJSRfrrtl8q7DJgSAuqM62gSRVwJPROAOmaaxrJPjw6x3lQd99tIYM8CHJO/ Lqtjs0ViWBCb1Am907LskbwLFpA7mxUDiouW9xD0SXB0OuaAWcRZQrVmVB7wZEDeyDve 3VOw== X-Forwarded-Encrypted: i=1; AHgh+RpEai2GlwEZUK3YwvcNZckEjfJffnDOLphWpS7vkkWcKHhwn4RX395aQQfI2rQD5Oesjl54yd1pOBBNgqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+uaWPXwPEvbQMHzzYA++VEl3kFPMb2jJLPLTBDB6dz9xP5u6l Fa2HsXQE9RpgYHMvJ1IimFeR2a6shFOs1KrEDVNX9M2fZEq3iHNh836X X-Gm-Gg: AfdE7clXm6Mz+TxsYIp5VMGHbpzDsmZvm6KaCDHXQ4GtS5Yvko3xjBqtxpN7dRqZMfq whR9XEz7cYh5msLW0AEDA5cMB1E+cCQzIBSgOGMeqDy6Ce+XZTLa0qf1mCvy9iLcXfPjNV8I7hg 176x45c69qA0oQqKLqHLaREn8EEuzIRd97T0sUrHcDTOXIS0BmfiGyv+hhQo/SjrjZiKjm/ImXN GdaOJ+6Gv/nF47DgUqeVJ1NJwDr0B48lDLCZzRUO3Bqg200G4zFt8vPZ8oKsFqWSEUBhoQdj2md wz49rESCAQIjdC43tYsl+1pzx28GUv5mhh4vr7nOgB4OK2r5BTCrIpjFCbYARt4TFh1QRc+0g7h Qqj9hY1YSuQciXbaAEObGZfvT4DhpReF9qwc7xJoUulru2B6HO/Cq3Rx+KoUv6bRTIQaorAHXxP o31+rA368= X-Received: by 2002:a17:903:3903:b0:2c9:e9ad:3ed3 with SMTP id d9443c01a7336-2ccbd7d2afcmr15968075ad.17.1783355939040; Mon, 06 Jul 2026 09:38:59 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7893a8dsm53103305ad.73.2026.07.06.09.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 09:38:58 -0700 (PDT) From: Sang-Heon Jeon To: rppt@kernel.org, Madhavan Srinivasan , Michael Ellerman Cc: linux-mm@kvack.org, Sang-Heon Jeon , Ard Biesheuvel , Borislav Petkov , "Christophe Leroy (CS GROUP)" , Chris Zankel , Dave Hansen , Ingo Molnar , John Paul Adrian Glaubitz , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Max Filippov , Nicholas Piggin , Rich Felker , Thomas Gleixner , Yoshinori Sato , Mukesh Kumar Chaurasiya Subject: [PATCH v2 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Date: Tue, 7 Jul 2026 01:37:51 +0900 Message-ID: <20260706163753.193875-4-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com> References: <20260706163753.193875-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fadump_append_bootargs() and fadump_reserve_mem() both run from early_init_devtree(), before it calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value checks are unreachable, so remove them and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon Reviewed-by: Mukesh Kumar Chaurasiya (IBM) --- arch/powerpc/kernel/fadump.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index 7f79c9aea4a9..1629a82b9528 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -154,13 +154,8 @@ void __init fadump_append_bootargs(void) if (!fw_dump.dump_active || !fw_dump.param_area_supported || !fw_dump.param_area) return; - if (fw_dump.param_area < fw_dump.boot_mem_top) { - if (memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE)) { - pr_warn("WARNING: Can't use additional parameters area!\n"); - fw_dump.param_area = 0; - return; - } - } + if (fw_dump.param_area < fw_dump.boot_mem_top) + memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE); append_args = (char *)fw_dump.param_area; len = strlen(boot_command_line); @@ -632,10 +627,7 @@ int __init fadump_reserve_mem(void) (fw_dump.ops->fadump_setup_metadata(&fw_dump) < 0)) goto error_out; - if (memblock_reserve(base, size)) { - pr_err("Failed to reserve memory!\n"); - goto error_out; - } + memblock_reserve(base, size); pr_info("Reserved %lldMB of memory at %#016llx (System RAM: %lldMB)\n", (size >> 20), base, (memblock_phys_mem_size() >> 20)); -- 2.43.0