From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B195433BC8 for ; Mon, 6 Jul 2026 16:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355946; cv=none; b=YMxB5l4NcCQfPr8qkvvdS2wirLZ9tKW7eIaqdOf5nvJ4BVqDMcpDE49zQaLqI0N9l8XHBJD/SV3Gj9IZOyvuqk4EC7kqgGx/A6IvI04Vkl7ohAwI3ButTWzS5PAr6gfvCbKKAhlwe53g73LbJJFk3rKa29Id368dBRwCVfmJEe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355946; c=relaxed/simple; bh=+4oo3m2ArdTtJjh1PvNQw0FG0nTQSld32N4HDZ9xpoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uf6VWI7/VeTexkPWD8KsO4cjDh3YSGOqParxzfSktoCJ+1irM2mPn6qdSSazrJYEmkyC3f3NFQk419H13OLyteEjA0XvticUqM8O3Yx0/hCwc+Ggb2unSctXrMa2kvwZZ6YN5xxzdwbI3QDetomt2N0OY1kUF35FmeSlW/gnvHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B5joIuB3; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5joIuB3" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so22138395ad.1 for ; Mon, 06 Jul 2026 09:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783355944; x=1783960744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iUdu/4xkrp4af+ENG/+dz/iliEwP+6UzwIHbpWo5uXw=; b=B5joIuB3GOShhBZajhbLhNAy8mOweBtW3nlCc9TwoXCkj9LvOJop5PHzm13eGSyST/ /0UTaQZ3EHaXVJhtIw4DaDH43DdbYwOKXHRBv2rSmi+YfPoui5YLwL+p3DtzyB6vuOku NUG2iJxfRrsamAWae2pewauUymke0O3X+9w2YnUyDHqlrX2q58PfiRIW4M+N4Sv4nGsc yuMdIwAeVtgw9wURUW+fsgo5V76Y7kdm88nN0EHh8XR31wjQ2/peCLVnqboRH4m4cYA9 xwZV7QzO/D5IZv01LnZxtLFdsBRNyQEmdw0kP4LxhrNtYtqM26PHg9ZrhrTUdUYrZ1XS Y8Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783355944; x=1783960744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iUdu/4xkrp4af+ENG/+dz/iliEwP+6UzwIHbpWo5uXw=; b=jQ5gW2x2xrF53eA2oWtJbQTv8D1f6+yPfCyyBkoev13mIlhr8gxbtXVsuex8aU1ZkO I7KnpwVa4kwK+w5Ha/ObCtRlJ9K+HVBIVULNKxLT93CLPxB8i4NY39fHzDZu6atxBTnr Md30PaJ+h9Ghdpx2K9jYR9l7UBAZk6TPwF7nrrlKH8pB6UQ3pJB2khbIh1EjdI8Gq4q6 KiF3o+Rn0PBUq1YGi8ejeoJxY1pOakY+DDOCidvjbu+/onyMFx29QGcFT+Ylv1Bbrzfu O7m2qGX9BVNbqcNr0t7EUrjZ4gwJ/rHJs23qpIWUgtlAswBj4Kd1BS+TE7SRs0Bs2G4M rI6Q== X-Forwarded-Encrypted: i=1; AHgh+Rq92KAqm24OOk1MuqsbJOHokXFAYlch7/NpyzIcjjELF+y3qYOTmNzlN/UTlyn2Z12pRm55/mLgnHGuaPI=@vger.kernel.org X-Gm-Message-State: AOJu0YxMjb30Fw4zJmtqHHybU7hx2UKHdN4pRA421G2HQHubxXK4rpmU KPZyft6DrICZ5i4nG80S83r32dKgy95xeiWDaapCa7gEL2AzbQPODvPcw2je7g== X-Gm-Gg: AfdE7cn6EpcvwjoeKAQM+x8T0BdyUUzUQP5BJ8lJ87T/Zz/exVsKmaYmdU7/hQvYzvD v4XoWOZToBRsQk5njkrfOWLF6uy84beIYkdIaPkP62WremvSvvdMEZzfn2FNKWdcjh8SbNWRGKr rgCQzjFYI3niWjSuq9T6XIWHS2CKWRv7iLQvjC9ncGzWq+iA6FizfXfsKEU77VUPMA1/k/lau7t 8Uu428BAMD4JQWRkj5HguxtjR1b9jqVo8GvStqVAIbpaZ+chjOkoEcpKsvx62lpn4HlvoCWjGZx gSl0OBOkURfnGmP3l/Bm+h4GeAf44NxUyLUjhrxVLS8Dlkj1J+JoDHHq3r1nAsaO6yBUxIElFkW ZJuysNomXSiFTZ8Y0AACVZHrxa64QfdA+QblXf7HAArIfbMsLZyu4okKIU7yzkmjXaeTKBgkTgQ /g4yLnfjA= X-Received: by 2002:a17:902:cf0b:b0:2c1:f262:4962 with SMTP id d9443c01a7336-2ccbe7297fbmr13433165ad.20.1783355944425; Mon, 06 Jul 2026 09:39:04 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7893a8dsm53103305ad.73.2026.07.06.09.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 09:39:04 -0700 (PDT) From: Sang-Heon Jeon To: rppt@kernel.org, Chris Zankel , Max Filippov Cc: linux-mm@kvack.org, Sang-Heon Jeon , Ard Biesheuvel , Borislav Petkov , Dave Hansen , Ingo Molnar , John Paul Adrian Glaubitz , linux-kernel@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Rich Felker , Thomas Gleixner , Yoshinori Sato Subject: [PATCH v2 4/5] xtensa: remove unreachable memblock_reserve() return value checks Date: Tue, 7 Jul 2026 01:37:52 +0900 Message-ID: <20260706163753.193875-5-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com> References: <20260706163753.193875-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mem_reserve() wraps memblock_reserve(), and its callers check the return value. xtensa never calls memblock_allow_resize(), so memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value checks are unreachable, so remove them and make mem_reserve() return void. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/xtensa/kernel/setup.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c index f72e280363be..c7367b81cc36 100644 --- a/arch/xtensa/kernel/setup.c +++ b/arch/xtensa/kernel/setup.c @@ -268,10 +268,10 @@ void __init init_arch(bp_tag_t *bp_start) * Initialize system. Setup memory and reserve regions. */ -static inline int __init_memblock mem_reserve(unsigned long start, - unsigned long end) +static inline void __init_memblock mem_reserve(unsigned long start, + unsigned long end) { - return memblock_reserve(start, end - start); + memblock_reserve(start, end - start); } void __init setup_arch(char **cmdline_p) @@ -290,11 +290,12 @@ void __init setup_arch(char **cmdline_p) /* Reserve some memory regions */ #ifdef CONFIG_BLK_DEV_INITRD - if (initrd_start < initrd_end && - !mem_reserve(__pa(initrd_start), __pa(initrd_end))) + if (initrd_start < initrd_end) { + mem_reserve(__pa(initrd_start), __pa(initrd_end)); initrd_below_start_ok = 1; - else + } else { initrd_start = 0; + } #endif mem_reserve(__pa(_stext), __pa(_end)); -- 2.43.0