From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C0213FA5DD for ; Mon, 6 Jul 2026 17:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360363; cv=none; b=TE74rd+iVsS37cOSsnTvkFqAHt4qqtF1xrD+sCxq3gDoGZl8ct/IzuL1x+Hmpg6mPh5WTjakXZrsjIViv61Eu3Usr4i6B3JxtvqDlJLxvBZ5ZYJCfdxFZThAewr1H53FqXkSJ9PVmoj4hNTW2bTgsrtACSdW4zzSADt0KZd3UuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360363; c=relaxed/simple; bh=GnkKxSJ7Xk2y+xY1zEhFtkt9ZoxLrW9bqQv35sZxlOk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=n16M1VULHfSYx13E/jxdlVlmcbr/cRQAxW/qx/XRPwUFKQYKShXRiRLW1n3iBvGmcqkh+9WJe5JcZsXnfd77tZwAlpla4kyqxj0kvgygXG17eqP3wz1GEyqO0eVUzAkf31Cgt8YLfB9VLQLZpmhQ2ZqVDldsXOvGq6bjbY1L96U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=szK7miFS; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="szK7miFS" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-380ddac2b02so4881779a91.1 for ; Mon, 06 Jul 2026 10:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783360359; x=1783965159; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=A6A8xAuC1RftYdiH1Z5a7OhOer4aDxqV+KFlphF++dQ=; b=szK7miFSV+KfYPpJKmH+n3CPmzl1kOF8+NBaZm+0kilLlNKnyJB3gffKbA/4LTCskd vJqHDjSF8tDwyVtwUM1d2aocjAUsPBCATjJ08JEYFu0Piudj5VjGhtQcoq+lc3EFGCrr As4flY/ZvXxoQTBz5od8Vplqw6NlW25hHu4aDlE10oQZvOMtSyIfFhhEGY5LmLwczwEb m02ExvPSMV8jny3cp3HQobszCg7m5x3RK70R0RyHYuD2VSzJhAT8POFrYKnquq6zQ4TD ACEfDXmC3uoywehUEefKNdyCUwwPyWS2eoMIpZLLFiXsiZs4gSId2wK8lN5kArTJiWj2 1oug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783360359; x=1783965159; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A6A8xAuC1RftYdiH1Z5a7OhOer4aDxqV+KFlphF++dQ=; b=L3djiE6yrT3KKHdNTuOxHLB0uLv2/v6RjjDlXIGz3v3Jk+hPeG+sQGacNQkDSldwlg fFiGbVIx7tHL3SjuBp2ukiNXOWr0IqykE0Vlhk8z/Edg/uV3DuVPTUUIEnTfZZfLm6lK cwfo0LiVjHDe77ZOGj5ACegubgEddorTxrRu+9GpoVdGu2MWjKfFXANdaUhbiXuJls7h RtcommHz22kfmNEjbBSfbMv3UNzQeaT+ze5JfYopk8i9n4LLv7lgAShZbbK1QT2mKodV ZjflAWXpaDokVTov9hrKmfQj3TsDBH8giVSUIWLN9e/T++qVhxJU7uNtCLahtstCvLsh q0EQ== X-Gm-Message-State: AOJu0YyWf3fkVJoFuah2ZtG1oUQ+hADuEcjmSPHCVgSFt2tIHHKle7o5 8aU069ai5D7UNd0JUlOUJdNgcUvSfmxzuK8EhwbAnK2/0K0DGyCRSbu9hGlrg3AFerb+MzDlPYr zvoIIVRIUlnrjUprtZvnp/sARL04bCgdKkzj4pxPBGf3PiPrTMIAYV6I7gj3mgXD5rKC3wU9QEj 0K3aQXKbG3V+4yKeHiFWWaA9kzZO6i+RD3HDZvDTmEopMzR7qwlSXRpp4= X-Received: from plgs8.prod.google.com ([2002:a17:902:ea08:b0:2cc:9345:c60a]) (user=dmatlack job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f745:b0:2ca:d874:c6cf with SMTP id d9443c01a7336-2ccbe40bcbfmr16844165ad.4.1783360358471; Mon, 06 Jul 2026 10:52:38 -0700 (PDT) Date: Mon, 6 Jul 2026 17:52:28 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.rc2.803.g1fd1e6609c-goog Message-ID: <20260706175228.2468730-1-dmatlack@google.com> Subject: [PATCH v2] selftests: harness: Mark test fixture objects __maybe_unused From: David Matlack To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev Cc: Andy Lutomirski , Bill Wendling , Justin Stitt , Kees Cook , "=?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?=" , Nathan Chancellor , Nick Desaulniers , Shuah Khan , Will Drewry , David Matlack , Kuniyuki Iwashima , Aaron Lewis Content-Type: text/plain; charset="UTF-8" Mark global test fixture object pointers __maybe_unused since they may not ever be read (e.g. if fixture variants are used instead). clang made a change to -Wunused-but-set-variable (split out into its own subwarning, -Wunused-but-set-global) that causes this warning to be emitted for various selftests and can be upgraded to an error in selftest that set -Werror. VFIO selftests have been broken since commit ff556bd98348 ("vfio: selftests: Add -Wall and -Werror to the Makefile"), and the net selftests builds have been noisy due to -Wall. Fixes: 24cf65a62266 ("selftests/harness: Share _metadata between forked processes") Reported-by: Kuniyuki Iwashima Reported-by: Aaron Lewis Signed-off-by: David Matlack --- v2: - Update commit message about the change to clang (Nathan) - Correct the Fixes: tag (Nathan) v1: https://lore.kernel.org/linux-kselftest/20260630213341.1664345-1-dmatlack@google.com/ Note: The fixes tag is commit 24cf65a62266 ("selftests/harness: Share _metadata between forked processes"), which refactored TEST_F to share test metadata across processes using mmap and convereted the test fixture object from a static struct to a static pointer. Prior to commit 24cf65a62266 the static struct was always used once (the address of it was taken and passed to __register_test()), but after the static pointer was always assigned but potentially never read. Cc: Nathan Chancellor tools/testing/selftests/kselftest_harness.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h index 261e4df94d9d..29a19bc87084 100644 --- a/tools/testing/selftests/kselftest_harness.h +++ b/tools/testing/selftests/kselftest_harness.h @@ -467,7 +467,7 @@ static inline void __kselftest_memset_safe(void *s, int c, size_t n) !__atomic_test_and_set(_metadata->no_teardown, __ATOMIC_RELAXED)) \ fixture_name##_teardown(_metadata, self, variant); \ } \ - static struct __test_metadata *_##fixture_name##_##test_name##_object; \ + static struct __test_metadata *_##fixture_name##_##test_name##_object __maybe_unused; \ static void __attribute__((constructor(KSELFTEST_PRIO_TEST))) \ _register_##fixture_name##_##test_name(void) \ { \ base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 -- 2.55.0.rc2.803.g1fd1e6609c-goog