The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aditya Chari <adi25charis@gmail.com>
Cc: broonie@kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unused function declarations
Date: Tue, 7 Jul 2026 13:29:29 +0200	[thread overview]
Message-ID: <2026070702-mold-shelf-e0af@gregkh> (raw)
In-Reply-To: <20260622130453.63786-1-adi25charis@gmail.com>

On Mon, Jun 22, 2026 at 06:34:53PM +0530, Aditya Chari wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but have no implementation and no
> caller anywhere in the kernel tree. They are leftover from when this
> driver was derived from Realtek's shared vendor codebase covering
> multiple chip families.
> 
> Verified via grep across the full tree that neither symbol is
> referenced outside this declaration, and confirmed via a full build
> of the module before and after removal that no warnings or errors
> are introduced.
> 
> This addresses the "find and remove any code for other chips that is
> left over" item in the driver's TODO file.
> 
> Signed-off-by: Aditya Chari <adi25charis@gmail.com>
> ------------------------------------------------------------------

This line isn't needed because:

> 
> Changes since v1:
> - Rebased onto linux-next as requested by Dan Carpenter

That should go below

> ---

That line.

I think the documentation explains this, right?

thanks,

greg k-h

      reply	other threads:[~2026-07-07 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 13:04 [PATCH v2] staging: rtl8723bs: remove unused function declarations Aditya Chari
2026-07-07 11:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070702-mold-shelf-e0af@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=adi25charis@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox