From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AADC437FF5E for ; Tue, 7 Jul 2026 05:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783401044; cv=none; b=nWcxvIf9XECQUtGUGW3IpgGnr57Qdf7Ux4DR3qdZvzDbP1DBsb5+cu1sKD2WkPb3o87zc6391UXaGMfE1w4QGYw574WIEMgYXUkYV5RFHc18y8YMnho8bIKfMkAfObafahBukH/ci5H9Ipo5s/JBcyAT/OJN2AWNVMfkEMvckv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783401044; c=relaxed/simple; bh=MN7hjUlOeJc0FO8mu3UrzRrAKjy8hB3fiHLBiWptOh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ocZLmcaj85Nz9v8pmPR+lP5q1gL2Z7x9o6tv/htng0YgnwjOxWSbKfsUsT2Ssk273PsSIbbm1OAJ+jJKCJLOve6xxz1auXZCpDN8OR8kMQvldwFVroP8tlT57wKj5iBrXYwF/HhwZyxHYRLpvbQM7pczTsp8UKzeTxUNpxuf86k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yl/j1QAh; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yl/j1QAh" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-84532e3dbf7so3919231b3a.1 for ; Mon, 06 Jul 2026 22:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783401042; x=1784005842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=//ABcZnuHlA1g5iBkAP8i3Vry09H6XD9kKuii/9o6as=; b=Yl/j1QAhv+0yKETm6dGwivRuhF3RquNL9XIlQvCquB65ie9p6sn7D7RNdm59JT3v6c 71hSibtQYRWrw81hxQc0Gup6CiEf16TyASExE6IGlQUHVkpp1Ps3jEFgDj3h1KX4HJt6 Y1tkQGRMuZGjvKA6R3wPpXKiU+N5QM+QvFZgwCCeCJYInTn4Igh0HKyAbwXS6NDVE+t/ vnfUDY07gOYf1PCShVu7BPBauvfD2uLdSx5sJaU1oOWE2Hi8o9/NFi6a3G6yWT4kzAyr AGL9QtaHRRyw1t0VVaGk1i1FoHXhNVB/VURF2vL8pabn7OGk+wRnGrLEpk7RaFQM4wbH K89w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783401042; x=1784005842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=//ABcZnuHlA1g5iBkAP8i3Vry09H6XD9kKuii/9o6as=; b=If4bUbIizVutUxZ8+TSqsL8KJb0rcixHN1UewWvL5QwITUlduakyEGAcSeqgIxrzOm 47wNevtpJVNt4ZD7+JU0dJTfjb/587OFILnfsx1UxCbJvGEgBALywXon0yQI/mvwK9ny bqVNepIRel7huxgi1xWceM1xmm22mdob0WVaeq/8wDXMlFqVY1to7d9/xD2kLBv93Mum SnRZBEtWL2yGq6xCrdsQAWwjJO4SrK3EYvPoCSLHvuAhEakLR639edPNkRqZsDiukyyz 3SJkt4muLv/mUiywBo5TxKbsky5J/k51otPKQFjE/AfweC3f9jfLoims4phCpjwpc637 jg/Q== X-Forwarded-Encrypted: i=1; AHgh+RpfCihaOrje35J16IrEKasna7UORofscB+cWM06FDRy+S/t97w0qMRvX6ey2QQ0/P9WqdOd9dovp2iyMQE=@vger.kernel.org X-Gm-Message-State: AOJu0YwcBIiJDPFMnOpbK6T5tIGe9ZIEtbQxdctr7s6Cxvhe/qmRBtob DOZQ3prov8aQXRhKRtt8hgMvrxV635Fzz23GuA88uX6PNcgmvIYlK0Bj X-Gm-Gg: AfdE7clVkqsSJ1lHcU1jYDmjCiU/4a3xtF8M8kqUDZf7eeGAObj1egy7+m4dI8WJBAt 02y2w8Xp9R0a+WCoOYTmMYY78wUgIsB3cgOE8VZE2t5dSsJDKSMoF6kQSTuRd0DI5pH9vrhVHxi b/r3D+ESojOWI++sef3vrhhd+Vhl+pY+JCDlb1GLBbLEZQe/4vU8Vt+4SgFakK7rh25mPZdwiYw 034TfYyTHnnFjg7H7t7CeYkUEtgtkoHxL4VlTpSEhDli8QgO2oY7lwwztKEvMZb34dzImRAIp0/ eR280kW/fS+M402DLOd7zWlzFdy6E503GTJASEqNzufXUjipsQpuYCwLgj5YF7FPTOULG11vIOS Mmo7/Kmqdp875eKVkfDZ1O1vV1pCO+8EBl8OPmCJmDLeX/HgUrS0DQGwp4fTL61+0MI79vecPRA QoUM6dRoCCGxmOJzYgT3BcOWSmcGZ7pcxFxwroYDUhkxyGgCM= X-Received: by 2002:a05:6a00:3409:b0:845:d284:9dfd with SMTP id d2e1a72fcca58-84826dfe4a6mr3637636b3a.55.1783401041829; Mon, 06 Jul 2026 22:10:41 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d4dbdesm4728495b3a.31.2026.07.06.22.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 22:10:41 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Tzung-Bi Shih , David Rhodes , Charles Keepax Cc: Liam Girdwood , Jaroslav Kysela , Cheng-Yi Chiang , Guenter Roeck , Benson Leung , Richard Fitzgerald , povik+lin@cutebit.org, u.kleine-koenig@baylibre.com, kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com, Linus Walleij , Arnd Bergmann , Sakari Ailus , Thorsten Blum , Chris Morgan , Dan Carpenter , Marco Crivellari , Rosen Penev , Weidong Wang , Teguh Sobirin , Val Packett , Luca Weiss , wangdicheng , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, Cezary Rojewski , bui duc phuc Subject: [PATCH v3 01/24] ASoC: codecs: ab8500: Use guard() for mutex locks Date: Tue, 7 Jul 2026 12:09:43 +0700 Message-ID: <20260707051006.20058-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260707051006.20058-1-phucduc.bui@gmail.com> References: <20260707051006.20058-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- sound/soc/codecs/ab8500-codec.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c index 6e8ef9cd1b31..2cf96cbdd294 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -14,6 +14,7 @@ * for ST-Ericsson. */ +#include #include #include #include @@ -989,9 +990,8 @@ static int sid_status_control_get(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); struct ab8500_codec_drvdata *drvdata = dev_get_drvdata(component->dev); - mutex_lock(&drvdata->ctrl_lock); + guard(mutex)(&drvdata->ctrl_lock); ucontrol->value.enumerated.item[0] = drvdata->sid_status; - mutex_unlock(&drvdata->ctrl_lock); return 0; } @@ -1014,7 +1014,7 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, return -EIO; } - mutex_lock(&drvdata->ctrl_lock); + guard(mutex)(&drvdata->ctrl_lock); sidconf = snd_soc_component_read(component, AB8500_SIDFIRCONF); if (((sidconf & BIT(AB8500_SIDFIRCONF_FIRSIDBUSY)) != 0)) { @@ -1025,7 +1025,8 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, } else { status = -EBUSY; } - goto out; + dev_dbg(component->dev, "%s: Exit\n", __func__); + return status; } snd_soc_component_write(component, AB8500_SIDFIRADR, 0); @@ -1043,9 +1044,6 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, drvdata->sid_status = SID_FIR_CONFIGURED; -out: - mutex_unlock(&drvdata->ctrl_lock); - dev_dbg(component->dev, "%s: Exit\n", __func__); return status; -- 2.43.0