From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1250F2DAFA9 for ; Tue, 7 Jul 2026 07:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410558; cv=none; b=CeTSn6HiXWGtw1/4CXeIkoRSx1wwnu+WDr9mRjn4toALY/EG/XnFtVeIFTfxwJf4KwT+chf73/cN74vb92UGFr6lvAEEuR7ifbbBz5IEM5gARRAdoMvs2iikQ063f7BL1U/sE8CERipVFs/qdTg5FdS043E2w7bxU2gRODVCadg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410558; c=relaxed/simple; bh=Ll69jwTycTVdStJZVNDDkPg2Y7noF1LtSQhw0u/t8tY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TvBxHvnTBUez8qAVECGNHXP922wLPZAEhcq173ISj6VU5yFctyo6D97/MFXGp8MhSHLejstGW2b1cEtHDu65vr479JJjpTtH2xDYmV4MVjG78cN8XTSXvwX/7oYMSD+1m0YfsAcGK4nsYXXBTDzHO8YUaT8cj9d5BR7CAG9L3vY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NF81gmrE; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NF81gmrE" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-381018b9375so3980703a91.0 for ; Tue, 07 Jul 2026 00:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783410555; x=1784015355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=47qH9DhdGsXSvcnn2TMzn7MFl2kXpbMH9aBDXUUfcBo=; b=NF81gmrExriPwHcYQxKufEChkycKDwPfgnoPb4kOq76khlCZIbGRS750MmLLj+B15N 1hxEEU7pN0gVLk5fIJ1xBTY1I1bqDgjKKX/vO79nHrVaE0nVhYJ7HfUYUOM6pQKseMmf 0lXUIIEFZ7QKU5e7hvDW/wvBGGzMA2S/lHK/9EK8z9+7+WJQoVJL7RFhPmLM2vGw1P1Q 14ErFbrZiBg3N+COpbjduLz20wtLX19w+hUSKGZll4kMYcObwyYezgtXeR4RpCydcS0Y sMBWEqR0qL5gbsI53NoODoXBGo4cQah0osjGYVCHqRaBW6ZraRJ81x1oeTDLse6Rr2wr +9pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783410555; x=1784015355; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=47qH9DhdGsXSvcnn2TMzn7MFl2kXpbMH9aBDXUUfcBo=; b=sp8iiqesJlWiXt0uEZ2iulphe+aLbMc8l3j8O0O67K5q9mIK5ja+6F3TSVOEHaTB22 1Ezl3cjXlksFm/xnwciGXpFBpkBebGAdzjtAn+A/Cvm0v0uekpUEZSRMqoDaVOKLcRJL QiU3p1jR9U36+KhVDRExOhdk8A+X8nkNX9AqQkP/aS4MRzcLmd+fKaJhBiihCYid7x2s NEgb2PgzIwmy+ojb5Yb0kAiebT/SYgkx13pl/1tXlkDP6MCNpQN2WBrCZ+C6xyZoCAex iz58pbqRe7JY2MF2IHw3hWJxVl707Aj++gQ6LH3YAEaoSIP3DR6o1xk0H8bA1SsCvwEF Ob9Q== X-Forwarded-Encrypted: i=1; AHgh+RoGV4eVT+i3qjvBEpEHcjd2fRS4c58or30uGu1dJFuybdPjaDGpKz0XDiBGVV56/ZqalRpKDNRL7s/9ZmU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo/ThS7eWsbzinv4TmfpMOVxHNC+xmVug5OxJUvZo4twot0aRJ 2B1+UFb9UPxTCuhiznmphlCMUZHR8Oc2A63neNj78lr2GHR5wTHgXJGd3Rlx36lq X-Gm-Gg: AfdE7clJD95ckOjCyuNevTtlcJk58b5a+GADgcahCD/9FsryYb4nGijaj2ycvIXsQ2z OIkGj5EfCIbKYz+5TRhK3OAJy9U6oeFNR8ZypAkpeAjECDFNZgVKdtY38H5Rs2lZXKU/+a0su/i lnyBH8fieBQNzPYbgJ3t9Dg2vontkjsYvxBIa3sE+dWryJGD1kAURCHL0hsKB0ICGTU0Dn4Mc2j YE89XCPSUVxTllwsFEVA9EKrToQAejdUCTDzQDiiEvvHw7JIA3iSBq4fhspS4dXsjT3NVC0D5Pt Fu6VvHuZmCdb9hQ8bEDVcpCX+yxv2drNfvcvHKS6mdoU5twhtWNcFPtVV+Mf5NmkfoliJTzYBmK xezQG6QhIF+zMOrBks7+Ki67ySouzS1GmO5Ch/FRWd9Jf9T7XtALnaUHKMarv37rv66eR9sWgui p3y4JYQOlHkMQuu6+GCVB9vIYMuLCI33R2PIuVh3B/KaCl X-Received: by 2002:a17:90a:da86:b0:381:28e0:624d with SMTP id 98e67ed59e1d1-387597e83dcmr4179386a91.28.1783410555332; Tue, 07 Jul 2026 00:49:15 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a361asm626710a91.15.2026.07.07.00.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:49:14 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen , Akari Tsuyukusa Subject: [PATCH v2 0/6] clk: mediatek: fix memory leak on module removal Date: Tue, 7 Jul 2026 16:48:29 +0900 Message-ID: <20260707074839.240676-1-akkun11.open@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some MediaTek clock drivers do not call platform_set_drvdata() during probe, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Changes in v2: - Add a newline between platform_set_drvdata() and return (suggested by Brian Masney) - Split the patch per SoC, (also suggested by Brian Masney) - Add "Cc: stable@vger.kernel.org" Link to v1: https://lore.kernel.org/linux-mediatek/20260629142348.273766-1-akkun11.open@gmail.com/T/#u Akari Tsuyukusa (6): clk: mediatek: mt2712: fix memory leak on module removal clk: mediatek: mt6795: fix memory leak on module removal clk: mediatek: mt7622: fix memory leak on module removal clk: mediatek: mt8135: fix memory leak on module removal clk: mediatek: mt8173: fix memory leak on module removal clk: mediatek: mt8192: fix memory leak on module removal drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt6795-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt6795-pericfg.c | 2 ++ drivers/clk/mediatek/clk-mt7622-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt7622-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ drivers/clk/mediatek/clk-mt8192-apmixedsys.c | 2 ++ 10 files changed, 20 insertions(+) -- 2.54.0