From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FC033B6370 for ; Tue, 7 Jul 2026 07:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410573; cv=none; b=VgwDQQvMtc79UwVg9EEXY475BwsDPNEaqZgTEuwR68QoVrnhkZf7JutA3aSMZsVoXwDRWYHrclz6bSNKjKsCrzAFO6nd4kNpaXVyz/BxMsvHrIoyXG24OZP+heI60lrY+2rEE/KaK9XCnGt8qL6D6qr9eeMt/nuzjnoHOANHFtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783410573; c=relaxed/simple; bh=m12Mb+TIX47mD3Oz57lS4dblNLbaem2kqTJU65hzxOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oG67dm307teEZs1pfaiTT2uTNMin2iKcpV0guQh+l8GcOzqipAwnEz2l9Sp5JbvSRuIm96z7OJ0WEx1YnjyDkr5t8I5VXSJawEirtMko1XNaal4J308KPe36wHup+YwajPGhrMGAk3eSOS6gMgWMUfNuxvYUdA8xv7f0ecUCgHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f8lTUkU/; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f8lTUkU/" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-37ff8e0ad0fso3998846a91.2 for ; Tue, 07 Jul 2026 00:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783410572; x=1784015372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c6aDPvskXT897p+or3xpt2a/W5VjcXH3b9UnC1ZCrck=; b=f8lTUkU/gnu+k1gWYp5/HLgim0fzhgNpmB+GtNrobD2h7+Vy+6+/hg4mo9V/QzztBG zCp3KqAd6sirL+bevssjv2pG+VByci/i/9hoxjq4LT+dKLaXQ2LQ9NGDifrAGDybwHTg wqqF/x2t29zpRn62602gowWeU3B/tgR8H4ZsXoFpC29n+pWsAsAdr5a3a4ItR+211GSn O7N4FXFAg1pdNJR3lH2OGw4wJ5dn8wvH420BL2NRHZFo4RPcYh+rBmceZZxNdSoBkfO1 VnZcgng+voE44jggI3xccjNam3hqDfso6ghtssuLPO+TDzLFOXZNBSe29r2RrhVQA0+0 tTIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783410572; x=1784015372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c6aDPvskXT897p+or3xpt2a/W5VjcXH3b9UnC1ZCrck=; b=cmtMt/ifOwvSoqtqSt2Mg61MCx6/mrMy01RhVqzWCOGbGeeMkujtUIjYoQoh0UI4O/ QryA6xZMSaeUv4nvFgUXmsszefJ2vzwA0Klg8N0xU4xFfW+KSJcLJE544Pp7nURb9dtl mHUHYkSjV+WGLXgn/oPULS2Sox3hleaKcXtebOq+lKhgdgdtXUUMatpnzAj23MnvX1ma KRrOfQemxmW8Ix6IIPQBLEqedu9qRcM9/jJch+3AoTJP39vA0WwEuQWeC9HOVECaBs6m 7/Kpd/8pBv6dfRviDiWS2df7OAQQMdS+9IxTHH0cV4hcYomy8v/cF2Sag/AGKU81LRu0 U3Gw== X-Forwarded-Encrypted: i=1; AHgh+RqplFJmRNQIBJcFPmw9ZdLDWNU5aIxhoox0iTIyG5HtJ4Q/TsS3UV96r+beX5eH23Wv1BbSEtLO9D15lxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyCVTiIzbdLzbEzxNt/P9oyW9tf5ru6bcM/fvSqcW2eVGHb4zIs RlliC/FjMICI5d0oCbT8hI50IzIjYEys7FRdqTZKGw0iGrUXRXYRUKvy X-Gm-Gg: AfdE7cmNrVugEizG0NR5zSqckMCV2/wQvCxXtCKu7upKX9QhkMUNDmUUE7+UuE+z/Lv nt92Go4JQZis4oqXZJp3WOR/N0bMp/Sp9rQPcIH0IC80QpTS2QeJwp5IieAIrNR3zW0U7UL12gb d65noDNCcM/BQmez2AAAQY85nyvn00QYT2Jed/uicJRxRBqT/kqoYOpAewvIWn3Mp7vJJYJTxJX toPi3ky4oKKJ1XvjUfmSUAwELAzlxRogUGZCnIpLvxlBGnuVav3QxJ9EVk9/T3yFJcJXo9g2k+M /FRlSnyhqT4pdz43rxhDJn34il1+lfxdOhFrIppXRfbMstxbxAaSVgf7Ys/ibd4w/F4HKBa2CSo EET3SdSdbwpXH0yMzZqJsYzuyyyDit3R/Eor9uRQcIClQHsRXN/ftFxZbmocOMbQgGdZ9SW3uEY K6E/BiMTuBdHUSxuwyq0WshHC7Zc7gSPToYgSGBBHrDLsC8vaoJqaIP1w= X-Received: by 2002:a17:90b:4f45:b0:381:5bd6:eb19 with SMTP id 98e67ed59e1d1-387570c4074mr3687519a91.18.1783410571866; Tue, 07 Jul 2026 00:49:31 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a361asm626710a91.15.2026.07.07.00.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:49:31 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), stable@vger.kernel.org, Chen-Yu Tsai , Miles Chen , Akari Tsuyukusa Subject: [PATCH v2 5/6] clk: mediatek: mt8173: fix memory leak on module removal Date: Tue, 7 Jul 2026 16:48:34 +0900 Message-ID: <20260707074839.240676-6-akkun11.open@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260707074839.240676-1-akkun11.open@gmail.com> References: <20260707074839.240676-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk-mt8173-apmixedsys.c and clk-mt8173-infracfg.c do not call platform_set_drvdata() during their driver probe callback, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c index d7d416172ab3..65dc4489a09c 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -179,6 +179,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) if (r) goto unregister_ref2usb; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_ref2usb: diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c index fa2d1d557e04..8b69009e1965 100644 --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c @@ -128,6 +128,8 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) if (r) goto unregister_clk_hw; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_clk_hw: -- 2.54.0