Re: [PATCH v2 5/5] riscv: dts: spacemit: improve RTL8211F PHY configuration on K3 Pico-ITX board

[Yixun Lan <dlan@kernel.org>]

Hi Aurelien,

On 22:43 Tue 23 Jun     , Aurelien Jarno wrote:
> Vendor kernel enabled ALDPS (Advanced Link Down Power Saving) on the
> RTL8211F PHY to save power when link down.
for ALDPS, tested here do noticed it will configure RTL8211F PHY's
 RTL8211F_PHYCR1 register via rtl8211f_config_aldps()

And plug out then in the cable, the network(eth0) will come back and still
works fine, although I have no power consumption meter to test, but I think
 it deserves:

Tested-by: Yixun Lan <dlan@kernel.org>

> 
> Vendor kernel also disabled the 125MHz clkout clock signal, and indeed
> the schematics confirms that it only goes to a test point (TP14), so
> let's do the same.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index bf64b6c6f867f..e12d798b48a49 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -234,6 +234,8 @@ phy0: phy@1 {
>  			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
>  			reset-assert-us = <10000>;
>  			reset-deassert-us = <10000>;
> +			realtek,aldps-enable;
> +			realtek,clkout-disable;
>  		};
>  	};
>  };
> -- 
> 2.53.0
> 

-- 
Yixun Lan (dlan)