The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vitaliy Slivinskiy <phant0m.mail2023@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	dan.carpenter@linaro.org
Subject: Re: [PATCH v3 1/3] staging: rtl8723bs: remove unnecessary braces and comments
Date: Tue, 7 Jul 2026 12:59:42 +0200	[thread overview]
Message-ID: <2026070708-flirt-chirpy-46f8@gregkh> (raw)
In-Reply-To: <20260531165849.283264-2-phant0m.mail2023@gmail.com>

On Sun, May 31, 2026 at 07:58:47PM +0300, Vitaliy Slivinskiy wrote:
> Fix checkpatch.pl warning about unnecessary braces for single statement blocks. Also clean up the sentinel entry in the sdio_ids array as suggested by reviewers.

This needs to be properly line-wrapped.

> 
> Signed-off-by: Vitaliy Slivinskiy <phant0m.mail2023@gmail.com>
> ---
> Changes in v3:
> - Split changes into multiple patches.
> - Fixed sentinel entry formatting.
> 
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index c43a0391a5ca..f0aa5bc8a38b 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -20,7 +20,7 @@ static const struct sdio_device_id sdio_ids[] = {
>  	{ SDIO_DEVICE(0x024c, 0x0626), },
>  	{ SDIO_DEVICE(0x024c, 0x0627), },
>  	{ SDIO_DEVICE(0x024c, 0xb723), },
> -	{ /* end: all zeroes */				},
> +	{ }
>  };
>  MODULE_DEVICE_TABLE(sdio, sdio_ids);
>  
> -- 
> 2.53.0

The description doesn't match what you did here :(

  reply	other threads:[~2026-07-07 10:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31 16:58 [PATCH v3 0/3] staging: rtl8723bs: clean up coding style in sdio_intf.c Vitaliy Slivinskiy
2026-05-31 16:58 ` [PATCH v3 1/3] staging: rtl8723bs: remove unnecessary braces and comments Vitaliy Slivinskiy
2026-07-07 10:59   ` Greg KH [this message]
2026-05-31 16:58 ` [PATCH v3 2/3] staging: rtl8723bs: fix spacing around conditional operators Vitaliy Slivinskiy
2026-05-31 16:58 ` [PATCH v3 3/3] staging: rtl8723bs: clean up blank lines and function formatting Vitaliy Slivinskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070708-flirt-chirpy-46f8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phant0m.mail2023@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox