From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C6F19D065 for ; Tue, 7 Jul 2026 08:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413946; cv=none; b=rfBTMdWgtfNlxp9723z3O5EgwhMN2O9zJOrvMrjVtrp0gz81twANocjoKpGf8Zvn6jLz927+beGcJDMzaAOsNoQQoJjL1NAcWIUTeFgyCYhD04CorsykwFMmmJ/WGNKQa3u5KaH0t24f1pMYcN17lSyMGnLH1LnoyBr/obxdMKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413946; c=relaxed/simple; bh=rf/17gnaX6BVMaP6/wBzL/dOi8e4BdWP90FhBRVBukI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T3u8/nYb1FqdRzJJvHNCBjq1jxFfjco5NeAM/fbO4/lq6MrsMWquUDhVcg50RAFWGt9r/uqQrWxjr6hPQngVvuDxl1RhH5jPkWs54jXxwQPs8p1egNtaswA1LeUC66BcDEf6CuqWFxNpkfV52Z9aFCGZQkAsnQFV0ZhxmnGJ1Fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CvlswrJd; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CvlswrJd" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3817f800c8bso2885195a91.1 for ; Tue, 07 Jul 2026 01:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783413944; x=1784018744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jmBYS/wqx+QmmWVhLytQI1ddkicrGHDFtQb/fW5oMCk=; b=CvlswrJdaXX0AzSs56JcVnsxvQy0EXp82/nxI5WHpO9gpjJX06bWsSIZBUOg63lJ3m tLCIa2UFLuemth3Sdf3dqLN2pg9ZSG46QM7wyuHGctpwr0SOOMPccovO6cCof7YPjNCL qJXcgeJ05IWC8/Xe5OGwovpZD46guOTd9EMeZqAp7BvBknjAfnySNgOfBVeHIwzK4sGK FO3qIaUsAStNMvjb6aLw1X/GzLae6M5eEkQjijQ7OM1Mya5jtYdaiymPp7yz5dL/ZZ3T UKtDo47pGuXH9pXxwp7oY6Cgf2bb+44OUVltcujDMGL4aMPLSJLJhyZnHPQWq1ijpvmB DOiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783413944; x=1784018744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jmBYS/wqx+QmmWVhLytQI1ddkicrGHDFtQb/fW5oMCk=; b=hyUl479r3xjE7v6WMdcJGFaiJhu5UhRZHgWFHIxJHYfmv6X0I3msJ7rM6d3Kzf6QOR jmRCt9NU1ebRkHFFaA2F5arF+lXpfTmTZfLvZ+vjw3jmm8tYfktz5vVj8vLF1VDWV2jP ND+Fkkhe99/y2F7n6kv0AeDgWj50ijZq0uPG1f6tkx2UMOmqSsPqen74J0YeivrH9Uww QwmUiNLxb+XwaVcwiiLshvFWmbSSDR+KHFay2bjwGkb+MAowUK/87bqvjEu1VtFNdNNq r8KtfrSoVMZvWnIx4SCfoUKurwsw12GDC4XyqXyQvxAtyei8BP1dxW62SbGxmQzAL2NS t3vg== X-Forwarded-Encrypted: i=1; AHgh+RqM3PxVE8VJcCJcWMsZu91Rgm5VAszR1H3zc6Zo/ZQSVoUyDdbd83TB3Vd/RsHkzJ4SIBRXHxCXFv4bsLY=@vger.kernel.org X-Gm-Message-State: AOJu0YyEcDhWDBv27T7K3q8YXAxbup9y+5/dbg2wsGgkUqa5HXSqKFAK zOtS59uYkEC/st9b+29bcjeTDhoyW859zHJRVJXjx5ZpOnjG7Af4wjqw X-Gm-Gg: AfdE7cnFJwoUZSf9PsgdxOMirmoziSgpaQwlEPLeBdtHJiT3dGsyTzg8X8626j1sGXD joDzI9hzIGsyk4Y78AkIOgOr+xLM62k+z21DPzEGVywtKJ2DDFhLVom+AvQZPnSyrjbogF33BYr DS3qUPBCL5COrwJ1BjClNOIRrBfdS3afKPTY7055nPbY+daDjIUCZ3btRix1Ey7jL4BBEKT+w5Q OfPCTRzuG3d2T/gl4qd4z23gxMYreUcJO31CqN/sTrN3Np8Nd9DDWl2wmombLnmONBdbXLiDDeR Ea8JJWZttJm0mS8vmdRMyxYsSH5N5VUmNbqJkjJxzMHgQjgh++pM3Yt6CTu0+m8QiUNwi9hUqQ4 m6nXizn/yRGBiOuJnd0FcQl2uvoZCzyH+49afK0YghSfLBWkpfi91ks7Az3K7epB3rRiUeFPro5 ubP35T6VPXVj20iHfZDUGyo/kv8U7GEQbSU11p1sQzFCqTIiE= X-Received: by 2002:a17:90b:2c83:b0:37e:a09:2640 with SMTP id 98e67ed59e1d1-3875576870amr4533604a91.7.1783413944390; Tue, 07 Jul 2026 01:45:44 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d13fd7bfsm717546a91.6.2026.07.07.01.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 01:45:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Cezary Rojewski , Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com Cc: Kees Cook , Dan Carpenter , Cen Zhang , Len Bao , Mehul Rao , Sebastian Andrzej Siewior , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/6] ALSA: info: Return -ENODEV instead of -EFAULT in alloc_info_private() Date: Tue, 7 Jul 2026 15:45:03 +0700 Message-ID: <20260707084506.718583-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260707084506.718583-1-phucduc.bui@gmail.com> References: <20260707084506.718583-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc When try_module_get() fails in alloc_info_private(), the owning module is going away and the device is no longer usable, so -EFAULT ("bad address") is the wrong error. Return -ENODEV, matching the other -ENODEV path in the same function. This changes the errno reported to userspace on this rare race. No other behaviour changes. Signed-off-by: bui duc phuc --- sound/core/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/info.c b/sound/core/info.c index 54834dbe6b59..3b8ccda04e1a 100644 --- a/sound/core/info.c +++ b/sound/core/info.c @@ -78,7 +78,7 @@ static int alloc_info_private(struct snd_info_entry *entry, if (!entry || !entry->p) return -ENODEV; if (!try_module_get(entry->module)) - return -EFAULT; + return -ENODEV; data = kzalloc_obj(*data); if (!data) { module_put(entry->module); -- 2.43.0