From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 500F03290A6 for ; Tue, 7 Jul 2026 08:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413955; cv=none; b=meMTqbb1NpxDr9t4LdHZEfcSqv22xN2Rhiq8dlN00XHuTyXMZ7DjW+W7oQeH0iYrw6vuPc7qdzArvryfVJMNe4kP1+C5sJesORNPIZqubbb6fa/sXTz9dvBzy/E2GRyj0DBO5wArT0LimFw0LePwJ5amoiYk+FMFBqDYYs6KMhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413955; c=relaxed/simple; bh=s79fNyDwwJHeBgNt/8ZFtgU9AEkWY1983W/wfWNr1PY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WzYLtOA42xuzEmTM2giRjX6IYCrLJuJafE1lFuO1PoTaydTVVpx0tRDxTnl6mqNsTWIvptuVyZ/4mEYLOJ+r09SAo54Hs6tpOTyl3SYCP8LzNcc1+l+I6mnORqP96LAXzNkQrCqOo1hKpmL5gY1tqFzoadgIwpmaECAcVNQVT7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GEemQsF/; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GEemQsF/" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-381ed661712so3561586a91.2 for ; Tue, 07 Jul 2026 01:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783413953; x=1784018753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TNzX+CZ5VQZ8kARVOIT//BAtEtOkAFeL+rYHssGJU6U=; b=GEemQsF/ue0qbvnk576XYl2CCVbSNhLHHu3oNTkTancU9zySVab8b4lzyNFk5TwgwN YNQfymunbbHD9xEec6woObcchRvE0qzCu9g9/2T34ptRNmYys3Kv/sVALYS4tE/d/dH/ LMDmBMKCxYpI5oISaq5PsRhWrQmMsz2cbwHi48oTqCpnIWfyaR7UFbn2/XDLgpBTSypj 5nfTSc1vucHLeVLsFTn9960R14zksV0bhbgg9cKrTIm0WvfZcPM5kJw/fWw4vGl+BJGX wmwgBqma3KI00xJrwNqUPixvcjRdyqGavl03XdMEGXbOEoiVNc8kcPGS1CsJXH80Ijxq 38bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783413953; x=1784018753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TNzX+CZ5VQZ8kARVOIT//BAtEtOkAFeL+rYHssGJU6U=; b=KDN+Z9NvmByWv5BVVU0kFzq24QeQqtVMAwF1BdDllCHCjN8ttCK15yVQ8YwBstcTPn 57vZKonbyrBH+/JzIcjjQmuG/rnPyB5maXMaYEqxwFcipHgNkE21ipm0Hv4IBvYHV27i qIkc0t/psfaVXWmRjjh8dCngcaFN7jMrYFjsHNe4SXIhDQgrU9a7+WDvG2u3wExI/wpo g87Y6YAy9cCBF4Vtf3V7HNgQmv6sH+aTYLa8l6vRTucwYCdgOZCpSU41jen0+DJdrKJ1 xQFwnojtszMWtoFHdKiNxmiF/3vF5a8+c5XRhJe1kr4tm9hAnNhgaAkoZ3+cfraZ7eeC T3DQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8Ta4pVNTGJ99n6yHlIQLbAe+ICFlmvs+KAInxGzlg0J0ypOM+zgkQGZAQoxuFqQd6lTSUyVtMmOloiPo=@vger.kernel.org X-Gm-Message-State: AOJu0YzAeGeH0KFWpfNsAQ82cHNzQik45EdjFQ1sN+pGJ1kkq2GrZkjC gLW30vOP9r/75PSBL0IAOzu8UwmNpwayBpv95CPb77eIo89bJhVul++/ X-Gm-Gg: AfdE7cneI6rkfmtfFq36ohUol1PDi8mRkFTRewkotmPtuW8jHiS3gPNJVP99rfxov8/ qi1KG1LKenAFbYbQxvvQAT73S9x7GU2F+ue6R4D9PD5K/Ei9w2VR1cutXFgt0upvpwn1LrhP2kH JT7sIrl9UgG5uGP6Gq3EtYzfmMLe6mVJ1dB3UFLUfBMYxJBn1DP64NDt11ZoSiDqewjFOYprG2H ulUC1uohPfSY0XVc2SUANRuiy6k49bY/tBPjVoWvmImuSXbZ3LtUVsJPc8sQMYAalkAeNHqKk7K qz1IV4LIxhVFx6HWtxNJnCTbrMaxNlyNWOdVFfUgb3UcOCBBJ4F0enxNBDczsSbM910gzfTRBS9 ilnSNmCis89WPU8NC6SWSM6uEfRskl3572copjm0IyoW/tRZ9M/hbWtl+IJmrRiq5OgD6Gd4kxR blGAS6r6UHGr9zrVytW6cIBHBk3KmGXKBDdsgUWSiK4FV6fWU= X-Received: by 2002:a17:90b:554b:b0:36d:9e0b:3801 with SMTP id 98e67ed59e1d1-38755a5606bmr4357510a91.8.1783413952628; Tue, 07 Jul 2026 01:45:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d13fd7bfsm717546a91.6.2026.07.07.01.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 01:45:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Cezary Rojewski , Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com Cc: Kees Cook , Dan Carpenter , Cen Zhang , Len Bao , Mehul Rao , Sebastian Andrzej Siewior , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 5/6] ALSA: pcm: oss: Return -ENODEV instead of -EFAULT in snd_pcm_oss_open() Date: Tue, 7 Jul 2026 15:45:05 +0700 Message-ID: <20260707084506.718583-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260707084506.718583-1-phucduc.bui@gmail.com> References: <20260707084506.718583-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc When try_module_get() fails in snd_pcm_oss_open(), the owning module is going away and the device is no longer usable, so -EFAULT ("bad address") is the wrong error. Return -ENODEV, matching the other unavailable-device paths in this function(the NULL pcm check and the card->shutdown check). This changes the errno reported to userspace on this rare race. No other behaviour changes. Signed-off-by: bui duc phuc --- sound/core/oss/pcm_oss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c index 0d7818eb3e14..8ae43755fb9b 100644 --- a/sound/core/oss/pcm_oss.c +++ b/sound/core/oss/pcm_oss.c @@ -2507,7 +2507,7 @@ static int snd_pcm_oss_open(struct inode *inode, struct file *file) if (err < 0) goto __error1; if (!try_module_get(pcm->card->module)) { - err = -EFAULT; + err = -ENODEV; goto __error2; } if (snd_task_name(current, task_name, sizeof(task_name)) < 0) { -- 2.43.0