From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E76F38F934 for ; Tue, 7 Jul 2026 09:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783415414; cv=none; b=mycuVDdd6brIFPXrkwMuMNG5JdUn2JffAo/ohiRSW60zRmxZQibdXguKZxjptLvagEbL8enU5TW1wSwyFGNkmNUIWdgkyknLEGjIlngM32cjk15uX0g3jZ19dfJ7PB3ZVONZBdcgU6mEkHG27mwuSTUW61s244xnoWIcIMat0ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783415414; c=relaxed/simple; bh=uueHHMutRJ6frFPDQMckdPuq5yMr+h+AuD4pIXQWprI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ux3A5HcXK5ZHq7Kjkgx+r2ECRw1TZYoF307JzqXIySGkrOONFTv/O/bnLkoCIQKfGXgMQ0LfGFXodD2AA1evHDIjQt2YJL9guMkTwmlD/98D8AFQ+BqdZyIvbuJT3lGPr6QysaHzmYypshsm7DxLzIc3zHmAW54sMNwI9fnIYw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E3yUBolp; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E3yUBolp" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2caced6038eso5163785ad.0 for ; Tue, 07 Jul 2026 02:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783415412; x=1784020212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gQVakd1rt8cl0DjUwQZJFDqrSCfo7IDM+mNhgQzAAV0=; b=E3yUBolpCw0vO40JHuglgxjDeucaEYi0gl/2LrbVZtVayZyuGvl0H0Xg/QYO86pdDs LZ5nppcyOxzdVV6nLyghXKoa2TjGEKBOsD+/9haDHSNtzOkIL7vy33reDPP6JdeRVnDE PGiHGv+YWouOPGZhPJin/JipGddvAr95Egxhwc8WDefEQQ/Sz/dN9mKdaXu5pTm9fwXp vRVPLHxraNpIZhPtUKAVdMM6wwLajiLAvDFNTFzTEg7S4wnqMosRcrrS6rVWL0JTM9jm GlXf1/zlwb7z8CqFhxKkzC2jf9JJsQFMPep4HMdtr6SvCICRXyEMzhRAQ02RjTwsJnMo oHaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783415412; x=1784020212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gQVakd1rt8cl0DjUwQZJFDqrSCfo7IDM+mNhgQzAAV0=; b=rFlRjOoRPldWPQLvFQ68VHSnCKl1Z3gtvZVt0gZO59vLOtnxQRvmInoey/06yEqPAb G9fsxtxn+ht+uJE5ze9qjJEJdJiqgiPHSMuB3f/ZobKuew3QW5h/MdQ4C2icIVU1v0Yr 08HeuyEC/NORWadG7fRBlczqTNnSJa2MJ0rQCX/E+S5O1Bmv6SLrr4aqr0gCVdrKEIBw xtYKh7GRFBp1GOsDbDNZBm5H2gVSIbZ5voWyXRyvUY0TAtj2C4HIlOicsFuttocrTahb taWZLUbTB04lGMZ7+66BEhgL8a6IDigWbYAekwy8iiuS0sowxyRBskBM9+b65vULwryi gLlQ== X-Forwarded-Encrypted: i=1; AHgh+RoZuBTOZ6JgpiTJZopHlyMFqNrIArtS0LLl8407/9NLQY610YP/DIkjai+0jlcvon5UZs83doHyLZh7xgo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzy0F2re7/uv6Phi8db/9uURgNWgasP1vS1UrgZnLcX1Jfaz7Pf j2n3ubPinXUseUhuTOUfCtLAsKw/pcgo4JqsR+kQh68ir/vZvTcfzLil X-Gm-Gg: AfdE7cnYGVK9s+eqnAjRM34H1Oc+LHrHqcuIENbUv45lYp/QZgyRPbkOp/D/uAT8MQQ 3F6sR4JcC3Dhf6w6mP9qibfKumXLIGJ+HVQGdGKMvoT/fNk251sw5D/p+VG8ex8RmvoFzJCXuvG dm0JzL7yifZPoQ+QTIgJC9UZJ1FIs35JiX4GWs8KYZ2D5xveMtub4evpVEY9W1+VD2bZUNooYzk qP4smFJ4+CPZcQVI1/HrIWLVkun4enGKuJqO3TDE9Hmt5JkD5KmZm0zQlL78TU2IRLwDMg0taYt FOt6aFKuZqHAH3/1hO3abveo74DR3hUmerj4a5x/Pc195lgXnWPsZmORg3ONcGFYCRDDPZXu82Z r9SmqGRHsRpQylDeJB/Ys+rm8YkSNmzZ46CfVRuDkckKd0UGu5Z7oL6LxwJb6KXrTJEFMiS3ucF vztgsfqvZjobnIEyjt4MGWWNM02PRMZlmt86mz98CHMMPTJDY= X-Received: by 2002:a17:902:cecf:b0:2c7:c385:c5a7 with SMTP id d9443c01a7336-2cccae1c506mr19718435ad.26.1783415412489; Tue, 07 Jul 2026 02:10:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb775sm8139695ad.2.2026.07.07.02.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 02:10:12 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Mark Brown , Kees Cook , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ALSA: control: preserve snd_card_file_add() error code in snd_ctl_open() Date: Tue, 7 Jul 2026 16:09:58 +0700 Message-ID: <20260707090958.794852-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_ctl_open() unconditionally overwrites the return value of snd_card_file_add() with -ENODEV on failure, discarding the actual error code. This also preserves the original error code returned by snd_card_file_add() (e.g. -ENOMEM or -ENODEV), instead of unconditionally overwriting it with -ENODEV. No functional change other than the returned error code in this failure path. Signed-off-by: bui duc phuc --- sound/core/control.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/control.c b/sound/core/control.c index 0ca9fff56e51..f64b2dec746a 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -64,7 +64,6 @@ static int snd_ctl_open(struct inode *inode, struct file *file) } err = snd_card_file_add(card, file); if (err < 0) { - err = -ENODEV; goto __error1; } if (!try_module_get(card->module)) { -- 2.43.0