From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D9D3E5A0D for ; Tue, 7 Jul 2026 13:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431982; cv=none; b=q128Bh7bJLhk8U3eznYI0pE0dc2k/3ugrcRPB50bVmmJaGH0qxxMCkF4SNUg4mR9OoqN5UiWQ33QTjlyR+ApT5ySNPvaEhfbUPvwLf9sIpnWpgfyTNFDvX6Nci5Ai397BMho7uXaTxEQr4yl2pXqnhsC2BD+MmwMuzQUG7JCwVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431982; c=relaxed/simple; bh=WvUrawHnthQnoDNoaC8IblcBCIgzAQUXKbXabrCQi88=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=MEwVbBF6fadpvO3fOMyYlMk8fiRBQeFZjtIWTGN9wAluCfMolz7B3iNYoVup6wPkDa2O31V2RpJDU9Tim2YB/GGs3sBnDBmMWsdKw6NQ5SP0RVsPmtOcqVwMM5QknmaMJNAxiZDcbaCHSJ28+DMKCPugsmTpiq50i9glaBrQU4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gFTfRcxg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gFTfRcxg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B45E1F00A3D; Tue, 7 Jul 2026 13:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783431980; bh=ITzdNOsUMXL2cQrHpFq/YS8AXf/CLmvykTeARteeTB0=; h=Date:From:To:Cc:Subject:References; b=gFTfRcxgSN8pU/80IHgWZ5puGSTvpT6vVadPObgcvqbrUPmj3JcqA9i6WwpLApVPg mRxLws2cw3wQ1w+jat1Fjnm++Q4nq/F0pl6LXsE2kO2ITzOv6LIahgWNYIRUhpyKx0 9M2le4iue7ng5VkO4mCMfgyb8xUfQXkf3+M6EI3GseDbLl/s4CvXDj+eMz/uFPcovs Txy83e3kVws19R/VBzJCcNpZ3RgUkaPpkJtJ+1eKclaiNrsiEAOr8IoW5sopHduoda uK+1WWOa6gS/CgnLST/t3VxjtfGNs6vuLvtYGE+kjq1XypZXgLSE+6pyJ2AdshSoC3 Ojz68Fkgc109Q== Received: from rostedt by gandalf with local (Exim 4.99.4) (envelope-from ) id 1wh67z-00000000h18-1QSj; Tue, 07 Jul 2026 09:46:23 -0400 Message-ID: <20260707134623.197099768@kernel.org> User-Agent: quilt/0.69 Date: Tue, 07 Jul 2026 09:46:05 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Yu Peng Subject: [for-linus][PATCH 01/13] tracing/synthetic: Free pending field on error path References: <20260707134604.275787924@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Yu Peng Some __create_synth_event() error paths run after parse_synth_field() succeeds but before the field is stored in fields[]. The common cleanup then misses the field. Free it before freeing argv. Link: https://patch.msgid.link/20260603062533.1096320-1-pengyu@kylinos.cn Signed-off-by: Yu Peng Signed-off-by: Steven Rostedt --- kernel/trace/trace_events_synth.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index e6871230bde9..cdd5b9332835 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -1446,13 +1446,13 @@ static int __create_synth_event(const char *name, const char *raw_fields) if (cmd_version > 1 && n_fields_this_loop >= 1) { synth_err(SYNTH_ERR_INVALID_CMD, errpos(field_str)); ret = -EINVAL; - goto err_free_arg; + goto err_free_field; } if (n_fields == SYNTH_FIELDS_MAX) { synth_err(SYNTH_ERR_TOO_MANY_FIELDS, 0); ret = -EINVAL; - goto err_free_arg; + goto err_free_field; } fields[n_fields++] = field; @@ -1491,6 +1491,8 @@ static int __create_synth_event(const char *name, const char *raw_fields) kfree(saved_fields); return ret; + err_free_field: + free_synth_field(field); err_free_arg: argv_free(argv); err: -- 2.53.0