From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4DFE3F787F for ; Tue, 7 Jul 2026 13:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431981; cv=none; b=BpFL6w0ov+LDJanTsHp/XsZeRl0/SB9qx/lNR4MC4f3WcZ4gn9K73AutpIIdzYz2c/aa1ibo9VgxwLfDVBhjyfiC3aZ35RFQbloU2vBhfVU58SmEBComIIFIAHDVUDzH8WVDvnHdYJUP2l0tqa6GW3hgZruNIqgv4qoP/JnaUec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431981; c=relaxed/simple; bh=gLuXjSc0rZKYc7tprgoLd2Q0ahtK+EVPjXDD/mmevSw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=iYCDzit9rC8+frq023WaMb23oFqFvmlT4BJyoNz3G1C84WTRBScmKFqbBMpwGlMxjOSkPVPg8Nyx54JUKrvKLlUOG3WkrV6NVSZ4F4ryaLqpK+4r2FmVkGOBT64M4HqN8253ops2MDJ48UfD48Ml18dVSEUTQLypAbWy0dHzeJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V+Yope1o; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V+Yope1o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F1441F00A3F; Tue, 7 Jul 2026 13:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783431980; bh=YHgy5xS/el0KLjuFboHB3PJKUE/mi1QyhaF1qxxg1yk=; h=Date:From:To:Cc:Subject:References; b=V+Yope1oVCQqjOa4rQkQMSa2HnvPOYgRt+SZsXuOaWnZOd+QRFPslpw5bMsUU7HmL fL+KRsomgSN452ZXrXuXIc1ooK6+AfIoyVCPmmaVdVd8r4eWCqj3S2AhxLGIKe45jS FZotk/QRhT/+n5IzXSJf36dR6C1FXMPAeC6zZxE1AtENU9QT9cqynJ9ygzcXvpph59 P2LBY5vLUvLHS0PeHeTQ9pI6VRiRAIU7o2i1XBUHncLlL2urUusizfxyiKOLMn6D8p RKTIzrbcvjzAlaL6ncGFuo+4XYW+OqL4QGa5+v8zTjsyRMpGiVEta3qyhN+AhMT8gL ZEUFhw29MZNEA== Received: from rostedt by gandalf with local (Exim 4.99.4) (envelope-from ) id 1wh67z-00000000h2a-3jIk; Tue, 07 Jul 2026 09:46:23 -0400 Message-ID: <20260707134623.734973202@kernel.org> User-Agent: quilt/0.69 Date: Tue, 07 Jul 2026 09:46:08 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Wayen.Yan" Subject: [for-linus][PATCH 04/13] tracing: Remove unused ret assignment in tracing_set_tracer() References: <20260707134604.275787924@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: "Wayen.Yan" In tracing_set_tracer(), the assignment 'ret = 0' following the __tracing_resize_ring_buffer() error check is a dead store. After this point, all subsequent code paths either return with a constant value (-EINVAL, 0, -EBUSY) or reassign ret before reading it (tracing_arm_snapshot_locked, tracer_init). Remove the unnecessary assignment. No functional change. Link: https://patch.msgid.link/6a2a37c4.f0a9eb5a.2fc603.7724@mx.google.com Signed-off-by: Wayen.Yan Signed-off-by: Steven Rostedt --- kernel/trace/trace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 1146b83b711a..299f5ab630b9 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5015,7 +5015,6 @@ int tracing_set_tracer(struct trace_array *tr, const char *buf) RING_BUFFER_ALL_CPUS); if (ret < 0) return ret; - ret = 0; } list_for_each_entry(t, &tr->tracers, list) { -- 2.53.0