From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7205426D0B for ; Tue, 7 Jul 2026 18:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783449332; cv=none; b=R9KYUFJq8jO4DS8XlotMSEv43kggdlHhP4YRqsVDcwHXaROXBXD7fA/puygGnzZZLay5dxhM3vqaNTingurI1cwDLVy7TyC2NW9bXyo6MmaCpY3K9QkixmFiTr+Qhz0z6kc4ayvAxOPBhbzIBbG9jZQ2y8FlhHo/rHdoIt/4SGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783449332; c=relaxed/simple; bh=LTNIWWWHNfOkmzU80JlTfNalGkQHDxa1lYfF+7hTDXQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qOEdXTOloRKbwAIQpYn8yeGhdZVnT1DWWOLP0LhdLVm5MmzuqMkd3zirM4FtxTFvIEICqPtXDesCF8FcIlr7+3HfuHSbN/6nniM8o8odowyRPI3A11XY3n9hr4/MBbDdLgse4Hz/zovSdjak639dpazsFxCmHMEk07CN/UfRV3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T6YlOIQs; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6YlOIQs" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-9217d13c276so207505085a.1 for ; Tue, 07 Jul 2026 11:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783449330; x=1784054130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OtzdIfG9XZcnEgeVPPq/84u21ReObj8E02cU3lMTv1U=; b=T6YlOIQs9C37ShWDnxj4F5UBRJhNYECQiletgkC/by5NzCSiM1q8pkgX53nnbuRMAm kt2VLmtZDWHgTCjULqxF/oCf7olb9IwlalNapcZJmbbJ2K1HFjut7eAvhQtRG4k5p+RM KNzXZrj89XZayz/BA+yACs5fC7rr9r+yZ1gqqbLZm56O0JdqQU3SW/1QFDmOhoPV91rf Qp7BcEgy8GFfxKFga2KJapzeqrz4N9/IYWRyZbYBSpeXCdVNgUsOfM7Ulo0lKEkYYciq E5SQtwiQZEtOWCubakah0PesPlnmyIXITsmnCxuKEX6hbtK3WuKnh0rnk9kgHR7daupm bbxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783449330; x=1784054130; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OtzdIfG9XZcnEgeVPPq/84u21ReObj8E02cU3lMTv1U=; b=k2RJOIxMaY/yX7DMQYsUldc6GTIds4DEfeeioRVSuMCuBFY1uWFsSHYfR+G3/fDH1I gUkGxDC3zdk5iQMPDN6Fl4x84Cic+7IJgPJB78AmPe7O3kVrTUeu73Z0qmYe3DlnOvOc OYOdfgbogBFV1wrZFEO0c5X/s1Zj4O0NUQmkQoWwtq/6OiLxi94ngZ0vpfxAsws992S4 LQuXuc7ykczFdQVwuaWSaYZ/xbkfnlWCahwCF9dBMiWFAVXlq93g8e49+KVCOZNiIaED Sff+t5l+OXavrrJaWCUg12QmATYk9c3ofAkv8i0MNGZKlTnbbnYQnMykKUCCesAHR5+C /HEQ== X-Forwarded-Encrypted: i=1; AHgh+RqDOPKxKu0qxrF9HwQY/iyh6yG9aMUTdc3DWEdPeI8tALggmu/SPghnyeNFmgsObtzLDat/+bKcz5C022E=@vger.kernel.org X-Gm-Message-State: AOJu0Yye52ZQ6dQieZU+wNrIZJibHugbhHIJHJHyW+nRlPsb2+gnd8ig fdL4YTqezhPZ9h6Rqp/yk041pdpxU6c3WRLyJzq/+gzUg898TpsBVlI7 X-Gm-Gg: AfdE7cmpm0wPyKSgFyK1AnJZ8sINWhtX6yajn+SMXRWuQDrLTUI6jwzuuH2arS/RVM2 5WeLVtSbbTjigMtP49kQ/0kS1K8y8kUDMgQImDhYXrtiGdPeXI4fV9eDkJmUI3XzH9oJ30Y66Bp iZFRIKKD/leU09k2Xckn+DOqfQZl0I/AR6kXOHPYIwtjXrtrjxg/aCwbEdpFV6Jxhzi6z47z3LZ GxzY3ESyU1C7KJNSb/H7m2GIHJ/8vlqL9I91UkBVEuPV7ls3fdcc139RcEI3iS6equkoGarPaOz D4qmfsSmddoHL9Le6KOKGZ0LOUNTvXpggyMF6qPnRwWWAuZ/y5QCZBr+BkHAk6UoLb9TmVdRPJa 2yehcdYjqJnoxqqMke7ZZNEkq98N0bZfKhInUDK7yle9qvly/4TkOqeY/wmYKzRjtxqJCKLrPz1 IqAnhRzrfl3kQzz3gxDPXMIZM1m7YF4PplN6HNlqsmVw== X-Received: by 2002:ac8:7c54:0:b0:51c:1590:8e28 with SMTP id d75a77b69052e-51c747be191mr71047181cf.25.1783449329472; Tue, 07 Jul 2026 11:35:29 -0700 (PDT) Received: from i4-l-hqh5357-03.ad.psu.edu ([130.203.139.71]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41d2d688sm124822691cf.17.2026.07.07.11.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 11:35:29 -0700 (PDT) From: Shuangpeng Bai To: david@ixit.cz, oe-linux-nfc@lists.linux.dev Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuangpeng Bai Subject: [PATCH] nfc: llcp: Fix nfc_dev refcount leak in connect Date: Tue, 7 Jul 2026 14:35:18 -0400 Message-ID: <20260707183518.1888697-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit llcp_sock_connect() takes a reference to the NFC device with nfc_get_device() and stores it in llcp_sock->dev before moving the socket to LLCP_CONNECTING. If such a pending connection is released before reaching LLCP_CONNECTED, llcp_sock_destruct() does not drop that device reference because it only handles connected sockets. This leaks the nfc_dev reference acquired during connect. Drop the device reference for LLCP_CONNECTING sockets as well. Signed-off-by: Shuangpeng Bai --- net/nfc/llcp_sock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index feab29fc62f4..44639ccd438e 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -960,7 +960,8 @@ static void llcp_sock_destruct(struct sock *sk) pr_debug("%p\n", sk); - if (sk->sk_state == LLCP_CONNECTED) + if (sk->sk_state == LLCP_CONNECTED || + sk->sk_state == LLCP_CONNECTING) nfc_put_device(llcp_sock->dev); skb_queue_purge(&sk->sk_receive_queue); -- 2.43.0