From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56412374A02 for ; Tue, 7 Jul 2026 18:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450267; cv=none; b=cVnbk6ZoXKUhoyphG5vgc0myoh5BrkqU/awWjecF05iN7MDTnE9ABuP8TlJuro4fhTc01u5Mvx75urX2K8gck6/j35pJrS26y6QUVoHICwSRw1mkBR3ZVk0Tk/wvJfhH+b/ugWhWWXT2sI4BzQq9QNHEHyfZG9WnPMzFf2ohtIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450267; c=relaxed/simple; bh=Nw6innSIqpxVWTQoJU1GVIm1ikahkK7AGp/6PZZsT5k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=t93MlcZS8yL47teSpZTlHcs8pKieyFzCNafNaMTKPmMILFjH13Umv9E0hxOesgfhtkix6V3HvH9fMDCH8FARkS6PUUhlMPRPc+k4SrgBwAs0TjuF5SGMdete8pcbrjWSgqX3ig8i3i2yCvT1xrk+UwVl9P23uLFeekEgFzk9qcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PreVC4Ih; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PreVC4Ih" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-51bf2479349so30576421cf.2 for ; Tue, 07 Jul 2026 11:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783450265; x=1784055065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rTSr9YvA6zvfbdCXk8bx0rwgDXQY6cKDFEPWMlli5ik=; b=PreVC4Ihsc6NPo6oAh/7hscxHs0UNbd7Z9Wx8kr0PMb4KbIGU48eoR+HyqcNLXJi4D 2gcBMPVXDHX+xD6ZGz83x0pqeXqsFYFM3qGbXekR01qN68wS+uXNAAY8n/ksTFpLy70m L6mWMKCT7hhwPzEr4YPhvZo0QFX5sUFnkdjdB5XTaROncbsjInSos8c8hp0HHwhB7uv8 /ABZSCSfcyXaiLpR+7rMntzSjz5KIpgkBiOGU6SHXOywVO9DYZFLtnUpUTLyj9hq35UH 1Ji1UcJYERctwAvATCLjzXr1XQBcjrmAsDE/F1ONuk9AnJ5LkEG8RxXFAtVaJkHMkSwX jkIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783450265; x=1784055065; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rTSr9YvA6zvfbdCXk8bx0rwgDXQY6cKDFEPWMlli5ik=; b=WeRqqgDF6tD+D0NMYUlrjwV7GpkaJLyf4VPLUohVkUecXoaZsbn8t55Mfqlb1uaU1T GtlqKKkTvdrff+1lnnmnmyeTw4F3SJUossvF9/8oeuIUsg9EBf07bOpMFD+cxh+vNvnk 2nOEprF6ey9enhao8fg+EktHGvlt01IQ2N65ZCNDjcJyrn8Hbdjwv0idmRbFVUDUi08a wWrSJG20YewFpGYXD77zfzcQlu9sqGD76PpAGp1BwCv8lvdShgVv6OLdY5w+wUJ/jh1C EFPGFSh6Kys/Ry1jctX/CR/Bgfi4pNI4Zj5b5gugVKBcrhiHkOiXlpELLgXraUeOLTw0 NtFw== X-Forwarded-Encrypted: i=1; AHgh+RoRB+TtSlxBwhiph0NEbR9umj5LZQetkYpVm/xEpWF5qvVnOkMEnhgrf/gLCs4Wg5TbQRTUyKQgyeouk/s=@vger.kernel.org X-Gm-Message-State: AOJu0YzX0LSmkVUO0HkOh9qhBrL4Cn30hCZWk/AKnv0fy5ZAO7t13F90 l8dZ+07uJQzt9Nx6RF9LdlAFZitXGcto4OY0IbAC1Zpf1GR3aeq1hCs/ X-Gm-Gg: AfdE7ckXRZXNSC39gX3cCjLE3TwmSmefQeOaCRi55lLnCAZk1nCbOSQoQINN3v+Aegk NxherRZsJDFNjS5svygI7fqyEtjUrZD0r93RonzziXcobS9wms5uMsoD93LVTnExWdFG3yiT5qD zktasOEh5U8X8en3IHq2detJbfzBNH27eR4yzfrPFVUfx7lB45yzwZjJPN84evr/XXAZOVypqW+ TmBcHdXVjqfAQgfHghmyy8f8kqtW9ke8v43xPG42AOGg0hpdn5QlUJ4EJeGzJQXyvJNVFs3C/Xo Vu63k9KCBOzvhzcR0UYSMzBzO4Wpp8LskRIkRwQNGnyIeSEDtsqyLJ4wB5JX4M6Pj3D73Z8LDhj q8+KJJcHpKp9RjGa1mb/gevBA4iwvTCEMJExTZY3mkl3sQHOeEJMRLw8zaPKRc6vLkVLt0VKZmP JR8aScNDPiKeUKfCrgsvldiQacFa8NiW5NXHlYUgc2qrDu32ssKVtUpq/KIi0kdjmaTPX0iFrUH 3qLSSNrWtJ+F3U= X-Received: by 2002:a05:622a:2443:b0:517:8069:8b07 with SMTP id d75a77b69052e-51c74801deemr70992621cf.29.1783450264903; Tue, 07 Jul 2026 11:51:04 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f471813c8dsm165950936d6.25.2026.07.07.11.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 11:51:04 -0700 (PDT) From: Yuho Choi To: Manivannan Sadhasivam Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Adam Xue , Krishna Chaitanya Chundru , Kees Cook , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] bus: mhi: host: Fix controller cleanup on EDL sysfs failure Date: Tue, 7 Jul 2026 14:51:00 -0400 Message-ID: <20260707185100.424891-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mhi_register_controller() adds the controller device before creating the optional trigger_edl sysfs file. If sysfs_create_file() fails, the error path only drops the device reference and leaves the device registered. Add a post-device_add() error path that calls device_del() before put_device(), matching the normal unregister path. Fixes: 17553ba8e19d ("bus: mhi: host: Add sysfs entry to force device to enter EDL") Signed-off-by: Yuho Choi --- drivers/bus/mhi/host/init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index 12dcb1a2753c..fd3050889412 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c @@ -1029,7 +1029,7 @@ int mhi_register_controller(struct mhi_controller *mhi_cntrl, if (mhi_cntrl->edl_trigger) { ret = sysfs_create_file(&mhi_dev->dev.kobj, &dev_attr_trigger_edl.attr); if (ret) - goto err_release_dev; + goto err_del_dev; } mhi_cntrl->mhi_dev = mhi_dev; @@ -1038,6 +1038,8 @@ int mhi_register_controller(struct mhi_controller *mhi_cntrl, return 0; +err_del_dev: + device_del(&mhi_dev->dev); err_release_dev: put_device(&mhi_dev->dev); error_setup_irq: -- 2.43.0