From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 951BC3BE148 for ; Tue, 7 Jul 2026 20:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783455720; cv=none; b=fTDoe0UgzWIyFpu3ujIZvmuHzPsFaicET1xpKcSHeAG6W65F4nbrBnhx/xlgwG7IG6A4CrH+ftSTzNNjQCRzqyEZCgXMlrasDGEG3xf25KnQ8fU6HN7varDeAJrf9zWgrhGhIj77eSVwuhwy8yk0XxZfwXvSYhJmWwNUXybomaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783455720; c=relaxed/simple; bh=4NG8zneOYe7p0UrTp9P9R7HnMyKE7GyM9DN8ppk6JVo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N4ixhQc2PY4fU9bkvs9W5B+eSC7SGpBmxsLujjppdMiZyaptc8tbZYH1qs3iRNltAkoaSbypBEVee2t11Vo/pExpTziIuZLjQJi4kx7A9/EycNfqUQatsdMcdEAHmqzlFBgP01OHXi85eCmwfGp7tD1qpJ+Pw5YTzRFnZL15bOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O3tSpu/d; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O3tSpu/d" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-69a50189d25so4676838a12.3 for ; Tue, 07 Jul 2026 13:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783455717; x=1784060517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UMhE6Jch/T1UvoknEZxvYaZzdpc2xBp5cw8Z7tMZGzI=; b=O3tSpu/dmCaGYJzcRxizKfmzqm1qgD4qnzUV+LvLMVUrblgcvmpVwU8Y4yhU21+qoG R0JKauEfvnPUItA8t2v8pSMr9q9mthuk+bSnFBoLjSRNKmDtva3btAT6Sw7VtHRUypI6 da4yJ6RWwbSj8PcYjpO02c5WtjUAOFwgp8P0RJLlOrEWcQMrwQ3wjZTcUCFTQiYVEjEa eQacrUVGVVS6JfjEnMOUhZ7krHQtMlyGpFSei11dM/w7SEUBctFuMKt8eACFVQkdGl3K HYFq2OONlwpsCu+hPYanKPWoECXVEdnUYqWjpih86yoRxVGrcNx2Z9l7urp21eFWFG2/ WsyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783455717; x=1784060517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UMhE6Jch/T1UvoknEZxvYaZzdpc2xBp5cw8Z7tMZGzI=; b=WFPzNu+NWLYhWOQAFXFgyCZnR7OwS9NOC8EuUUZY//4FlHGNFIrMWpLN/6lt8NA8LA 8r/Dh/VufhfQilRVqtZb/9JxZM6VdtuUpJ0xuVhWSj4hvJMHJ9Jhh2l1kIjL4kge5wxz wsV8stxbnO5BXZtBWzL8ee2EI2XW6XZYCZyiZHVOY36lh1vE1NnZfyx7ZdgWwGMqBaQp AzEYB8vwPXh1ZK2wlFSaRda5a3mwkE+7B3V+wCVHoDzvevY4abnaoBPR7hIFk3yPmsbG d3CCIjXkdAZ9YHVb0XTAWxXe62WzdQT5ehfF1Y3nc+Sw8yZ8dywB5jY+GMdQW70b+BCR um+w== X-Gm-Message-State: AOJu0YyK+ZhEqaekc+oeMB80TfhOtSL64JD3myoScYZgK1+/v2gYyN6n PyMNoUmbxuW8M/N/5qnAz7tKiMNRbPQ6RLFCWOKYHh1F8hERW47A8xwZ X-Gm-Gg: AfdE7cmnxKLO81vvlYxgVbfHjyLhT67VE1jOHcCSyUfzLlLfbAREWZvWH3KHGRiReQS Cnkba4edk7z2Ei5liclDHsP9DeOm2htkdzUbSaudmHGqpS4AhZQmgnuJtsD/kdCiTvY89AMIOY4 fJ5J59pJt/TW39AkQJQH3zDTry4pUtukPDjA/Z4fPNrIpsKr/68z6/spS5ftziE5ZHTrgCloe+b CtgRVgA74VrZpQJVn9sP1T9xqWREKGFpWM6OPKHRrtAwWBhZI2SjSYcGmcbXntTjmgmKZu4Y9Qe 62HpPpOpEuxV+tLhQ0xKJESl7M/Y16Xp5dFUm0OzyeB4Xyh7pswaL20gsnOGgCy9P8ppQP1xZ6e VjkyTfBr3sVM5wYwHPZpIrfJtxDf6Ua0mU3VVv+IVuJmvHlvQ8cphDOqczSCG32t1T3BBRfa0L+ 6wki+3VMNTW1mLAIi0t+OdS1Sbh0Q0CUZI1HFJ/m8brZSbWamdTmf7HB4zM8PRyDw= X-Received: by 2002:a05:6402:5514:b0:698:b25b:8df with SMTP id 4fb4d7f45d1cf-69a85bf392fmr3470762a12.21.1783455716979; Tue, 07 Jul 2026 13:21:56 -0700 (PDT) Received: from node ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69aa6dba523sm637930a12.0.2026.07.07.13.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 13:21:56 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com, jorge.lopez2@hp.com, Thomas.Weissschuh@linutronix.de, superm1@kernel.org, W_Armin@gmx.de, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v3 3/4] platform/x86: hp-bioscfg: accept reduced ACPI packages from older HP BIOS Date: Wed, 8 Jul 2026 01:21:10 +0500 Message-ID: <20260707202111.35414-4-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260707202111.35414-1-meatuni001@gmail.com> References: <20260707202111.35414-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hp_init_bios_package_attribute() hard-fails when a WMI ACPI package contains fewer elements than the type-specific expected count (e.g. 11 elements instead of 13 for INTEGER or ENUMERATION attributes). This causes the entire hp_bioscfg driver to skip attribute enumeration on older HP hardware whose BIOS returns shortened packages when optional fields like prerequisites or possible values are absent. Observed on HP EliteBook 840 G2 (BIOS M71 Ver. 01.31): hp_bioscfg: ACPI-package does not have enough elements: 11 < 13 The element layout has two tiers: - Elements 0-9 (SECURITY_LEVEL+1 = 10): common to all attribute types - Elements 10-N: type-specific (bounds, values, encodings, ...) The per-type populate functions (hp_populate_*_elements_from_package) already handle sparse packages correctly via their own elem < count loop guards and inner-loop bounds checks. The only unsafe case is when we lack even the common elements needed to register the attribute. Fix by introducing COMMON_ELEM_CNT to mark the hard minimum (10), and splitting the check into two tiers: - Fewer than COMMON_ELEM_CNT elements: hard fail, can't proceed. - Fewer than expected type-specific elements: warn, but let the populate function parse what is available. Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 11 ++++++++--- drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 3 +++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c index 768330d291da8..78019644ec358 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -661,12 +661,17 @@ static int hp_init_bios_package_attribute(enum hp_wmi_data_type attr_type, int ret = 0; /* Take action appropriate to each ACPI TYPE */ - if (obj->package.count < min_elements) { - pr_err("ACPI-package does not have enough elements: %d < %d\n", - obj->package.count, min_elements); + if (obj->package.count < COMMON_ELEM_CNT) { + pr_err("ACPI-package is missing common elements: %d < %d\n", + obj->package.count, COMMON_ELEM_CNT); goto pack_attr_exit; } + if (obj->package.count < min_elements) { + pr_warn("ACPI-package has fewer elements than expected: %d < %d, parsing available elements\n", + obj->package.count, min_elements); + } + elements = obj->package.elements; /* sanity checking */ diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h index 416d7e7aaaae3..ac57d6eab4c35 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h @@ -279,6 +279,9 @@ enum hp_wmi_data_elements { PSWD_ENCODINGS = 13, PSWD_IS_SET = 14, PSWD_ELEM_CNT = 15, + + /* Minimum elements shared by all attribute types (NAME..SECURITY_LEVEL) */ + COMMON_ELEM_CNT = SECURITY_LEVEL + 1, }; #define GET_INSTANCE_ID(type) \ -- 2.55.0