The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: remove unused rtl8192c function declarations
Date: Tue, 7 Jul 2026 13:11:33 +0200	[thread overview]
Message-ID: <2026070721-retorted-geologist-02e3@gregkh> (raw)
In-Reply-To: <20260619083736.577096-1-inasj268@gmail.com>

On Fri, Jun 19, 2026 at 09:37:34AM +0100, Jad Keskes wrote:
> Remove two function declarations from rtl8192c_recv.h that have no
> implementation and are never called in the rtl8723bs driver:
> 
>   - rtl8192c_translate_rx_signal_stuff()
>   - rtl8192c_query_rx_desc_status()
> 
> These are leftovers from the original Realtek multi-chip codebase
> and relate to the RTL8192C family, not the RTL8723B.
> 
> Signed-off-by: Jad Keskes <inasj268@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> index 1f86654f0403..b63625ab4e45 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> @@ -30,7 +30,4 @@ struct phy_stat {
>  /*  Rx smooth factor */
>  #define	Rx_Smooth_Factor (20)
>  
> -void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
> -void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
> -
>  #endif
> -- 
> 2.54.0
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  parent reply	other threads:[~2026-07-07 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  8:37 [PATCH 1/3] staging: rtl8723bs: remove unused rtl8192c function declarations Jad Keskes
2026-06-19  8:37 ` [PATCH 2/3] staging: rtl8723bs: remove unused AMPDU burst mode values Jad Keskes
2026-06-19  8:37 ` [PATCH 3/3] staging: rtl8723bs: remove unused RF_PATH_MAX_90_8812 define Jad Keskes
2026-07-07 11:11 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-18 20:56 [PATCH 1/3] staging: rtl8723bs: remove unused rtl8192c function declarations Jad Keskes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070721-retorted-geologist-02e3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=inasj268@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox