From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA075331EC7 for ; Tue, 7 Jul 2026 23:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783467686; cv=none; b=tGCob14y+FE9/jzHwCdrILz7DtiNZeRbjUn83dHbTQFWRxH+lbCK/ahIFHq5+j5bqoktu2azmc6cm8plXRI9rpMSVuLzHh792YUVo4uuu1veAA5riTuxJuOIRXStUA7g1VN/mxKdE52jzfvvJVFPWuz9z9tNPjPPOKfnIwCAv1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783467686; c=relaxed/simple; bh=Rjqrr/hC9TnhgfjpdNRf9JuFmHqnqJAT1UsxTqUUPg8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=H5JjAraXuzRZ4X770wvkg3OrVXjUlOBHCa9sy1tD7v59Ij2ymH5UusLEYejX4I+dDD10JC33h/RR9h39fiyzZdHhGto0M7i5Qp032mEYYPLS9n259ImBSkkOClSHvagkKuc4h23zqTkeET/J/X0bAeNe6ixsnBStmvd1PK7Xdwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BXaSJkeF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BXaSJkeF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C5D1F00AC4; Tue, 7 Jul 2026 23:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783467685; bh=80fXDKR6QtBMPK4OI5XLKExc7cNKNao0fsEfaXYC7O4=; h=Date:From:To:Cc:Subject:References; b=BXaSJkeFAem9cCspu99iTd50U3brJgcoVAZWMPisefm4Dl0D2DZ+Z3r2y6rqk4d3Y ya4YuoPQwEiKb+9qq4mHI4XMsqZFPv0YIZCGJN2eQ00aGAS2qTxAZlwDxB93jJNtFb OrENIGMoI0AngUTT0YAleaFkSE1ymhvfKzI3TJRQRY5YHakZtJCDS4g59O90TnacZF F0IYdczMB+ygdcvLHb2U8VG9x3Op26CSXDowxZER0rIeBUEY08eM9s6DCVm51rT07k LCjODjLsCCVkTZeSXqEevi69ODho4IzN0xWHX41Ojfblmf7fEHjnTNi9FS8t/bo4Le 1SFXgKCPVe4Rw== Received: from rostedt by gandalf with local (Exim 4.99.4) (envelope-from ) id 1whFPt-00000000xqO-38I9; Tue, 07 Jul 2026 19:41:29 -0400 Message-ID: <20260707234129.583136262@kernel.org> User-Agent: quilt/0.69 Date: Tue, 07 Jul 2026 19:34:23 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Yu Peng Subject: [for-linus][PATCH 2/2] tracing/synthetic: Free type string on error path References: <20260707233421.684046879@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Yu Peng parse_synth_field() builds a "__data_loc ..." type string before assigning it to field->type. If the seq_buf check fails, the common cleanup cannot free the temporary string. Free it before leaving. Link: https://patch.msgid.link/20260603062533.1096320-2-pengyu@kylinos.cn Signed-off-by: Yu Peng Signed-off-by: Steven Rostedt --- kernel/trace/trace_events_synth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index cdd5b9332835..dc15658a887c 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -839,8 +839,10 @@ static struct synth_field *parse_synth_field(int argc, char **argv, seq_buf_puts(&s, "__data_loc "); seq_buf_puts(&s, field->type); - if (WARN_ON_ONCE(!seq_buf_buffer_left(&s))) + if (WARN_ON_ONCE(!seq_buf_buffer_left(&s))) { + kfree(type); goto free; + } s.buffer[s.len] = '\0'; kfree(field->type); -- 2.53.0